Your message dated Sun, 25 Dec 2011 18:47:43 +0000
with message-id <[email protected]>
and subject line Bug#651581: fixed in sac 1.9b5-3
has caused the Debian Bug report #651581,
regarding sac ftbfs on armel and armhf. struct user conflicts with system header
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
651581: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=651581
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: sac
severity: serious
tags: patch sid wheezy

Sac defines a struct called "struct user". On armel and armhf this conflicts with "struct user" in sys/user.h which is indirectly included by your program.

This bug is known to affect sid and wheezy. It does not affect lenny and squeeze.

The attatched patch fixes ths issue by renaming the struct
diff -ur sac-1.9b5/gronk.c sac-1.9b5.new/gronk.c
--- sac-1.9b5/gronk.c	2004-03-29 21:00:12.000000000 +0000
+++ sac-1.9b5.new/gronk.c	2011-12-10 02:29:24.000000000 +0000
@@ -634,7 +634,7 @@
       if (lp->port == port) break;
 
     if (st) {
-      struct user *p;
+      struct sac_user *p;
 
       for(p=usr;p;p=p->nxt)
 	if (!strncmp(su->u.ut_line,p->line,UT_LINESIZE) && (hosttoo? !strncmp(su->u.ut_host,p->host,UT_HOSTSIZE) : TRUE)) goto found_one;
diff -ur sac-1.9b5/proto.h sac-1.9b5.new/proto.h
--- sac-1.9b5/proto.h	2003-03-20 22:52:02.000000000 +0000
+++ sac-1.9b5.new/proto.h	2011-12-10 02:25:58.000000000 +0000
@@ -14,10 +14,10 @@
 void do_reboot(time_t t);
 void changetime(time_t t, char *line);
 void cleanup(void);
-void release(struct user *u, time_t t, struct sactmp *su, int usext, int siminc);
+void release(struct sac_user *u, time_t t, struct sactmp *su, int usext, int siminc);
 void addlogin(struct login **login, struct login **last, time_t in, time_t out, char *name, char *tty, char *host);
 void apply_hours(time_t in, time_t out,time_t start, time_t h[24]);
-void user_apply_hours(struct user *u, time_t out, struct day *d);
+void user_apply_hours(struct sac_user *u, time_t out, struct day *d);
 void tty_apply_hours(time_t in, time_t out, struct day *d, struct tty *t);
 char *getwrd(char *s);
 struct usr *adduser(struct usr **up, char *s);
diff -ur sac-1.9b5/sac.c sac-1.9b5.new/sac.c
--- sac-1.9b5/sac.c	2011-12-10 02:31:46.000000000 +0000
+++ sac-1.9b5.new/sac.c	2011-12-10 02:24:52.000000000 +0000
@@ -671,7 +671,7 @@
 
 void saclogin(struct sactmp su)
 {
-  struct user *q;
+  struct sac_user *q;
   struct day *d;
   struct usr *u = NULL, *up;
   int l;
@@ -683,7 +683,7 @@
   saclogout(su,FALSE);
 
 /*   printf ("Logging in  %s [%s] <%ld>...\n",u.ut_user,u.ut_line,u.ut_time); */
-  q = bmalloc(sizeof(struct user));
+  q = bmalloc(sizeof(struct sac_user));
   strncpy(q->line,su.u.ut_line,UT_LINESIZE);
   strncpy(q->user,su.u.ut_user,UT_NAMESIZE);
   strncpy(q->host,su.u.ut_host,UT_HOSTSIZE);
@@ -744,7 +744,7 @@
 
 void saclogout(struct sactmp su, int usext)
 {
-  struct user *p, *q;
+  struct sac_user *p, *q;
   struct usr *u = NULL, *up;
   struct day *d;
 
@@ -841,7 +841,7 @@
  */
 void do_reboot(time_t t)
 {
-  struct user *p;
+  struct sac_user *p;
   struct day *d;
   struct usr *u;
 
@@ -884,7 +884,7 @@
 void changetime(time_t t, char *line)
 {
   static time_t old = 0;
-  struct user *p;
+  struct sac_user *p;
   signed long dif;
 
   if (!strcmp("|",line)) {
@@ -913,7 +913,7 @@
 {
   time_t t = time(0);
   struct day *lastday;
-  struct user *p;
+  struct sac_user *p;
   struct usr *u;
 
 /* Ooops, the -t option can't just ignore time that isn't in our days list
@@ -954,11 +954,11 @@
  *   out >= start  &&  out <= stop ||
  *   in  <  start  &&  out >  stop
  */
-void release(struct user *u, time_t t, struct sactmp *su, int usext, int siminc)
+void release(struct sac_user *u, time_t t, struct sactmp *su, int usext, int siminc)
 {
   struct day *p;
   struct usr *up;
-  struct user *q;
+  struct sac_user *q;
   struct tty *tp;
   struct simuse *s;
   int i;
@@ -1250,7 +1250,7 @@
   }
 }
 
-void user_apply_hours(struct user *u, time_t out, struct day *d)
+void user_apply_hours(struct sac_user *u, time_t out, struct day *d)
 {
   int i;
   time_t b, e;
diff -ur sac-1.9b5/sac.h sac-1.9b5.new/sac.h
--- sac-1.9b5/sac.h	2002-04-23 15:03:48.000000000 +0000
+++ sac-1.9b5.new/sac.h	2011-12-10 02:28:21.000000000 +0000
@@ -145,12 +145,12 @@
   struct hosts *nxt;
 };
 
-struct user {
+struct sac_user {
   char user[UT_NAMESIZE+1];
   char line[UT_LINESIZE+1];
   char host[UT_HOSTSIZE+1];
   time_t in;
-  struct user *nxt;
+  struct sac_user *nxt;
 };
 
 enum filetype {
@@ -196,7 +196,7 @@
 EXTERN struct simuse *simuse INIT(NULL);
 EXTERN struct tty *ttys INIT(NULL);
 EXTERN struct hosts *hosts INIT(NULL);
-EXTERN struct user *usr INIT(NULL);
+EXTERN struct sac_user *usr INIT(NULL);
 
 #ifdef MAIN
   char *month[13] = {

--- End Message ---
--- Begin Message ---
Source: sac
Source-Version: 1.9b5-3

We believe that the bug you reported is fixed in the latest version of
sac, which is due to be installed in the Debian FTP archive:

sac_1.9b5-3.diff.gz
  to main/s/sac/sac_1.9b5-3.diff.gz
sac_1.9b5-3.dsc
  to main/s/sac/sac_1.9b5-3.dsc
sac_1.9b5-3_i386.deb
  to main/s/sac/sac_1.9b5-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Javier Fernandez-Sanguino Pen~a <[email protected]> (supplier of updated sac 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 25 Dec 2011 19:27:17 +0100
Source: sac
Binary: sac
Architecture: source i386
Version: 1.9b5-3
Distribution: unstable
Urgency: low
Maintainer: Javier Fernandez-Sanguino Pen~a <[email protected]>
Changed-By: Javier Fernandez-Sanguino Pen~a <[email protected]>
Description: 
 sac        - Login accounting
Closes: 651581
Changes: 
 sac (1.9b5-3) unstable; urgency=low
 .
   * Fix "sac ftbfs on armel and armhf. struct user conflicts with system
     header": add patch from Peter Green (renames struct user to sac_user).
     (Closes: #651581)
     Thanks to Gregor Herrmann for preparing a fix for this bug.
Checksums-Sha1: 
 7e9811911322636b49ccdb78eb4fd54d5c0c2d74 950 sac_1.9b5-3.dsc
 9640067ea85692a6354a85d41140a2c51a026ad7 6884 sac_1.9b5-3.diff.gz
 29433afa76daed1ed27631577f4fef93d2042ec9 61816 sac_1.9b5-3_i386.deb
Checksums-Sha256: 
 f9ed2a5dd963a4f83850f645d30380523c1cfb023e9d6b9e3d8af65782eca7ba 950 
sac_1.9b5-3.dsc
 cd5320cdecbcd1b64c9460c76bbf0134a5fafa544f8c9e35ba8049f6f613b983 6884 
sac_1.9b5-3.diff.gz
 84e6163053534f462cd9eac3bcecb18f63e1a81821f559712d19ac677ccc1bcb 61816 
sac_1.9b5-3_i386.deb
Files: 
 a0ce3099e9f97ae0040483e0c5f20dd2 950 admin optional sac_1.9b5-3.dsc
 70514fb682f56ad418e67b6dfead58a2 6884 admin optional sac_1.9b5-3.diff.gz
 8455beeaf49159ebf86c05836b1b1974 61816 admin optional sac_1.9b5-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFO92vpsandgtyBSwkRAlAPAJ9wkPjOWbOCBIIjzQb/XG1W1gq3nACeKmGj
axCPWyCBnuHdlgs7Zad0zew=
=ohDH
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to