Your message dated Fri, 13 Jan 2012 17:47:09 +0000 with message-id <e1rlldz-0000d9...@franck.debian.org> and subject line Bug#654692: fixed in backuppc 3.1.0-9.1 has caused the Debian Bug report #654692, regarding data corruption due to error logging on stdout (debian specific) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 654692: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=654692 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: backuppc Version: 3.1.0-9 Severity: grave Tags: squeeze patch Hi, The following Debian-specific patch logs errors to standard out instead of standard error: +++ backuppc-3.1.0/lib/BackupPC/Lib.pm from_to($path, "utf8", $need->{charsetLegacy}) if ( $need->{charsetLegacy} ne "" ); - return if ( !opendir(my $fh, $path) ); +# return if ( !opendir(my $fh, $path) ); + my ($fh); + if ( !opendir($fh, $path) ) { + print "log ERROR: opendir ($path) failed\n"; This can cause data corruption (experienced by us in the field) because these errors may end up inside a generated tarball used for restoring data, hence breaking said tarball. Attached patch improves the logging such that it logs to stderr instead, and also skips the case in which the directory simply doesn't exist, in which case the error is spurious (thereby also addressing #558431). Can you please see if this patch can be included in the upcoming stable point release? I can also build and upload packages for that if you don't have the time right now. As for wheezy/sid, this problem does not apply because the entire code block has been removed in 3.1.0-10: * Removed useless logging. Closes: #558431 However, the logging is only useless in the case of ENOENT. In all other cases it's correct to report an error (e.g.: filesystem corrupt). So I would suggest to reintroduce the patch / forward it to upstream but then obviously with the stderr fix and the provision for ENOENT. Cheers, Thijs -- System Information: Debian Release: 6.0.3 APT prefers stable APT policy: (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bashdiff -u backuppc-3.1.0/lib/BackupPC/Lib.pm backuppc-3.1.0/lib/BackupPC/Lib.pm --- backuppc-3.1.0/lib/BackupPC/Lib.pm +++ backuppc-3.1.0/lib/BackupPC/Lib.pm @@ -488,7 +488,8 @@ # return if ( !opendir(my $fh, $path) ); my ($fh); if ( !opendir($fh, $path) ) { - print "log ERROR: opendir ($path) failed\n"; + print STDERR "ERROR: opendir ($path) failed: $!\n" + unless $!{ENOENT}; return; } diff -u backuppc-3.1.0/debian/changelog backuppc-3.1.0/debian/changelog --- backuppc-3.1.0/debian/changelog +++ backuppc-3.1.0/debian/changelog @@ -1,3 +1,10 @@ +backuppc (3.1.0-9.1) stable; urgency=low + + * Non-maintainer upload. + * Fix data corruption in tarballs due to logging to stdout. + + -- Thijs Kinkhorst <th...@debian.org> Thu, 05 Jan 2012 10:24:29 +0100 + backuppc (3.1.0-9) unstable; urgency=low * chown/chmod only the needed dirs. Closes: #531948
--- End Message ---
--- Begin Message ---Source: backuppc Source-Version: 3.1.0-9.1 We believe that the bug you reported is fixed in the latest version of backuppc, which is due to be installed in the Debian FTP archive: backuppc_3.1.0-9.1.diff.gz to main/b/backuppc/backuppc_3.1.0-9.1.diff.gz backuppc_3.1.0-9.1.dsc to main/b/backuppc/backuppc_3.1.0-9.1.dsc backuppc_3.1.0-9.1_all.deb to main/b/backuppc/backuppc_3.1.0-9.1_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 654...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Thijs Kinkhorst <th...@debian.org> (supplier of updated backuppc package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Wed, 11 Jan 2012 20:17:35 +0100 Source: backuppc Binary: backuppc Architecture: source all Version: 3.1.0-9.1 Distribution: stable Urgency: low Maintainer: Ludovic Drolez <ldro...@debian.org> Changed-By: Thijs Kinkhorst <th...@debian.org> Description: backuppc - high-performance, enterprise-grade system for backing up PCs Closes: 558431 641450 646865 654692 Changes: backuppc (3.1.0-9.1) stable; urgency=low . * Non-maintainer upload. * Fix data corruption in tarballs due to logging to stdout (closes: #654692, #558431) * Fix XSS issue (CVE-2011-3361 CVE-2011-4923, closes: #641450, #646865) Checksums-Sha1: a4f475d9ab8a68eae5d40cc853c02380c98d0402 1305 backuppc_3.1.0-9.1.dsc 7899842c29a6751a89a61da6dfe950a4210d2526 27277 backuppc_3.1.0-9.1.diff.gz a6931c097126ca0a91debdbffce729e42c486dfd 560748 backuppc_3.1.0-9.1_all.deb Checksums-Sha256: 0f70359ef28d22ebfc2b993c7fb9ddcc9e3029b6050a65e8261f91f863c67014 1305 backuppc_3.1.0-9.1.dsc 2a6a986da590455a9e4a26220915212c57a002eb1016cfdbf6755d061802c571 27277 backuppc_3.1.0-9.1.diff.gz 1f212af45e4cfac5f056e56bd4ab032a6ba597fa78c8ad31b7a9de96c74f8eda 560748 backuppc_3.1.0-9.1_all.deb Files: d128b5bb306412142e62306f697d76d5 1305 utils optional backuppc_3.1.0-9.1.dsc ec82497735d309aec4e5c4cfcf4aa3e0 27277 utils optional backuppc_3.1.0-9.1.diff.gz 9858f9ae05af18d5244a3b6ca7796776 560748 utils optional backuppc_3.1.0-9.1_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEcBAEBAgAGBQJPDeC/AAoJEOxfUAG2iX57CikIANVNTpm9nmxivaYbgzaUFFD4 Rq2Z91CpFQlYTdrX9HQLW/pP3fjUdGBtKuLlDdEYlrw4z7t1c94D/jorDrv5dwJc TbITLrpcImRfqjE/ilJ8wltdoOD1SuDauwOOMnzVJQP5u0Qpdl4FpSxjBM8LaXOg /b/59wUa1vHf6V9lVbtBqJUIuFDDo3+v2Z52YXBDs2ezO9ZWBRaqqlCIzeBkcrFz n5gac14n3g/Wz7N5zCQw1P5SVBQY/JM6wjWkasL5rdUoyreHSMJUkRTkbiFBFf3A u95munTrpCKDWEZk3iTMQFotF4upPTQewlDt+kVad/eQcVkRC8dGVKNG6PhgltQ= =8jzp -----END PGP SIGNATURE-----
--- End Message ---
