reassign 652598 src:aboot 1.0~pre20040408-3 tags 652598 + upstream patch quit
Hi, peter green wrote: > package: aboot > severity: serious > > Aboot FTBFS with the following error Yep, I can reproduce this; thanks for filing it. Just some quick tips for the future: 1. Please use "Source: aboot", not "Package: aboot". 2. Please indicate what version the report concerns. Doing those things makes the maintainers' lives easier, for example by saving them from spending time trying to track down the cause of the bug using the wrong source package (think: automake vs automake1.11) or the wrong version of the source code (think: sid versus wheezy). [...] > In file included from ../include/isolib.h:10:0, from isomarkboot.c:33: > /usr/include/x86_64-linux-gnu/asm/stat.h:68:8: error: redefinition of ‘struct > stat’ > /usr/include/x86_64-linux-gnu/bits/stat.h:46:8: note: originally defined here Looks like the cause is that isolib.h #include-s <asm/stat.h> from linux-libc-dev which conflicts in namespace with sys/stat from glibc. So in the spirit of aboot (1.0~pre20040408-2) unstable; urgency=low * Include userspace headers from lib/isolib.c instead of kernel headers; this isn't kernel code anyway, and the kernel headers don't work right on i386 the way they're being used. does this patch help? By the way, do you know which package changed to introduce this build failure? (I would have guessed glibc, but I haven't found a relevant change.) Curious, Jonathan diff --git a/include/isolib.h b/include/isolib.h index 392327a..7353da1 100644 --- a/include/isolib.h +++ b/include/isolib.h @@ -1,13 +1,7 @@ #ifndef isolib_h #define isolib_h -#ifndef __KERNEL_STRICT_NAMES - /* ask kernel to be careful about name-space pollution: */ -# define __KERNEL_STRICT_NAMES -# define fd_set kernel_fd_set -#endif - -#include <asm/stat.h> +#include <sys/stat.h> extern int iso_read_super (void * data, int quiet); extern int iso_open (const char * filename); -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org