Package: sqlgrey Version: 1.8.0rc2-1 Severity: critical Tags: patch, upstream
Hi, Op Wed 15 Feb 2012 om 04:17:57 +0100 schreef Wessel Dankers: > > The sqlgrey script contains the following line: > > $dflt{$var} = $value || 1; > > Which means, “if you try to set this variable to a false value, we'll set > to it 1 anyway”. The probable intention was to prevent undefined values, > but this makes it impossible to configure sqlgrey. Suggested patch: ------------------------------------------------------------------ --- /usr/sbin/sqlgrey 2010-02-11 09:45:53.000000000 +0100 +++ /usr/sbin/sqlgrey 2012-02-15 16:01:38.102502020 +0100 @@ -2492,7 +2492,7 @@ s/\s+$//; # no trailing white next unless length; # anything left ? my ($var, $value) = split(/\s*=\s*/, $_, 2); - $dflt{$var} = $value || 1; + $dflt{$var} = $value // ''; } close CONF or die "Couldn't close config file $config_file\n"; ------------------------------------------------------------------ Bye, Joost - in his role as Wessel's secretary -- Joost van Baal-Ilić http://abramowitz.uvt.nl/ Tilburg University mailto:joostvb.uvt.nl The Netherlands
signature.asc
Description: Digital signature