Your message dated Thu, 21 Jun 2012 17:19:06 +0000
with message-id <e1shl2a-0004ui...@franck.debian.org>
and subject line Bug#632604: fixed in libatomic-ops 7.3~alpha1+git20120621-1
has caused the Debian Bug report #632604,
regarding FTBFS: `make check' fails on test_stack on i386
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
632604: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632604
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libatomic-ops-dev
Version: 7.3~alpha1+git20111031-1
Justification: fails to build from source
Severity: serious
Tags: patch

Upstream commit https://github.com/ivmai/libatomic_ops/commit/30cea1b
fixes AO_compare_double_and_swap_double_full() which is broken on
gcc/x86 and causes `make check' to fail (tested on a sid x86 chroot).

-- 
Emanuele
diff --git c/src/atomic_ops/sysdeps/gcc/x86.h i/src/atomic_ops/sysdeps/gcc/x86.h
index b304dd0..e49f057 100644
--- c/src/atomic_ops/sysdeps/gcc/x86.h
+++ i/src/atomic_ops/sysdeps/gcc/x86.h
@@ -161,13 +161,16 @@ AO_compare_double_and_swap_double_full(volatile AO_double_t *addr,
   /* If PIC is turned on, we can't use %ebx as it is reserved for the
      GOT pointer.  We can save and restore %ebx because GCC won't be
      using it for anything else (such as any of the m operands) */
-  __asm__ __volatile__("pushl %%ebx;"   /* save ebx used for PIC GOT ptr */
-                       "movl %6,%%ebx;" /* move new_val2 to %ebx */
+  /* We use %edi (for new_val1) instead of a memory operand and swap    */
+  /* instruction instead of push/pop because some GCC releases have     */
+  /* a bug in processing memory operands (if address base is %esp) in   */
+  /* the inline assembly after push.                                    */
+  __asm__ __volatile__("xchg %%ebx,%6;" /* swap GOT ptr and new_val1 */
                        "lock; cmpxchg8b %0; setz %1;"
-                       "pop %%ebx;"     /* restore %ebx */
+                       "xchg %%ebx,%6;" /* restore ebx and edi */
                        : "=m"(*addr), "=a"(result)
                        : "m"(*addr), "d" (old_val2), "a" (old_val1),
-                         "c" (new_val2), "m" (new_val1) : "memory");
+                         "c" (new_val2), "D" (new_val1) : "memory");
 #else
   /* We can't just do the same thing in non-PIC mode, because GCC
    * might be using %ebx as the memory operand.  We could have ifdef'd

--- End Message ---
--- Begin Message ---
Source: libatomic-ops
Source-Version: 7.3~alpha1+git20120621-1

We believe that the bug you reported is fixed in the latest version of
libatomic-ops, which is due to be installed in the Debian FTP archive:

libatomic-ops-dev_7.3~alpha1+git20120621-1_i386.deb
  to main/liba/libatomic-ops/libatomic-ops-dev_7.3~alpha1+git20120621-1_i386.deb
libatomic-ops_7.3~alpha1+git20120621-1.diff.gz
  to main/liba/libatomic-ops/libatomic-ops_7.3~alpha1+git20120621-1.diff.gz
libatomic-ops_7.3~alpha1+git20120621-1.dsc
  to main/liba/libatomic-ops/libatomic-ops_7.3~alpha1+git20120621-1.dsc
libatomic-ops_7.3~alpha1+git20120621.orig.tar.gz
  to main/liba/libatomic-ops/libatomic-ops_7.3~alpha1+git20120621.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 632...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ian Wienand <i...@debian.org> (supplier of updated libatomic-ops package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 21 Jun 2012 09:55:15 -0700
Source: libatomic-ops
Binary: libatomic-ops-dev
Architecture: source i386
Version: 7.3~alpha1+git20120621-1
Distribution: unstable
Urgency: low
Maintainer: Ian Wienand <i...@debian.org>
Changed-By: Ian Wienand <i...@debian.org>
Description: 
 libatomic-ops-dev - A library for atomic operations (development files)
Closes: 632604
Changes: 
 libatomic-ops (7.3~alpha1+git20120621-1) unstable; urgency=low
 .
   * Update from upstream git
   * Closes: 632604 -- Fixed by upstream 30cea1b as identified by Emanuele
     Aina and Gregor Herrmann <gre...@debian.org>.  Thanks!
Checksums-Sha1: 
 7afcf044b0a2681f2875b6678827493e28336811 1234 
libatomic-ops_7.3~alpha1+git20120621-1.dsc
 b9a559d8f966f7b72209f041321a3449253e7f71 404974 
libatomic-ops_7.3~alpha1+git20120621.orig.tar.gz
 061282755bfd90f2fb09a962ce15634b2fe18416 10095 
libatomic-ops_7.3~alpha1+git20120621-1.diff.gz
 921978c98321d8cbf6315b12012a8bdc633e13f0 85014 
libatomic-ops-dev_7.3~alpha1+git20120621-1_i386.deb
Checksums-Sha256: 
 8ee91795cb37653c715fecc439e5a880303cd150378fa1beda26c1ddf9b6fcee 1234 
libatomic-ops_7.3~alpha1+git20120621-1.dsc
 c6e41fcd72c39611f23a7d782c439a3ba3e79effe10af5bffe31c2ca025ea614 404974 
libatomic-ops_7.3~alpha1+git20120621.orig.tar.gz
 ff12d9a7fcf573b8805ee518a2c2b055b8874d7978a20f3e55ec6cb18a1b5f3a 10095 
libatomic-ops_7.3~alpha1+git20120621-1.diff.gz
 e7621c66371a6ac4be2ee6ae225a4c4654398ce3b6e67066a5fd6bde9a532f9a 85014 
libatomic-ops-dev_7.3~alpha1+git20120621-1_i386.deb
Files: 
 1f65a09ab01472c0d66e4bd0dc7c53a5 1234 libdevel optional 
libatomic-ops_7.3~alpha1+git20120621-1.dsc
 d0f00047b17a51c14ad937f48e884a3b 404974 libdevel optional 
libatomic-ops_7.3~alpha1+git20120621.orig.tar.gz
 c1734a61c8f67c26729b07d5c665b229 10095 libdevel optional 
libatomic-ops_7.3~alpha1+git20120621-1.diff.gz
 54fae7828c5868232f73f3fd08fc82c1 85014 libdevel optional 
libatomic-ops-dev_7.3~alpha1+git20120621-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAk/jUvMACgkQWDlSU/gp6efcrQCgqg06NLRr2ma6BXHGq2+ZG1f8
nCQAoKOAkNwPZreIvPBk2/eNddyg9HyA
=jV8g
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to