Thanks for this review.

* Vincent Legout <vinc...@legout.info> [120626 17:13]:
> The package seems fine but could you please mention in the changelog
> that you ran wrap-and-sort in debian/control and that you updated
> debian/copyright to remove two trailing spaces.

You're right ; I added this to the changelog.

> Also, the new coinor-libcbc0 package no longer depends on coinor-libvol0
> and libatlas3gf-base. I don't know coinor enough to know if it's
> important or not though (it seems those two packages come with other
> coinor packages like coinor-libcgl0 or coinor-libclp0).

It seems that -cbc did depend on -vol at a time, but not anymore :

https://projects.coin-or.org/Cbc/browser/stable/2.7/Dependencies
https://projects.coin-or.org/Cbc/browser/stable/2.5/Dependencies

I am not sure why the wiki page claims -vol was used in 2.5, as it was
uselessly linked in the previous version :

https://buildd.debian.org/status/fetch.php?pkg=coinor-cbc&arch=amd64&ver=2.5.0-2.3&stamp=1324678369

  dpkg-shlibdeps: warning: dependency on libVol.so.0 could be avoided if
    "debian/coinor-libcbc0/usr/bin/cbc" were not uselessly linked against
    it (they use none of its symbols).
  dpkg-shlibdeps: warning: dependency on liblapack.so.3gf could be
    avoided if "debian/coinor-libcbc0/usr/bin/cbc" were not uselessly
    linked against it (they use none of its symbols).

It's probably the use of dpkg-buildflags that changed the behaviour,
but I believe that it's correct now. I removed the build-dependencies on
-vol and lapack (which pulled atlas) and it builds fine.

I reuploaded the package, it should be available at the same URL :

http://mentors.debian.net/debian/pool/main/c/coinor-cbc/coinor-cbc_2.5.0-3.dsc

> About coinor-ipopt, I think you're right regarding gregor's comment.
> I'll try to upload the package if he doesn't answer or doesn't upload.

It has been uploaded in the meantime, thanks anyway !

-- 
Etienne Millon



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to