Source: givaro Version: 3.7.0-2 Severity: serious Justification: breaks reverse dependencies Tag: patch
http://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html#Include-Syntax givaro-3.7.0/src/kernel/gmp++/gmp++.h specifies an include for one of it's own header files (gmpxx.h) using system include syntax instead of local include syntax. This has two effects: 0: If /usr/include/gmp++/gmp++.h exists when givaro is built, that will be used in preference to the (possibly modified) copy in ./src/kernel/gmp ++/ 1: linbox and other packages which use givaro_check.m4 will fail to build from source because gmpxx.h cannot be found by the configure check. The syntax needs to be changed but also, if givaro used pkg-config, there would be no need for givaro_check.m4 in the first place. -- Neil Williams ============= http://www.linux.codehelp.co.uk/
--- /usr/include/gmp++/gmp++.h +++ /var/cache/pbuilder/build/16013/usr/include/gmp++/gmp++.h @@ -30,7 +30,7 @@ #if !defined(GMP_VERSION_3) && !defined(GMP_NO_CXX) && !defined(__GIVARO_GMP_VERSION_3) && !defined(__GIVARO_GMP_NO_CXX) // gmpxx.h defines __GMP_PLUSPLUS__ -#include <gmpxx.h> +#include "gmpxx.h" #endif #ifdef __GIVARO_GMP_VERSION_3
pgpbC8hAYKLRx.pgp
Description: PGP signature
