Your message dated Wed, 03 Oct 2012 15:47:25 +0000
with message-id <e1tjrat-0005ft...@franck.debian.org>
and subject line Bug#632604: fixed in libatomic-ops 
7.2~alpha5+cvs20101124-1+deb7u0
has caused the Debian Bug report #632604,
regarding FTBFS: `make check' fails on test_stack on i386
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
632604: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632604
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libatomic-ops-dev
Version: 7.3~alpha1+git20111031-1
Justification: fails to build from source
Severity: serious
Tags: patch

Upstream commit https://github.com/ivmai/libatomic_ops/commit/30cea1b
fixes AO_compare_double_and_swap_double_full() which is broken on
gcc/x86 and causes `make check' to fail (tested on a sid x86 chroot).

-- 
Emanuele
diff --git c/src/atomic_ops/sysdeps/gcc/x86.h i/src/atomic_ops/sysdeps/gcc/x86.h
index b304dd0..e49f057 100644
--- c/src/atomic_ops/sysdeps/gcc/x86.h
+++ i/src/atomic_ops/sysdeps/gcc/x86.h
@@ -161,13 +161,16 @@ AO_compare_double_and_swap_double_full(volatile AO_double_t *addr,
   /* If PIC is turned on, we can't use %ebx as it is reserved for the
      GOT pointer.  We can save and restore %ebx because GCC won't be
      using it for anything else (such as any of the m operands) */
-  __asm__ __volatile__("pushl %%ebx;"   /* save ebx used for PIC GOT ptr */
-                       "movl %6,%%ebx;" /* move new_val2 to %ebx */
+  /* We use %edi (for new_val1) instead of a memory operand and swap    */
+  /* instruction instead of push/pop because some GCC releases have     */
+  /* a bug in processing memory operands (if address base is %esp) in   */
+  /* the inline assembly after push.                                    */
+  __asm__ __volatile__("xchg %%ebx,%6;" /* swap GOT ptr and new_val1 */
                        "lock; cmpxchg8b %0; setz %1;"
-                       "pop %%ebx;"     /* restore %ebx */
+                       "xchg %%ebx,%6;" /* restore ebx and edi */
                        : "=m"(*addr), "=a"(result)
                        : "m"(*addr), "d" (old_val2), "a" (old_val1),
-                         "c" (new_val2), "m" (new_val1) : "memory");
+                         "c" (new_val2), "D" (new_val1) : "memory");
 #else
   /* We can't just do the same thing in non-PIC mode, because GCC
    * might be using %ebx as the memory operand.  We could have ifdef'd

--- End Message ---
--- Begin Message ---
Source: libatomic-ops
Source-Version: 7.2~alpha5+cvs20101124-1+deb7u0

We believe that the bug you reported is fixed in the latest version of
libatomic-ops, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 632...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
gregor herrmann <gre...@debian.org> (supplier of updated libatomic-ops package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 03 Oct 2012 17:35:27 +0200
Source: libatomic-ops
Binary: libatomic-ops-dev
Architecture: source amd64
Version: 7.2~alpha5+cvs20101124-1+deb7u0
Distribution: testing-proposed-updates
Urgency: low
Maintainer: Ian Wienand <i...@debian.org>
Changed-By: gregor herrmann <gre...@debian.org>
Description: 
 libatomic-ops-dev - A library for atomic operations (development files)
Closes: 632604
Changes: 
 libatomic-ops (7.2~alpha5+cvs20101124-1+deb7u0) testing-proposed-updates; 
urgency=low
 .
   * Non-maintainer upload with maintainer's permission.
   * Fix "FTBFS on i386": apply patch from upstream git repo:
     https://github.com/ivmai/libatomic_ops/commit/30cea1b#diff-0
     Thanks to Emanuele Aina for the pointer.
     (Closes: #632604)
Checksums-Sha1: 
 05f16beef91f5c032cc6559dae3e3913189b2bce 1925 
libatomic-ops_7.2~alpha5+cvs20101124-1+deb7u0.dsc
 f4a643150ad654c4d2fccb62d432fa93879cfcb8 10625 
libatomic-ops_7.2~alpha5+cvs20101124-1+deb7u0.diff.gz
 b69d49bbc1664fe856f349db91d18f5d9acb4dc4 84110 
libatomic-ops-dev_7.2~alpha5+cvs20101124-1+deb7u0_amd64.deb
Checksums-Sha256: 
 fa5f630833864627a1f37820a26c6bee669fcee60f70b58d071288104e732954 1925 
libatomic-ops_7.2~alpha5+cvs20101124-1+deb7u0.dsc
 2473ef4fbee623deae016829d36ff5bbb073bed9f3ce395c88bce92b67a0f4fc 10625 
libatomic-ops_7.2~alpha5+cvs20101124-1+deb7u0.diff.gz
 11c5c3cd42145fbe4ecf9a08e513b7d9441be751d34e5886fcd4c68740eace0c 84110 
libatomic-ops-dev_7.2~alpha5+cvs20101124-1+deb7u0_amd64.deb
Files: 
 17f783457673660263d9c6fc4de5cf41 1925 libdevel optional 
libatomic-ops_7.2~alpha5+cvs20101124-1+deb7u0.dsc
 6f1898290e4870739cfc21fb8b9783f8 10625 libdevel optional 
libatomic-ops_7.2~alpha5+cvs20101124-1+deb7u0.diff.gz
 36ae5390a897c3a25dbe681378e20029 84110 libdevel optional 
libatomic-ops-dev_7.2~alpha5+cvs20101124-1+deb7u0_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQbFwMAAoJELs6aAGGSaoGVMwQAIZJfHmntaS5JRL+cBJE7cvB
hH7YnlGKo24Xk1K75F3l6xcAZHOod/MWJ878rfySngMmf/3wZ3wS6XIz4me9UsEV
10l89lM2i+lMYNl/o3bgfYU3CVzsth+iOt/k32+AuyVqVzyPTKceidAdr/ZYkEe+
yNik27S9A/BxEQivMIDvv1BKWzilWlbCDuusRe/Yc5+fRUEheYBZitajiBB325DA
0Dh1Ftg5q3eEgw9vn3la8lXO5e/OHQaZZvjuqnzlSgULtWStUZUzYscV0jzSFxTG
1Syx5cwDTa9ZzCrQMLak4UiVxJAgK+1EGp5GqHsHZ60+jo7o6vmh34Zl6oIRM6sG
6pIN0v0TzPj9SzQlxD0X8pP1xEwFAk5yOi8Ehc1QWjXp16l8P5oMrUD0/Gtyevg7
HsfzavgefKFGejtAX2vMvXvm98InRuACRI9gpw95O/fwTApf1ksF1KourG4Cxnvq
K9050ZV4uBkfUjywTqw6VZWIWdC67KqGZYbDIkcz+uZ82VM+B0wkVhb4qk4Z2/nQ
jmx9Ayh9fp5GfYOjbJEmutvuOiJpfj9wEVx31Sj+Z39MYsf/O0TEO+Zx8ZhlMPjB
4NVF/1R2BamoCIPutbpAOHVngCKAHwGyITIyF8vhvK6LDAhFlwIFYG0a1QRT5/YO
nT4/1d5owBovceI5z3lY
=V8ow
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to