-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 10/12/2012 02:36 AM, Sébastien Villemot wrote: > Control: tags -1 + pending > > Dear Maintainers, > > Andreas Beckmann <deb...@abeckmann.de> writes: > >> Package: timidity-daemon Version: 2.13.2-40 Severity: serious >> User: debian...@lists.debian.org Usertags: piuparts >> >> during a test with piuparts I noticed your package mishandles >> conffiles. This is violates the policy, see >> http://www.debian.org/doc/debian-policy/ch-files.html#s-config-files >> >> >> >> I miserably failed to understand that the maintainer scripts were to do, >> the only thing I can say for sure is that the conffile >> /etc/init.d/timidity is removed during the remove step of the >> package (which is wrong, because configuration must be preserved >> after remove, and needs to be clened up during purge only. >> >> And that will fail in the following scenario: >> >> install timidity-daemon remove (don't purge!) timidity-daemon >> install timidity-daemon >> >> Now /etc/init.d/timidity is missing (as dpkg will not restore >> deleted configuration files as that is usually a user choice the >> should be preserved). > > I have uploaded to DELAYED/2 a NMU of timidity versioned > 2.13.2-40.1 which fixes that bug. The debdiff is attached. Don't > hesitate to tell me if I should delay the upload longer.
Thank you for uploading a NMU. > Guo: Thanks for your contribution. I did not directly upload your > patch for two reasons. First it was buggy since it was removing > the call to "invoke-rc.d timidity stop" in "prerm remove", and > this call has to stay there. OK, it indeed needs this. However, I found that dh_installinit already provided this by default in prerm: # Automatically added by dh_installinit if [ -x "/etc/init.d/timidity" ] && [ "$1" = remove ]; then invoke-rc.d timidity stop || exit $? fi # End automatically added section > Second it was making unnecessary changes related to > /etc/timidity/timidity.daemon, which is no longer shipped in the > package (it seems to predate squeeze); NMUs have to change the > minimal amount of code in order to fix the bug. But indeed, as > Andreas has noted, a lot of obsolete stuff could probably be > removed from the maintainer scripts. I see that NMU prefer to be minimal. Maybe my patch will still be useful in case of a maintainer upload. Cheers, Guo Yixuan -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCgAGBQJQd3upAAoJEN1xpgAgL7gzZ0sP/A6qJlvwDZuiT6VSiTuZIqZO m1eqRh3ZE1ZKP3oXElzHZqbr78YQ0inPVRl/rc5he2ev4bzXhD2oIwHTvF6JvGO2 H4rJCQ/UJBHdOSQbSD87Crm8zAdTxc+E7cM38/Ry7fj4EP1VZum9lnMOsR9adEL4 JG05mwEUQ/+F//ZKAVez+USQBvCskdAMXvobJvTJ63fnbcqvKUttni5SQcLgyqSE uXxmvwB8GPdflTwBNQGgO3Qak9zW6EClVeRf72JybOU38IEV0prMHGv/7L3WmwQQ UMbAu5YzUYdnbKBP7Cwe6j9J3xf7CYbdtxlk7+eNGICym5q4gtv2JAV3eQTtVDuo 4gsZzGT71Zn4qn46LsSlgTQHL3yux9kOVOnU3jka9kkRg8D4CNdvWC/Qt4x8YADD 3oFV0KGOaIQhYd5KbxIT4T7SAAh62S88/7wdcGLQJyVpJOjMCThhgXdaiiiUNYJ8 BLM5XjqSxDVpf0NUYz7QxDIwhnhiTQas8DFbKYxCHPSVA8vJ6e8s+6tlYZLBkXcN lhIoUnUhHEWM4V4PcEhQl5OC+5FbiL8huNMlz6sM2VBzhgn5NfvpNrqNrtNszBta S5UxPDpj77a2DlGuiUCM2MxoXHVYxKu0855WBYcOPsPfjixYmUnrmfKzeNxhz7CP MDjc7xZHS2e30rnOrlcD =p9pU -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org