Your message dated Thu, 25 Oct 2012 18:17:27 +0000
with message-id <[email protected]>
and subject line Bug#689883: fixed in checkservice 1.1.0-12
has caused the Debian Bug report #689883,
regarding Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
689883: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689883
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: checkservice
Version: 1.1.0-11
Severity: serious
Tags: patch
Dear Maintainer,
Andreas Beckmann <[email protected]> reported in -devel that your package
(as well as 27 others) ships a folder either in /var/run or /var/lock. This
is forbidden by policy.
Lintian detects the problem and warns as follow:
/var/run may be a temporary filesystem, so any directories or files needed
/there must be created dynamically at boot time.
Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for
details.
Severity: serious, Certainty: possible
Check: files, Type: binary, udeb
which is why I am reporting this bug with severity serious (and there fore,
release critical).
Please fix your package. I have attached what I believe is a good fix the
problem, however, I haven't tried it, and I haven't tested if something more
for creating the necessary folder at runtime should be added. Please make
sure to test before applying the patch blindly.
Cheers,
Thomas Goirand (zigo)
diff -u checkservice-1.1.0/debian/changelog checkservice-1.1.0/debian/changelog
--- checkservice-1.1.0/debian/changelog
+++ checkservice-1.1.0/debian/changelog
@@ -1,3 +1,10 @@
+checkservice (1.1.0-11.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Fixes wrong handling of var/lock/checkservice life cycle (Closes: #XXXXXX).
+
+ -- Thomas Goirand <[email protected]> Sun, 07 Oct 2012 10:31:51 +0000
+
checkservice (1.1.0-11) unstable; urgency=low
* Set pluginpath to /usr/share/checkservice too ;)
diff -u checkservice-1.1.0/debian/dirs checkservice-1.1.0/debian/dirs
--- checkservice-1.1.0/debian/dirs
+++ checkservice-1.1.0/debian/dirs
@@ -8,3 +8,2 @@
var/cache/checkservice
-var/lock/checkservice
var/log/checkservice
diff -u checkservice-1.1.0/debian/checkservice.cron.d checkservice-1.1.0/debian/checkservice.cron.d
--- checkservice-1.1.0/debian/checkservice.cron.d
+++ checkservice-1.1.0/debian/checkservice.cron.d
@@ -6 +6 @@
-*/10 * * * * root [ -x /usr/sbin/checkservice -a -f /etc/checkservice/checkservice.conf ] && /usr/sbin/checkservice -l /var/log/checkservice > /dev/null
+*/10 * * * * root [ -x /usr/sbin/checkservice -a -f /etc/checkservice/checkservice.conf ] && mkdir -p /var/lock/checkservice && /usr/sbin/checkservice -l /var/log/checkservice > /dev/null
--- checkservice-1.1.0.orig/debian/postrm
+++ checkservice-1.1.0/debian/postrm
@@ -0,0 +1,9 @@
+#!/bin/sh
+
+set -e
+
+if [ "${1}" = "purge" ] ; then
+ rm -rf /var/lock/checkservice
+fi
+
+#DEBHELPER#
--- End Message ---
--- Begin Message ---
Source: checkservice
Source-Version: 1.1.0-12
We believe that the bug you reported is fixed in the latest version of
checkservice, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Paul van Tilburg <[email protected]> (supplier of updated checkservice package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 25 Oct 2012 20:00:10 +0200
Source: checkservice
Binary: checkservice
Architecture: source all
Version: 1.1.0-12
Distribution: unstable
Urgency: low
Maintainer: Paul van Tilburg <[email protected]>
Changed-By: Paul van Tilburg <[email protected]>
Description:
checkservice - Checks the status of services on (remote) hosts
Closes: 689883
Changes:
checkservice (1.1.0-12) unstable; urgency=low
.
* Fixes wrong handling of var/lock/checkservice life cycle,
fix courtesy of Thomas Goirand <[email protected]> (Closes: #689883)
* debian/dirs: no longer create /var/lock/checkservice
* debian/checkservice.cron.d: create lock dir before run (if needed)
* debian/postrm: remove lock dir, if exists
Checksums-Sha1:
1c407302487775917e33665a1218c05b5b2f39be 1038 checkservice_1.1.0-12.dsc
20e6ef7c4e23d597e9965f823ab00e29769499c0 14931 checkservice_1.1.0-12.diff.gz
5519409cfd927de609906c9348cd6ff203dcb1e2 27296 checkservice_1.1.0-12_all.deb
Checksums-Sha256:
0e057227d9cb21e3e794e6f63761faef952a28685430c17c41bd19214146f02f 1038
checkservice_1.1.0-12.dsc
bcd96006d39ed5e8cfb59050ceef8174fcbdbd66f80a4f7ce128f8b80232f167 14931
checkservice_1.1.0-12.diff.gz
eeb849225c97f03b245f37566d8482ba08d66f60fb500303b08353bcf9bf9648 27296
checkservice_1.1.0-12_all.deb
Files:
3c38a1e54e2b2b0719e679e8afad2dd5 1038 admin optional checkservice_1.1.0-12.dsc
4ab5ea13ac8197a8f7e9b29ce34fc9c6 14931 admin optional
checkservice_1.1.0-12.diff.gz
e14548410b154e7e7d0d5ed0446fa686 27296 admin optional
checkservice_1.1.0-12_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iEYEARECAAYFAlCJflYACgkQJBBhylAGQYG5oACdGcvoSDKoFWoZOv5p5PhZTVdz
PMQAn2C0vB4vebmzspt3EdYsFKWC3vId
=Udna
-----END PGP SIGNATURE-----
--- End Message ---
