Hi,

(I managed to find some time to review this patch, finally.)

gregor herrmann wrote (27 Oct 2012 15:51:05 GMT) :
> Which means we need to create the symlink for new installs and for
> upgrades from this range. Correct so far?

I think so.

> Here's an attempt to implement this idea:
[...]
> -       if [ -z "$prevver" ] ; then
> +       if [ -z "$prevver" ] || \
> +           dpkg --compare-versions $prevver ge 1.4.6-1~ && \\
> +           dpkg --compare-versions $prevver lt 1.4.7~ ; then
>             # only create link on new installs
> +           # or when upgrading from a version where it was removed 
> unconditionally
>                     ln -s ../../munin/apache.conf /etc/$webserver/conf.d/munin
>         fi
>         if [ -f $webserver_init_script ];then
[...]
> Please double-check if I got the logic right :)

Looks good to me.

Holger Levsen wrote (26 Oct 2012 23:56:23 GMT) :
> I fear I might "just" be busy with DebConf13...

Thank you for taking care of this.

> I certainly loved a clear patch ;) 

Then you should be happy with gregoa's one,
and Wheezy will have one less RC bug! :)

Cheers!
--
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to