On Sat, 23 Feb 2013 19:05:46 +0000, Steven Chamberlain wrote: > On 23/02/13 18:24, gregor herrmann wrote: > > Another approach, if the timeout should be kept, would be to fix the > > calculation of the times by calculating with seconds. > > Yes, I mentioned that as a possibility, but I thought it was still less > than ideal, in case of a clock adjustment for example. (Although it is > unlikely). > > For something as simple as this - "try connecting a few times then give > up" - I thought a fixed number of iterations with sleeps is safest.
Yup, make sense of course; I just thought about alternatives that change the original semantics less. > Really I wish this code hadn't been duplicated in like 34 places... Indeed! Let's see what the maintainer thinks; if we don't hear from him, an NMU with your patch would be ok IMO. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Lenny Kravitz: Thinking Of You
signature.asc
Description: Digital signature
