Paul Gevers wrote:
I just uploaded with the patch for bug 704252. I didn't feel the other
two items appropriate at this moment.
It took me some more time than expected, because I had to fix two bugs
in your script:
So you are saying that rather rather than sponsoring abou's upload you
made your own upload and put abou's name on it? If so please don't
impersonate maintainers like that.
1) You used dpkg-architecture -qDEB_BUILD_ARCH instead of
dpkg-architecture -qDEB_BUILD_GNU_CPU (you could simplify your rules
file as well with this).
I just got an email from a buildd saying the i386 build had failed and I
took a look at this debdiff. The more I read of it the worse it seemed
to get.
Firstly neither debian or gnu CPU names match the cpu names freepascal
uses. So whatever you do some special casing is going to be needed in
the determation of the fpc target name .
Secondly the free pascal target name was previously passed from
debian/rules to debian/fixdeb so it only had to be worked out in one
place. Why is that not the case anymore?
Thirdly why has the calling syntax for debian/fixdeb been changed?
Fourthly shouldn't this be using DEB_HOST_* not DEB_BUILD_* (yeah I know
cross-building the fpc package is probablly broken anyway but lets not
make it any more broken)
Fifthly your debian/control rule seems like it can't possiblly work
since it specifies *.in when afaict (under your new calling syntax) it
should be debian/*.in
Finally is it really nessacery to use obscure make syntax to run the
script?
In summary if I was a release team member there is no way i'd be
unblocking this.
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
