Your message dated Fri, 01 Nov 2013 23:18:18 +0000
with message-id <e1vcnys-0006jp...@franck.debian.org>
and subject line Bug#726653: fixed in dh-make 0.63
has caused the Debian Bug report #726653,
regarding /usr/bin/dh_make: detection of cwd is not portable, violates policy
9.9
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
726653: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726653
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: dh-make
Version: 0.62
Severity: serious
File: /usr/bin/dh_make
Tags: patch
Justification: Policy 9.9
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
The dh_make script depends on the environment variable PWD to determine
the current working directory and thus the package name and version.
This is not portable, ebcause some shells (most shells?) do not export
PWD by default. It works in bash, but not in mksh, for example. This
violates Debian Policy 9.9:
"A program must not depend on environment variables to get reasonable
defaults. (That's because these environment variables would have to be
set in a system-wide configuration file like /etc/profile, which is not
supported by all shells.)"
Funnily enough, dh_make even imports the Perl module Cwd which is used
to safely determine the working directory, but never uses it. Attached
is a trivial patch that fixes this.
Cheers,
Nik
- -- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.10-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/mksh
Versions of packages dh-make depends on:
ii debhelper 9.20130921
ii dpkg-dev 1.17.1
ii make 3.81-8.2
ii perl 5.18.1-4
dh-make recommends no packages.
Versions of packages dh-make suggests:
ii build-essential 11.6
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
iQJOBAEBCAA4BQJSYDXHMRpodHRwczovL3d3dy5kb21pbmlrLWdlb3JnZS5kZS9n
cGctcG9saWN5LnR4dC5hc2MACgkQt5o8FqDE8pbHng//Yrsu6i4k8sSxufhYrqTu
2i5u1zyaimwFTrTZRe5M3lJ/o+7acbf6Mu/QjaW1/EOg3RfrTcV7BnW75/WUdMQf
5B4bKsM8xaXuxRvtimKPEvcJHLLvOovW2qMVUtGtIxdXjmK9E/5tmH5asUV8diea
mCep+AXTlftc0mR/xBWEYfU1jolZD5cZi62RqqwHgst69p1ZuMayuTEjmb74EVYS
0aeCaFqERqOedTRvh/PwNXb60XwgXa9lMz9PCGiIvKQPx5CjfQ3FV6wxTMnL3SNI
fq58VuZKq3HY9yhfsR6XxSZzu95MVpnWnE/3gnP6DXwBQ0wSbcKEKpjFcFn4rGA4
Dil9BRHZBZWoJvT4om61AqmzPCRV5asR6lVpfi9pbHUEvWzShMtvj63uMBX1uHdm
bB+MxkhO+exWilJFXPRBagBNmKrhN3sekHJa8akwjF93cxNwyISGogTL5huBHFhG
BlovHubW3kgriwzAiZdd9QPT3qm99Ltnd29jfFMZvaZHSFKCwoahnl+xWPjHrjQ9
baYhRefEOt5lbtjmhDpDraDBKBqHNYxXuq3N891uymUC1wu0AOnPU6gMdj+sg1a6
oY4a/PDdD3IE1ygxoeNpxUkq+Aafce5+2M+sVBaKGn8WrqSJHlDwGpdcG2PMBLmo
Cft5aRlyzGNZb8QDJ0R87Us=
=alTH
-----END PGP SIGNATURE-----
--- dh_make 2013-10-17 20:58:36.722757271 +0200
+++ dh_make 2013-10-17 20:59:45.511474516 +0200
@@ -356,7 +356,7 @@ sub get_email()
sub get_package
{
- my $pwd = $ENV{PWD};
+ my $pwd = &Cwd::cwd();
my $forced_package_version = "";
# May split the version out of the name
if ( ($main::forced_package_name) &&
--- End Message ---
--- Begin Message ---
Source: dh-make
Source-Version: 0.63
We believe that the bug you reported is fixed in the latest version of
dh-make, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 726...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Craig Small <csm...@debian.org> (supplier of updated dh-make package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 02 Nov 2013 10:10:22 +1100
Source: dh-make
Binary: dh-make
Architecture: source all
Version: 0.63
Distribution: unstable
Urgency: low
Maintainer: Craig Small <csm...@debian.org>
Changed-By: Craig Small <csm...@debian.org>
Description:
dh-make - tool that converts source archives into Debian package source
Closes: 703910 706164 709479 721738 721849 726653
Changes:
dh-make (0.63) unstable; urgency=low
.
* Changed default priority to optional Closes: #706164
* README.source has timestamp Closes: #703910
* Removed boilerplate notice from rules Closes: #721849
* Update to debhelper compat 9 Closes: #721738
* Portable CWD, thanks Dominik George for patch Closes: #726653
* Merged init skeleton, thanks to Mathieu Parent Closes: #709479
* Added more lintian ignores
Checksums-Sha1:
15a3f47f1eafe1052b3f33394209103760b4bd90 1507 dh-make_0.63.dsc
98f108a045b330af354fa0b69366e5e91e93a61f 42634 dh-make_0.63.tar.gz
055c2513e526369dc0fdd3ef20413fe10427c150 41284 dh-make_0.63_all.deb
Checksums-Sha256:
37bfc6b59bea43a7a415d8aab48294d645cc37211f0d8efeb3054a4700b42082 1507
dh-make_0.63.dsc
20a4c0f412c4c7667d2d08e1b7f36e25e1642b6da18d0d187c11354a869b2095 42634
dh-make_0.63.tar.gz
7bb610b258440ed5ac724c2a2cb6491e49d1ac8ae32c5bad6a500b8b26ded4fa 41284
dh-make_0.63_all.deb
Files:
e8426b65fa6dedd6773aad9ccf2eb9fb 1507 devel optional dh-make_0.63.dsc
aa0e6502d682d3c6d97b81ce2d414c87 42634 devel optional dh-make_0.63.tar.gz
1cd16431b919172f7c5a38312fbba611 41284 devel optional dh-make_0.63_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
iQIcBAEBCgAGBQJSdDV7AAoJEDk4+WvfUP6lwlIP/i9ti3cwjlI8Lar6xpbr1PnB
Xj+J+DoL5h5GombQrUQO5XdZlO7e8oyBOA8cPemw4wHFho/FK3h2Pi9BO7Fv7fxG
UzpMwrcGMx+GvADx6pPOeUzFF1FjgNpVE1iRGlZQ4lm3aQnWs4xgQ7jS2nNykui7
ftn2WR426ijKPH6exepziJq3+76pg6Ajn8P4jQbrPZ+qJ21wQjOcV/VCdqb+3xLv
QgXWqrBv2KJ7A0snnbQet+vE/0g74hZcB/TcJrZMy4Y9gD47iyU4Qe1kzSHMYt4W
/pUOhoPFeSBFwLqRXx7OacW0sRErz4raJt22En6uWjupMkcYGUqoryoqVRnU0fhA
DvwTtdkuvevUjHKW7ddIWZSnKmg0NpnKX0xTtj4BcdI9x50zWuO5cWiFsQbvFA7M
93P/5JNQwbZ1rd7MuD4siKD0DJVvGsDJWTj9wn6nizF/e3g/yA3SlPWiAxepKvdM
Xys8vkY4j6mvdEPc8s+2udxjRwlBoC8AYIoXav0F2yujDMi+AlFUF5jV4AYikDrW
tB6yjW3k0coKf3OU0WR45KaUXS1pBxLjf62zmvkQcaItmMa7W43ZXD2U90vvJQp0
QbibytRSBuIcQSqMubWMLFzIKXTkbNYMdHYz/cTdUIoI5N0VJlVVlsAC5am9qmRa
JHueUmhX8q2WK90UEuXr
=GJzb
-----END PGP SIGNATURE-----
--- End Message ---
