Bug#753699: lynx: Alert!: This client does not contain support for HTTPS URLs.

[Andreas Metzler]

On 2014-07-04 Thorsten Glaser <t...@mirbsd.de> wrote:
> Package: lynx-cur
> Version: 2.8.9dev1-1
> Severity: grave
> Justification: renders package unusable

> Just updated:

> Unpacking lynx-cur (2.8.9dev1-1) over (2.8.8pre5-1) ...

> After updating:

> Alert!: This client does not contain support for HTTPS URLs.

> lynx: Can't access startfile 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=601683
[...]

Hello,

Looks like lynx-cur is missing a build-dependency on
libgcrypt20-dev as a hotfix or better use gnutls_rnd() instead of
gcry_randomize() and stop linking against gcrypt. (Totally untested,
no guarantees patch attached.)

cu Andreas


-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

--- lynx-cur-2.8.9dev1.orig/configure
+++ lynx-cur-2.8.9dev1/configure
@@ -15012,7 +15012,7 @@
   echo "$as_me: failed program was:" >&5
 cat conftest.$ac_ext >&5
 
-LIBS="-lgnutls -lgnutls -lgcrypt $cf_save_LIBS"
+LIBS="-lgnutls $cf_save_LIBS"
 
 cat >conftest.$ac_ext <<_ACEOF
 #line 15018 "configure"
@@ -15350,7 +15350,7 @@
 echo "${as_me:-configure}:15350: testing ... testing $cf_cv_library_path_gnutls ..." 1>&5
 
             CPPFLAGS="$cf_test_CPPFLAGS"
-            LIBS="-lgnutls -lgnutls -lgcrypt $cf_save_LIBS"
+            LIBS="-lgnutls $cf_save_LIBS"
             LDFLAGS="$cf_save_LDFLAGS -L$cf_cv_library_path_gnutls"
             cat >conftest.$ac_ext <<_ACEOF
 #line 15356 "configure"
@@ -15559,7 +15559,7 @@
 fi
 
 		fi
-		LIBS="-lgnutls -lgcrypt $LIBS"
+		LIBS="-lgnutls $LIBS"
 
 		EXTRA_OBJS="$EXTRA_OBJS tidy_tls\$o"
 
@@ -16687,7 +16687,7 @@
 fi
 
 		fi
-		LIBS="-lgnutls -lgcrypt $LIBS"
+		LIBS="-lgnutls $LIBS"
 
 		if test "$cf_pkg_gnutls" = none ; then
 				echo "$as_me:16693: checking for SSL_connect in -lgnutls-openssl" >&5
only in patch2:
unchanged:
--- lynx-cur-2.8.9dev1.orig/src/tidy_tls.c
+++ lynx-cur-2.8.9dev1/src/tidy_tls.c
@@ -11,7 +11,7 @@
 #include <tidy_tls.h>
 
 #include <gnutls/x509.h>
-#include <gcrypt.h>
+#include <gnutls/crypto.h>
 #include <libtasn1.h>		/* ASN1_SUCCESS,etc */
 #include <string.h>
 
@@ -95,7 +95,7 @@
  */
 int RAND_bytes(unsigned char *buffer, int num)
 {
-    gcry_randomize(buffer, num, GCRY_VERY_STRONG_RANDOM);
+    gnutls_rnd(GNUTLS_RND_KEY, buffer, num);
     return 1;
 }