Your message dated Sat, 05 Jul 2014 11:28:15 +0530
with message-id <53b793f7.20...@researchut.com>
and subject line Re: Bug#753427: libnfs-dev: makes xbmc FTBFS
has caused the Debian Bug report #753427,
regarding libnfs-dev: makes xbmc FTBFS
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
753427: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=753427
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libnfs-dev
Version: 1.9.4-1
Severity: grave
Hi,
The latest update to libnfs made xbmc (and probably everything else)
fail to build against the library.
Relevant log from xbmc build using sbuild:
...
CPP xbmc/filesystem/SMBDirectory.o
CPP xbmc/filesystem/NFSFile.o
In file included from NFSFile.cpp:35:0:
/usr/include/nfsc/libnfs-raw-mount.h:150:38: error: 'CLIENT' has not
been declared
extern void * mount1_null_1(void *, CLIENT *);
^
/usr/include/nfsc/libnfs-raw-mount.h:153:45: error: 'CLIENT' has not
been declared
extern mountres1 * mount1_mnt_1(dirpath *, CLIENT *);
^
/usr/include/nfsc/libnfs-raw-mount.h:156:43: error: 'CLIENT' has not
been declared
extern mountlist * mount1_dump_1(void *, CLIENT *);
^
/usr/include/nfsc/libnfs-raw-mount.h:159:41: error: 'CLIENT' has not
been declared
extern void * mount1_umnt_1(dirpath *, CLIENT *);
Cheers,
Balint
--- End Message ---
--- Begin Message ---
On 07/02/2014 10:34 AM, Ritesh Raj Sarraf wrote:
> On 07/02/2014 01:10 AM, Bálint Réczey wrote:
>> The latest update to libnfs made xbmc (and probably everything else)
>> fail to build against the library.
>> Relevant log from xbmc build using sbuild:
>> ...
>> CPP xbmc/filesystem/SMBDirectory.o
>> CPP xbmc/filesystem/NFSFile.o
>> In file included from NFSFile.cpp:35:0:
>> /usr/include/nfsc/libnfs-raw-mount.h:150:38: error: 'CLIENT' has not
>> been declared
>> extern void * mount1_null_1(void *, CLIENT *);
>> ^
>> /usr/include/nfsc/libnfs-raw-mount.h:153:45: error: 'CLIENT' has not
>> been declared
>> extern mountres1 * mount1_mnt_1(dirpath *, CLIENT *);
>> ^
>> /usr/include/nfsc/libnfs-raw-mount.h:156:43: error: 'CLIENT' has not
>> been declared
>> extern mountlist * mount1_dump_1(void *, CLIENT *);
>> ^
>> /usr/include/nfsc/libnfs-raw-mount.h:159:41: error: 'CLIENT' has not
>> been declared
>> extern void * mount1_umnt_1(dirpath *, CLIENT *);
>
> That's interesting given that xbmc has built using the 1.9.3 version
> of the library, which was release this year. The last relevant change
> to libnfs was done in December 2013. I'll look into it.
>
Balint,
The fix is in XBMC. Please see attached patch. I've also attached a
patch for parallel builds.
FTBFS fix further details at:
https://github.com/sahlberg/libnfs/commit/a0c4ea7d9f4ad7fab543c064c47be7d334a9ceda#commitcomment-6835590
--
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."
From 909999f0a9d522e48a6e19efa0f546d10d7996ff Mon Sep 17 00:00:00 2001
From: Ritesh Raj Sarraf <r...@debian.org>
Date: Sat, 5 Jul 2014 10:44:31 +0530
Subject: [PATCH] Enable Parallel Build
Signed-off-by: Ritesh Raj Sarraf <r...@debian.org>
---
debian/control | 1 +
debian/rules | 11 +++++++++++
2 files changed, 12 insertions(+)
diff --git a/debian/control b/debian/control
index 833d4b6..2925070 100644
--- a/debian/control
+++ b/debian/control
@@ -14,6 +14,7 @@ Build-Depends: debhelper (>= 9~),
unzip,
libboost-dev,
zip,
+ libc-bin,
libtool,
libgles2-mesa-dev [armel armhf] | libgl1-mesa-dev | libgl-dev,
libglu1-mesa-dev | libglu-dev,
diff --git a/debian/rules b/debian/rules
index ca0feb3..64f59e1 100755
--- a/debian/rules
+++ b/debian/rules
@@ -15,6 +15,17 @@ ifneq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
XBMC_RELEASE ?= no
endif
+# Enable parallel build
+DEB_BUILD_OPTIONS ?= $(shell getconf _NPROCESSORS_ONLN)
+
+ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
+ NUMJOBS = $(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
+else
+ DEB_PARALLEL_JOBS += $(shell getconf _NPROCESSORS_ONLN)
+endif
+MAKEFLAGS += -j$(NUMJOBS)
+
+
# Whether we're building for release or not
ifeq (yes,$(XBMC_RELEASE))
DEBUG_OPTIONS = --disable-debug --enable-optimizations
--
2.0.0
Fix NFS build on XBMC
Index: xbmc/xbmc/filesystem/NFSDirectory.cpp
===================================================================
--- xbmc.orig/xbmc/filesystem/NFSDirectory.cpp 2014-07-02 11:11:27.526739399 +0530
+++ xbmc/xbmc/filesystem/NFSDirectory.cpp 2014-07-05 10:14:13.049098803 +0530
@@ -37,6 +37,7 @@
using namespace XFILE;
using namespace std;
#include <limits.h>
+#include <nfsc/libnfs-zdr.h>
#include <nfsc/libnfs-raw-mount.h>
#include <nfsc/libnfs-raw-nfs.h>
Index: xbmc/xbmc/filesystem/NFSFile.cpp
===================================================================
--- xbmc.orig/xbmc/filesystem/NFSFile.cpp 2014-07-02 11:11:27.526739399 +0530
+++ xbmc/xbmc/filesystem/NFSFile.cpp 2014-07-05 10:14:52.080943689 +0530
@@ -32,6 +32,7 @@
#include "network/DNSNameCache.h"
#include "threads/SystemClock.h"
+#include <nfsc/libnfs-zdr.h>
#include <nfsc/libnfs-raw-mount.h>
#ifdef TARGET_WINDOWS
signature.asc
Description: OpenPGP digital signature
--- End Message ---
