On 07/19/2014 11:30 AM, David Suárez wrote: > Source: glassfish > Version: 1:2.1.1-b31g-3 > Severity: serious > Tags: jessie sid > User: debian...@lists.debian.org > Usertags: qa-ftbfs-20140718 qa-ftbfs > Justification: FTBFS on amd64 > > [snip] > >> compile: >> [javac] Compiling 86 source files to >> /«PKGBUILDDIR»/appserv-jstl/build/classes >> [javac] >> /«PKGBUILDDIR»/appserv-jstl/src/org/apache/taglibs/standard/tag/common/xml/JSTLXPathImpl.java:238: >> error: no suitable constructor found for >> JAXPExtensionsProvider(XPathFunctionResolver,boolean) >> [javac] new >> com.sun.org.apache.xpath.internal.jaxp.JAXPExtensionsProvider( >> [javac] ^ >> [javac] constructor >> JAXPExtensionsProvider.JAXPExtensionsProvider(XPathFunctionResolver,boolean,FeatureManager) >> is not applicable >> [javac] (actual and formal argument lists differ in length) >> [javac] constructor >> JAXPExtensionsProvider.JAXPExtensionsProvider(XPathFunctionResolver) is not >> applicable >> [javac] (actual and formal argument lists differ in length) >> [javac] Note: Some input files use unchecked or unsafe operations. >> [javac] Note: Recompile with -Xlint:unchecked for details. >> [javac] 1 error
Attached is a trivial patch to get glassfish compiling again. However, I'm a little concerned about potential runtime effects. I haven't yet been able to find a reference to when the JAXPExtensionsProvider constructor signature changed, although I suspect that it's related to security. (That is, secure processing is alway required to be True.) Does anyone on the Debian Java team have experience with this API change? (Also, if anyone is planning to upload imminently, please coordinate with me, as I have a few other minor packaging fixes that I'd like to push, along with converting the packaging repo over to git.) Regards, tony
commit 74e21415623e955025f48ce3e2666b846e4a3a79 Author: tony mancill <tmanc...@debian.org> Date: Sun Jul 20 14:33:47 2014 -0700 #755323 diff --git a/debian/patches/jaxp.patch b/debian/patches/jaxp.patch new file mode 100644 index 0000000..18026d9 --- /dev/null +++ b/debian/patches/jaxp.patch @@ -0,0 +1,12 @@ +--- a/appserv-jstl/src/org/apache/taglibs/standard/tag/common/xml/JSTLXPathImpl.java ++++ b/appserv-jstl/src/org/apache/taglibs/standard/tag/common/xml/JSTLXPathImpl.java +@@ -236,7 +236,8 @@ + if ( functionResolver != null ) { + com.sun.org.apache.xpath.internal.jaxp.JAXPExtensionsProvider jep = + new com.sun.org.apache.xpath.internal.jaxp.JAXPExtensionsProvider( +- functionResolver, featureSecureProcessing ); ++ functionResolver); ++ // remove feature SecureProcessing; see Debian bug #755323 + xpathSupport = new com.sun.org.apache.xpath.internal.XPathContext( jep ); + } else { + xpathSupport = new com.sun.org.apache.xpath.internal.XPathContext(); diff --git a/debian/patches/series b/debian/patches/series index ebd7005..3f5e77d 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -2,3 +2,4 @@ 0002-Fix-glassfish.root-directory.patch 0003-Disable-SQL-exceptions.patch java7-compat.patch +jaxp.patch
signature.asc
Description: OpenPGP digital signature