On 24.09.2014 10:20, Mike Gabriel wrote:

> In a private post you mentioned that current remmina-master is
> completely broken and the remmina-gtk3 branch still uses the old
> freerdp-1.0 cmake rules (this seems easy to fix, actually).

Yes, see here:
https://github.com/FreeRDP/Remmina/blob/gtk3/cmake/FindFREERDP.cmake

[...]
find_library(FREERDP_LIBRARY NAMES freerdp
        HINTS ${PC_FREERDP_LIBDIR} ${PC_FREERDP_LIBRARY_DIRS})

find_library(FREERDP_CLIENT_LIBRARY NAMES freerdp-client
        HINTS ${PC_FREERDP_LIBDIR} ${PC_FREERDP_LIBRARY_DIRS})
[...]

The master branch uses the correct rules:
https://github.com/FreeRDP/Remmina/blob/master/cmake/FindFREERDP.cmake

[...]
find_library(FREERDP_LIBRARY NAMES freerdp-core
        HINTS ${PC_FREERDP_LIBDIR} ${PC_FREERDP_LIBRARY_DIRS})

find_library(FREERDP_GDI_LIBRARY NAMES freerdp-gdi
        HINTS ${PC_FREERDP_LIBDIR} ${PC_FREERDP_LIBRARY_DIRS})

find_library(FREERDP_LOCALE_LIBRARY NAMES freerdp-locale
        HINTS ${PC_FREERDP_LIBDIR} ${PC_FREERDP_LIBRARY_DIRS})

find_library(FREERDP_RAIL_LIBRARY NAMES freerdp-rail
        HINTS ${PC_FREERDP_LIBDIR} ${PC_FREERDP_LIBRARY_DIRS})

find_library(FREERDP_CODEC_LIBRARY NAMES freerdp-codec
        HINTS ${PC_FREERDP_LIBDIR} ${PC_FREERDP_LIBRARY_DIRS})

find_library(FREERDP_CLIENT_LIBRARY NAMES freerdp-client
        HINTS ${PC_FREERDP_LIBDIR} ${PC_FREERDP_LIBRARY_DIRS})

[...]

I tried fixing this bus blindly copying the cmake file from the master
branch to the gtk3 branch and recompile. This then finds the libraries
fine but fails with some (to me unfixable) errors during compilatio later.

People knowing about remmina, freerdp and gtk3 should be able to figure
it out, I hope.

Grüße,
Sven.


Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to