Control: severity -1 important
Control: tags -1 +moreinfo

Andreas,

both opendnssec-enforcer-sqlite3 and opendnssec-enforcer-mysql uses
dpkg-maintscript-helper to replace the symlink with directory:

ondrej@lettie:~/Projects/pkg-nlnetlabs/opendnssec/debian (master)$ cat
opendnssec-enforcer-mysql.maintscript 
symlink_to_dir /usr/share/doc/opendnssec-enforcer-mysql/
/usr/share/doc/opendnssec-common/ 1:1.4.6-2~ -- "$@"
ondrej@lettie:~/Projects/pkg-nlnetlabs/opendnssec/debian (master)$ cat
opendnssec-enforcer-sqlite3.maintscript 
symlink_to_dir /usr/share/doc/opendnssec-enforcer-sqlite3/
/usr/share/doc/opendnssec-common/ 1:1.4.6-2~ -- "$@"

Is there anything else I can do? Or is there something else wrong? I am
not sure what to do better here.

Cheers,
Ondrej

On Thu, Nov 6, 2014, at 04:28, Andreas Beckmann wrote:
> Package: opendnssec-enforcer-sqlite3,opendnssec-enforcer-mysql
> Version: 1:1.4.6-2
> Severity: serious
> User: debian...@lists.debian.org
> Usertags: piuparts
> 
> Hi,
> 
> an upgrade test with piuparts revealed that your package installs files
> over existing symlinks and possibly overwrites files owned by other
> packages. This usually means an old version of the package shipped a
> symlink but that was later replaced by a real (and non-empty)
> directory. This kind of overwriting another package's files cannot be
> detected by dpkg.
> 
> This was observed on the following upgrade paths:
> 
>   wheezy -> jessie
> 
> For /usr/share/doc/PACKAGE this may not be problematic as long as both
> packages are installed, ship byte-for-byte identical files and are
> upgraded in lockstep. But once one of the involved packages gets
> removed, the other one will lose its documentation files, too,
> including the copyright file, which is a violation of Policy 12.5:
> http://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile
> 
> For other overwritten locations anything interesting may happen.
> 
> Note that dpkg intentionally does not replace directories with symlinks
> and vice versa, you need the maintainer scripts to do this.
> See in particular the end of point 4 in
> http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase
> 
> It is recommended to use the dpkg-maintscript-helper commands
> 'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.2)
> to perform the conversion, ideally using d/$PACKAGE.mainstscript.
> See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.
> 
> 
> >From the attached log (usually somewhere in the middle...):
> 
> 1m5.2s ERROR: FAIL: silently overwrites files via directory symlinks:
>   /usr/share/doc/opendnssec-enforcer-sqlite3/NEWS.Debian.gz
>   (opendnssec-enforcer-sqlite3) !=
>   /usr/share/doc/opendnssec-enforcer/NEWS.Debian.gz (opendnssec-enforcer)
>   /usr/share/doc/opendnssec-enforcer-sqlite3/changelog.Debian.gz
>   (opendnssec-enforcer-sqlite3) !=
>   /usr/share/doc/opendnssec-enforcer/changelog.Debian.gz
>   (opendnssec-enforcer)
>   /usr/share/doc/opendnssec-enforcer-sqlite3/changelog.gz
>   (opendnssec-enforcer-sqlite3) !=
>   /usr/share/doc/opendnssec-enforcer/changelog.gz (opendnssec-enforcer)
>   /usr/share/doc/opendnssec-enforcer-sqlite3/copyright
>   (opendnssec-enforcer-sqlite3) !=
>   /usr/share/doc/opendnssec-enforcer/copyright (opendnssec-enforcer)
> 
> 1m9.5s ERROR: FAIL: silently overwrites files via directory symlinks:
>   /usr/share/doc/opendnssec-enforcer-mysql/NEWS.Debian.gz
>   (opendnssec-enforcer-mysql) !=
>   /usr/share/doc/opendnssec-enforcer/NEWS.Debian.gz (opendnssec-enforcer)
>   /usr/share/doc/opendnssec-enforcer-mysql/changelog.Debian.gz
>   (opendnssec-enforcer-mysql) !=
>   /usr/share/doc/opendnssec-enforcer/changelog.Debian.gz
>   (opendnssec-enforcer)
>   /usr/share/doc/opendnssec-enforcer-mysql/changelog.gz
>   (opendnssec-enforcer-mysql) !=
>   /usr/share/doc/opendnssec-enforcer/changelog.gz (opendnssec-enforcer)
>   /usr/share/doc/opendnssec-enforcer-mysql/copyright
>   (opendnssec-enforcer-mysql) !=
>   /usr/share/doc/opendnssec-enforcer/copyright (opendnssec-enforcer)
> 
> 
> cheers,
> 
> Andreas
> Email had 1 attachment:
> + opendnssec-enforcer-sqlite3_1:1.4.6-2.log.gz
>   30k (application/gzip)


-- 
Ondřej Surý <ond...@sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to