Control: merge 768076 772778
Control: severity 768076 grave
Control: tags 768076 + patch

Hello,

I can confirm the issue: abcde just can't work ATM because when using
eyeD3, it passes --encoding and --text-frame, instead of what the
current debian version of eyeD3 expects: --set-encoding and
--set-text-frame.

Also, I don't see abcde being able to use id3v2 any more for ID3
tags.  This gravely reduces the usefulness of the package.

The attached patch fixed the behavior for me, with eyed3 < 0.7. Of
course, when eyed3 >= 0.7 gets uploaded to Debian, this will have to be
reverted, thus putting a versioned suggestion.

Samuel
--- a/abcde
+++ b/abcde
@@ -835,8 +835,8 @@ do_tag ()
                                                -a "$TRACKARTIST" -t 
"$TRACKNAME" ${CDYEAR:+-Y "$CDYEAR"} \
                                                -G "$GENREID" -n 
"${TRACKNUM:-$1}" \
                                                ${TRACKNUM:+-N "$TRACKS"} \
-                                               
${ENCODING:+--encoding="$ENCODING"} \
-                                               
${TPE2:+--text-frame=TPE2:"$TPE2"} \
+                                               
${ENCODING:+--set-encoding="$ENCODING"} \
+                                               
${TPE2:+--set-text-frame=TPE2:"$TPE2"} \
                                                "$ABCDETEMPDIR/track$1.$OUTPUT"
                                        ;;
                                # FIXME # Still not activated...
@@ -3324,7 +3324,7 @@ ID3OPTS=
 # FIXME # Older versions of eyeD3 (< 0.7.0) expect --set-encoding=utf16-LE
 # so perhaps some version sniffing would be useful. Or perhaps it might be
 # better to simply cut ties with the older eyeD3... Andrew.
-EYED3OPTS="--encoding utf16"
+EYED3OPTS="--set-encoding utf16"
 CDPARANOIAOPTS=
 CDDA2WAVOPTS=
 DAGRABOPTS=
--- debian/control.original     2014-12-30 19:49:39.514180740 +0100
+++ debian/control      2014-12-30 19:49:58.117642148 +0100
@@ -12,7 +12,7 @@
 Architecture: all
 Depends: ${misc:Depends}, cd-discid, wget, cdparanoia | icedax, vorbis-tools 
(>= 1.0beta4-1) | lame | flac | bladeenc | speex | musepack-tools | opus-tools
 Recommends: vorbis-tools, libmusicbrainz-discid-perl, 
libwebservice-musicbrainz-perl, libdigest-sha-perl, bsd-mailx
-Suggests: eject, distmp3, id3 (>= 0.12), id3v2, eyed3, normalize-audio, 
vorbisgain, mkcue, mp3gain, atomicparsley
+Suggests: eject, distmp3, id3 (>= 0.12), id3v2, eyed3 (<< 0.7~), 
normalize-audio, vorbisgain, mkcue, mp3gain, atomicparsley
 Description: A Better CD Encoder
  frontend program to cdparanoia, wget, cd-discid, id3, and your favorite
  Ogg/Vorbis, MP3, FLAC, Ogg/Speex and/or MPP/MP+(Musepack) encoder (defaults 

Reply via email to