Your message dated Mon, 29 Jun 2015 13:04:21 +0000
with message-id <e1z9yjv-00053q...@franck.debian.org>
and subject line Bug#789026: fixed in gnubiff 2.2.15-4.1
has caused the Debian Bug report #789026,
regarding gnubiff: Patch to port to libpanel-applet 3.14+
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
789026: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=789026
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: gnubiff
Version: 2.2.15-4
Tags: patch

Dear maintainer,

I am attaching the patch that ports gnubiff to the new libpanel-applet
API, so that it is compatible with gnome-panel 3.14 and newer releases.

New gnome-panel is so far only available in experimental, but we are
going to upload it to unstable at some point (it will be a transition
coordinated with Release Team).

You do not need to apply this patch right now, but feel free to review
it and/or upload the patched version to experimental.

--
Dmitry Shachnev
diff -Nru gnubiff-2.2.15/debian/changelog gnubiff-2.2.15/debian/changelog
--- gnubiff-2.2.15/debian/changelog	2014-10-03 19:21:00.000000000 +0400
+++ gnubiff-2.2.15/debian/changelog	2015-06-17 11:57:37.000000000 +0300
@@ -1,3 +1,9 @@
+gnubiff (2.2.15-4.1) UNRELEASED; urgency=medium
+
+  * Port to GAction and libpanel-applet 3.14.
+
+ -- Dmitry Shachnev <mity...@debian.org>  Wed, 17 Jun 2015 11:57:28 +0300
+
 gnubiff (2.2.15-4) unstable; urgency=medium
 
   * Add patch by Frederic Briere to fix mutex unlocking that should really be a
diff -Nru gnubiff-2.2.15/debian/control gnubiff-2.2.15/debian/control
--- gnubiff-2.2.15/debian/control	2014-10-03 19:20:00.000000000 +0400
+++ gnubiff-2.2.15/debian/control	2015-06-17 11:57:12.000000000 +0300
@@ -2,7 +2,7 @@
 Section: mail
 Priority: optional
 Maintainer: Roland Stigge <sti...@antcom.de>
-Build-Depends: debhelper (>= 9), libaudiofile-dev, libgtk-3-dev, libssl-dev, libxml-parser-perl, libfam-dev, libpopt-dev, intltool, automake, autoconf, libpanel-applet-4-dev
+Build-Depends: debhelper (>= 9), libaudiofile-dev, libgconf2-dev, libgtk-3-dev, libssl-dev, libxml-parser-perl, libfam-dev, libpopt-dev, intltool, automake, autoconf, libpanel-applet-dev
 Standards-Version: 3.9.5
 Homepage: http://gnubiff.sourceforge.net/
 
diff -Nru gnubiff-2.2.15/debian/patches/06-libpanel-applet.patch gnubiff-2.2.15/debian/patches/06-libpanel-applet.patch
--- gnubiff-2.2.15/debian/patches/06-libpanel-applet.patch	1970-01-01 03:00:00.000000000 +0300
+++ gnubiff-2.2.15/debian/patches/06-libpanel-applet.patch	2015-06-17 11:57:02.000000000 +0300
@@ -0,0 +1,159 @@
+Description: port to GAction and libpanel-applet 3.14
+Author: Dmitry Shachnev <mity...@debian.org>
+Forwarded: no (upstream seems dead)
+Last-Update: 2014-11-20
+
+--- a/configure.ac
++++ b/configure.ac
+@@ -178,7 +178,7 @@
+ ######################################################################
+ if test "$OPT_USEGNOME" = "yes"; then
+ 	PKG_CHECK_MODULES(GNOME_DEP, [
+-	    libpanelapplet-4.0
++	    libpanel-applet
+     	], [
+ 		AC_SUBST(GNOME_DEP_CFLAGS)
+ 		AC_SUBST(GNOME_DEP_LIBS)
+--- a/src/ui-applet-gnome.h
++++ b/src/ui-applet-gnome.h
+@@ -31,7 +31,6 @@
+ #define __APPLET_GNOME_H__
+ 
+ #include <panel-applet.h>
+-#include <panel-applet-gconf.h>
+ #include "ui-applet-gui.h"
+ 
+ 
+--- a/po/POTFILES.in
++++ b/po/POTFILES.in
+@@ -25,7 +25,7 @@
+ src/gtk_image_animation.cc
+ src/ui-popup.cc
+ src/support.cc
+-src/GNOME_gnubiffApplet.xml
++[type: gettext/glade]src/GNOME_gnubiffApplet.xml
+ ui/applet-gtk.ui
+ ui/preferences.ui
+ ui/properties.ui
+--- a/src/GNOME_gnubiffApplet.xml
++++ b/src/GNOME_gnubiffApplet.xml
+@@ -1,4 +1,18 @@
+-<menuitem name="Item 1" action="Props" />
+-<menuitem name="Item 2" action="MailApp" />
+-<menuitem name="Item 3" action="MailRead" />
+-<menuitem name="Item 4" action="Info" />
++<section>
++  <item>
++    <attribute name="label" translatable="yes">_Preferences...</attribute>
++    <attribute name="action">gnubiff.props</attribute>
++  </item>
++  <item>
++    <attribute name="label" translatable="yes">_Run command</attribute>
++    <attribute name="action">gnubiff.mail-app</attribute>
++  </item>
++  <item>
++    <attribute name="label" translatable="yes">_Mark mailboxes read</attribute>
++    <attribute name="action">gnubiff.mail-read</attribute>
++  </item>
++  <item>
++    <attribute name="label" translatable="yes">_Info</attribute>
++    <attribute name="action">gnubiff.info</attribute>
++  </item>
++</section>
+--- a/src/ui-applet-gnome.cc
++++ b/src/ui-applet-gnome.cc
+@@ -88,36 +88,44 @@
+ 	}
+ 
+ 
+-	static void APPLET_GNOME_on_menu_properties (GtkAction *action,
+-                                                 AppletGnome *data)
++	static void APPLET_GNOME_on_menu_properties (GSimpleAction *action,
++	                                             GVariant *parameter,
++	                                             gpointer user_data)
+ 	{
++		AppletGnome *data = (AppletGnome *)user_data;
+ 		if (data)
+ 			data->show_dialog_preferences ();
+ 		else
+ 			unknown_internal_error ();
+ 	}
+ 
+-	void APPLET_GNOME_on_menu_command (GtkAction *action,
+-                                       AppletGnome *data)
++	void APPLET_GNOME_on_menu_command (GSimpleAction *action,
++	                                   GVariant *parameter,
++	                                   gpointer user_data)
+ 	{
++		AppletGnome *data = (AppletGnome *)user_data;
+ 		if (data)
+ 			data->execute_command ("double_command", "use_double_command");
+ 		else
+ 			unknown_internal_error ();
+ 	}
+ 
+-	void APPLET_GNOME_on_menu_mail_read (GtkAction *action,
+-                                         AppletGnome *data)
++	void APPLET_GNOME_on_menu_mail_read (GSimpleAction *action,
++	                                     GVariant *parameter,
++	                                     gpointer user_data)
+ 	{
++		AppletGnome *data = (AppletGnome *)user_data;
+ 		if (data)
+ 			data->mark_messages_as_read ();
+ 		else
+ 			unknown_internal_error ();
+ 	}
+ 
+-	void APPLET_GNOME_on_menu_info (GtkAction *action,
+-                                    AppletGnome *data)
++	void APPLET_GNOME_on_menu_info (GSimpleAction *action,
++	                                GVariant *parameter,
++	                                gpointer user_data)
+ 	{
++		AppletGnome *data = (AppletGnome *)user_data;
+ 		if (data)
+ 			data->show_dialog_about ();
+ 		else
+@@ -159,18 +167,21 @@
+ AppletGnome::dock (GtkWidget *applet)
+ {
+ 	// Create the applet's menu
+-    static const GtkActionEntry gnubiff_menu_actions [] = {
+-        { "Props",    GTK_STOCK_PROPERTIES, N_("_Preferences..."), NULL, NULL, G_CALLBACK (APPLET_GNOME_on_menu_properties) },
+-        { "MailApp",  GTK_STOCK_PROPERTIES, N_("_Run command"), NULL, NULL, G_CALLBACK (APPLET_GNOME_on_menu_command) },
+-        { "MailRead", GTK_STOCK_PROPERTIES, N_("_Mark mailboxes read"), NULL, NULL, G_CALLBACK (APPLET_GNOME_on_menu_mail_read) },
+-        { "Info",     GTK_STOCK_ABOUT,      N_("_Info"), NULL, NULL, G_CALLBACK (APPLET_GNOME_on_menu_info) }
++    static const GActionEntry gnubiff_menu_actions [] = {
++        { "props",     APPLET_GNOME_on_menu_properties },
++        { "mail-app",  APPLET_GNOME_on_menu_command },
++        { "mail-read", APPLET_GNOME_on_menu_mail_read },
++        { "info",      APPLET_GNOME_on_menu_info }
+     };
+-    GtkActionGroup * action_group = gtk_action_group_new ("ShowDesktop Applet Actions");
+-    gtk_action_group_set_translation_domain (action_group, GETTEXT_PACKAGE);
+-    gtk_action_group_add_actions (action_group, gnubiff_menu_actions, G_N_ELEMENTS (gnubiff_menu_actions), this);
++    GSimpleActionGroup * action_group = g_simple_action_group_new ();
++    g_action_map_add_action_entries (G_ACTION_MAP (action_group),
++                                     gnubiff_menu_actions,
++                                     G_N_ELEMENTS (gnubiff_menu_actions),
++                                     this);
+     gchar *ui_path = g_build_filename (GNUBIFF_UIDIR, "GNOME_gnubiffApplet.xml", NULL);
+-    panel_applet_setup_menu_from_file (PANEL_APPLET (applet), ui_path, action_group);
++    panel_applet_setup_menu_from_file (PANEL_APPLET (applet), ui_path, action_group, GETTEXT_PACKAGE);
+     g_free (ui_path);
++    gtk_widget_insert_action_group (applet, "gnubiff", G_ACTION_GROUP (action_group));
+     g_object_unref (action_group);
+ 
+ 	// We need the PANEL_APPLET_EXPAND_MINOR for getting the correct size of
+--- a/src/Makefile.am
++++ b/src/Makefile.am
+@@ -79,7 +79,7 @@
+ 
+ gnubiff_SOURCES      = $(common_sources)
+ gnubiff_LDADD        = $(INTLLIBS) $(GNUBIFF_DEP_LIBS) $(FAM_LIBS)
+-panelappletdir       = `pkg-config --variable=libpanel_applet_dir libpanelapplet-4.0`
++panelappletdir       = `pkg-config --variable=libpanel_applet_dir libpanel-applet`
+ panelapplet_in_files =
+ panelapplet_DATA     =
+ servicedir           = /usr/share/dbus-1/services
diff -Nru gnubiff-2.2.15/debian/patches/series gnubiff-2.2.15/debian/patches/series
--- gnubiff-2.2.15/debian/patches/series	2014-10-03 19:10:16.000000000 +0400
+++ gnubiff-2.2.15/debian/patches/series	2015-06-17 11:57:02.000000000 +0300
@@ -2,3 +2,4 @@
 02-fix-mutex.patch
 04-fix-POTFILES-in.patch
 05-ignore-pc-dir-for-intltool.patch
+06-libpanel-applet.patch

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message ---
Source: gnubiff
Source-Version: 2.2.15-4.1

We believe that the bug you reported is fixed in the latest version of
gnubiff, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 789...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Shachnev <mity...@debian.org> (supplier of updated gnubiff package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 27 Jun 2015 15:23:29 +0300
Source: gnubiff
Binary: gnubiff
Architecture: source amd64
Version: 2.2.15-4.1
Distribution: unstable
Urgency: medium
Maintainer: Roland Stigge <sti...@antcom.de>
Changed-By: Dmitry Shachnev <mity...@debian.org>
Description:
 gnubiff    - mail notification program for GNOME (and others)
Closes: 789026
Changes:
 gnubiff (2.2.15-4.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Port to GAction and libpanel-applet (closes: #789026):
     - Add debian/patches/06-libpanel-applet.patch.
     - Change build-dependency to libpanel-applet-dev.
Checksums-Sha1:
 0782f10d57dbe3c2dde722233a3675ae2f52be84 1847 gnubiff_2.2.15-4.1.dsc
 a1fef6e90edada803290830ccb66c3f6b7bab933 8720 gnubiff_2.2.15-4.1.debian.tar.xz
 71397a8ceac1577ea25f2ab0f65ef535c86172c0 419240 gnubiff_2.2.15-4.1_amd64.deb
Checksums-Sha256:
 6a1ed9183e8a4cf50a25c73c2757ce6fda48ebba539f4cca59cd2192945a8dc6 1847 
gnubiff_2.2.15-4.1.dsc
 f9c0667e07342ad11ecbd125cbe27cd6ff9387718bdc64ccbdc76a7c6e63f9bc 8720 
gnubiff_2.2.15-4.1.debian.tar.xz
 22b243fd48417958bedf460ef10eb7d2e97f8d1f89fedb080ff929811bf37dbb 419240 
gnubiff_2.2.15-4.1_amd64.deb
Files:
 acc68e35723306c1bb9b371bc7f7016a 1847 mail optional gnubiff_2.2.15-4.1.dsc
 8f335afc5eae2af8735b9980db909c6c 8720 mail optional 
gnubiff_2.2.15-4.1.debian.tar.xz
 6810b05813bb7296a48169dca5e1ed7b 419240 mail optional 
gnubiff_2.2.15-4.1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVjpleAAoJENb+cQNj+F3T2joP/iMXPk1lTa7XtNQuRMkQUzV4
LcOXxsLKmvSSF0ZHHLeTqfsxb2tml6S0Tp8qCYGIPs+NTljBm65GLM70KfZuyXWL
IkhheI6BEloIuVyBVXrvVAjN+H+YTnn8Y4hotwNqWh+xkfzvf3sbhdACR7w8B9g2
TX3KtH+eF191kW8ZD1PgdaaP+6DHpB0GoobiTQqWrbqBqs1vHx4uiBNu9yQGgslS
iJJlWb9hSPafbiRwBLm09+ZcdDWqL8ZdOCMOhGvdkephqq4Fo6UVc/OMKdAG3m6/
hUsp2jcy3jei9H2uNYh5wrQejQF4fe3reNs+meHTBUc66N5NQP4Db4yXiNS5+5vV
VkgJ2s9vPRieG2GxGM+hf+TeYqp8iXRaMBSOu1/IbqX4ReVN+Szr87szoUkKkDL2
UASaTTxy2C2M6aL1dQRV3Jmm13kmtw+8jvEI4rsfWs4NzWKvtmonKBqO6JkLByH4
IJC2wxuozhG7zshZcbNLPWJaQjo1HLQulm9IrcqXzvdr5wsMYvM1mlQFMEtht54D
b1/BFHyUoTuWszTvZgtZMma6sRJvOyys8ptD4ax8K68GYS6sI0/UtldiqhkB5T04
pYgeSM0mUKXpw6g8zF4dTsy4nCnM2an1CPK/XrNAtgtzd6ReLAPRCDFw3eCFx5uT
Un+kSF5NDo+IuJGRBsHK
=0uDM
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to