Source: python-apsw
Version: 3.8.10.1-r1-1
Severity: serious
Tags: patch
Justification: Policy 3.5

Currently python/python3-apsw are missing any python interpreter depends:

Package: python-apsw
Version: 3.8.10.1-r1-1
Depends: libc6 (>= 2.14), libsqlite3-0 (>= 3.8.9)

Package: python3-apsw
Depends: libc6 (>= 2.14), libsqlite3-0 (>= 3.8.9)

This is for two reasons:

1.  dh_python* are called before dh_install so there is nothing for it to
evaluate to generate correct depends.

2.  For python3-apsw, the package uses python:Depends instead of
python3:Depends so it would never get correct depends in any case.

In addition to the policy requirement to have correct dependencies, we also
use python3 max version requirements to track the progress of python3
transitions.  Currently this is not possible for the upcoming python3.5
transition [1] for python-apsw.

Please address is issue ASAP as we are hoping to start the transition soon.  I
have attached a patch that addresses these issues as well as cleaning up a few
Python packaging related issues.  If you are busy and know you will not have
time to address this, please reply to the bug and I'll be glad to take care of
it for you and not wait to NMU.

Scott K
diff -Nru python-apsw-3.8.10.1-r1/debian/changelog python-apsw-3.8.10.1-r1/debian/changelog
--- python-apsw-3.8.10.1-r1/debian/changelog	2015-06-21 10:11:28.000000000 -0400
+++ python-apsw-3.8.10.1-r1/debian/changelog	2015-09-17 07:59:17.000000000 -0400
@@ -1,3 +1,15 @@
+python-apsw (3.8.10.1-r1-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Move dh_python2/3 calls to after dh_install so dependency generation works
+    - Thanks to Piotr Ożarowski for figuring this part out
+  * Correct python:Depends to be python3:Depends so proper dependencies are
+    generated for python3-apsw
+  * Add build-depends on dh-python so current code base is used
+  * Remove obsolete provides
+
+ -- Scott Kitterman <sc...@kitterman.com>  Wed, 16 Sep 2015 23:44:02 -0400
+
 python-apsw (3.8.10.1-r1-1) unstable; urgency=medium
 
   * New upstream release 3.8.10.1-r1
diff -Nru python-apsw-3.8.10.1-r1/debian/control python-apsw-3.8.10.1-r1/debian/control
--- python-apsw-3.8.10.1-r1/debian/control	2015-06-21 10:11:28.000000000 -0400
+++ python-apsw-3.8.10.1-r1/debian/control	2015-09-16 23:47:25.000000000 -0400
@@ -5,7 +5,7 @@
 Maintainer: Joel Rosdahl <j...@debian.org>
 Build-Depends: debhelper (>= 8), python-all-dev (>= 2.6.6-3~), python-all-dbg,
                python3-all-dev, python3-all-dbg, libsqlite3-dev (>= 3.8.10),
-               dpkg-dev (>= 1.16.1~)
+               dpkg-dev (>= 1.16.1~), dh-python
 Standards-Version: 3.9.6
 X-Python-Version: all
 
@@ -13,7 +13,6 @@
 Architecture: any
 Depends: ${shlibs:Depends}, ${python:Depends}, ${misc:Depends}
 Suggests: python-apsw-doc
-Provides: ${python:Provides}
 Conflicts: python2.3-apsw, python2.4-apsw
 Replaces: python2.3-apsw, python2.4-apsw
 Description: another Python SQLite 3 wrapper
@@ -39,9 +38,8 @@
 
 Package: python3-apsw
 Architecture: any
-Depends: ${shlibs:Depends}, ${python:Depends}, ${misc:Depends}
+Depends: ${shlibs:Depends}, ${python3:Depends}, ${misc:Depends}
 Suggests: python-apsw-doc
-Provides: ${python:Provides}
 Description: another Python SQLite 3 wrapper (Python 3 version)
  APSW (Another Python SQLite Wrapper) is an SQLite 3 wrapper that
  provides the thinnest layer over SQLite 3 possible. Everything you
diff -Nru python-apsw-3.8.10.1-r1/debian/rules python-apsw-3.8.10.1-r1/debian/rules
--- python-apsw-3.8.10.1-r1/debian/rules	2015-06-21 10:11:28.000000000 -0400
+++ python-apsw-3.8.10.1-r1/debian/rules	2015-09-17 07:57:40.000000000 -0400
@@ -80,11 +80,11 @@
 	dh_testroot -a
 	dh_installdocs -a debian/NEWS.Debian
 
+	dh_install
+
 	dh_python2 -a
 	dh_python3 -a
 
-	dh_install
-
         # Install debugging extension and remove from regular package
 	(cd debian/python-apsw; \
 	    find . -name "*_d.so" -printf "%P\0" -delete) \

Reply via email to