Hello,
I've fixed the FTBS in my local git repo. I'll request pkg-ruby-extras
membership and upload the fixes next week. As don't know Ruby either,
can someone from the team review?
Detail:
* patch 0001: the package was previously splitted as libjs-handlebars
and libjs-handlebars.runtime
* patch 0002: missing ruby load path. This one is strange and I don't
understand why system load path should be listed here
* patch 0003: fixes js path. This is related to 0001
* TODO patch 0004: debian/changelog
Regards
--
Mathieu
From 23e6c7735a5421b5142bf47cc76d97ba72623931 Mon Sep 17 00:00:00 2001
From: Mathieu Parent <math.par...@gmail.com>
Date: Tue, 13 Oct 2015 04:58:28 +0200
Subject: [PATCH 3/3] Fix path during tests
---
debian/patches/0002-Fix-slimbars-test.patch | 37 +++++++++++++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 38 insertions(+)
create mode 100644 debian/patches/0002-Fix-slimbars-test.patch
diff --git a/debian/patches/0002-Fix-slimbars-test.patch b/debian/patches/0002-Fix-slimbars-test.patch
new file mode 100644
index 0000000..78c433f
--- /dev/null
+++ b/debian/patches/0002-Fix-slimbars-test.patch
@@ -0,0 +1,37 @@
+From: Mathieu Parent <math.par...@gmail.com>
+Date: Tue, 13 Oct 2015 05:26:45 +0200
+Subject: Fix slimbars test
+
+---
+ test/handlebars_assets/slimbars_test.rb | 5 +++++
+ 1 file changed, 5 insertions(+)
+
+diff --git a/test/handlebars_assets/slimbars_test.rb b/test/handlebars_assets/slimbars_test.rb
+index f162d81..2002f26 100644
+--- a/test/handlebars_assets/slimbars_test.rb
++++ b/test/handlebars_assets/slimbars_test.rb
+@@ -5,6 +5,11 @@ module HandlebarsAssets
+ include SprocketsScope
+ include CompilerSupport
+
++ def teardown
++ HandlebarsAssets::Config.reset!
++ HandlebarsAssets::Handlebars.reset!
++ end
++
+ def compile_slim(source)
+ Slim::Template.new(HandlebarsAssets::Config.slim_options) { source }.render
+ end
+diff --git a/test/test_helper.rb b/test/test_helper.rb
+index c829413..fc18e3c 100644
+--- a/test/test_helper.rb
++++ b/test/test_helper.rb
+@@ -57,7 +57,7 @@ module HandlebarsAssets
+ def reset!
+ @chomp_underscore_for_partials = nil
+ @compiler = nil
+- @compiler_path = nil
++ @compiler_path = 'vendor/assets/javascripts'
+ @haml_options = nil
+ @known_helpers = nil
+ @known_helpers_only = nil
diff --git a/debian/patches/series b/debian/patches/series
index d77d941..543a72c 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
engine-root.patch
+0002-Fix-slimbars-test.patch
--
2.6.1
From c20b61299da5ba14d7e61f8d66702beb251fb747 Mon Sep 17 00:00:00 2001
From: Mathieu Parent <math.par...@gmail.com>
Date: Tue, 13 Oct 2015 04:11:55 +0200
Subject: [PATCH 2/3] Fixing: uninitialized constant MiniTest::Test (NameError)
(Closes: #795664)
---
debian/ruby-tests.rake | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/ruby-tests.rake b/debian/ruby-tests.rake
index fc925a8..024e4ab 100644
--- a/debian/ruby-tests.rake
+++ b/debian/ruby-tests.rake
@@ -1,5 +1,6 @@
require 'rake/testtask'
Rake::TestTask.new(:test) do |test|
+ test.libs << '/usr/lib/ruby/vendor_ruby'
test.libs << 'test'
test.test_files = FileList["test/**/*_test.rb"]
test.verbose = false
--
2.6.1
From 09f88579ab0f0b667ce40d56b0964af281d212f9 Mon Sep 17 00:00:00 2001
From: Mathieu Parent <math.par...@gmail.com>
Date: Tue, 13 Oct 2015 03:21:04 +0200
Subject: [PATCH 1/3] Remove circular dep on libjs-handlebars{,.runtime}
---
debian/control | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/debian/control b/debian/control
index ab3e0c2..7388f96 100644
--- a/debian/control
+++ b/debian/control
@@ -4,8 +4,7 @@ Priority: optional
Maintainer: Debian Ruby Extras Maintainers <pkg-ruby-extras-maintain...@lists.alioth.debian.org>
Uploaders: Pirate Praveen <prav...@debian.org>
Build-Depends: debhelper (>= 7.0.50~), gem2deb (>= 0.7.5~), ruby-slim,
- ruby-execjs, ruby-tilt, ruby-multi-json, ruby-sprockets, ruby-haml,
- libjs-handlebars (>= 2:0.20.1~), libjs-handlebars.runtime (>= 2:0.20.1~)
+ ruby-execjs, ruby-tilt, ruby-multi-json, ruby-sprockets, ruby-haml
Standards-Version: 3.9.6
Vcs-Git: git://anonscm.debian.org/pkg-ruby-extras/ruby-handlebars-assets.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-handlebars-assets.git;a=summary
--
2.6.1
