On Sun, Nov 01, 2015 at 11:14:55AM +0200, Sebastian Dröge wrote:
> On Sa, 2015-10-31 at 20:39 +0000, Olly Betts wrote:
> > Status is stalled, essentially.
> >
> > I gather from what slomo said that the current patch isn't suitable
> > for applying.
>
> The first remark is a minor memory leak, the second is just cleanup
> (and usage of the correct API) but at this time has no functional
> difference (but might in the future).
I'd be happier not to leave potential timebombs around, but you haven't
given enough information about this for me to address it...
> The leak you can fix by adding a simple gst_caps_unref() for the caps
> in that function.
OK.
> Does the patch work otherwise? If so, just get it in after adding that
> one line mentioned above :)
I haven't tried to test it yet - I've been short of time lately and it's
a non-trivial amount of work to do so, and my understanding was that the
patch wasn't suitable as-is.
I'll try to find time to test it. Also happy for someone else to test
the amended patch and NMU if it works, but please keep me in the loop to
avoid duplicating effort.
(If someone does NMU, you could usefully drop `--enable-sdl` in
debian/rules to close #802770 - there's no corresponding BD so this
doesn't affect the built result in a clean chroot).
Cheers,
Olly
