On Mon, Feb 01, 2016 at 06:17:56PM +0100, Georges Khaznadar wrote:
> Mattia Rizzolo a écrit :
> > It seems to me that python-satellites builds python3 stuff, it has
> > several py3 dependencies, etc.
> > But there is no python3 direct dependency, which is bad.
> > That's because you're using ${python:Depends} instead of
> > ${python3:Depends}.
>
> Now I replaced ${python:Depends} by ${python3:Depends}, then launched
> "debuild", and had a look at the file python-satellites.substvars
> this file contains:
> ------------------8<------------------------
> misc:Depends=
> misc:Pre-Depends=
> ------------------8<------------------------
>
> Should I raise a bug report? the environment used was not a chroot made
> by pbuilder, and dh-python came in version 2.20150826.
>
> > and btw, you build-depend on python2 packages, maybe you are more
> > interested in python3 ones? (or at this point thet are maybe useless and
> > just remove them?)
>
> You are right! I only need the package which contains pyuic4 to convert
> user interfaces designed with Qt designer.
also stellarium-data turns out to be useless.
> > Then, the package name does not follow the debian python policy,
> > according to which you should name it python3-satellites, the name you
> > are currently using kind of imply python2 stuff (but this point is just
> > a remark, the actual bug is about the first paragraph).
>
> humm.. As this package does not create libraries very useful for other
> developers, I suppose that it might as well be treated as a private
> library: so the scripts should rather go to /usr/share/pysatellites, and
> the package should just be named "pysatellites" rather than
> python3-satellites. What do you think about it?
Happen that this naming thing is quite important and entangled with the
issue above.
Renaming the binary to python3-satellites I have this in
d/python3-satellites.substvars:
python3:Depends=python3:any, python3:any (>= 3.2~), python3:any (>= 3.3.2-2~)
(which becomes just 'Depends: python3:any (>= 3.3.2-2~)' in the binary)
also looks like any other name I choose dh-python3 founds it, just it
doesn't (rightfully so) like python-satellites.
+ it being an application leaves you some liberty on the name.
pysatellites should be as good as any. but python-satellites is just
wrong (as it implies py2 stuff).
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
