Hi Neil, thanks for looking at python-debian for us
In discussing comment handling with the apt and python-apt maintainers, I had reached the conclusion that this test probably needed to be deleted entirely. It is testing to see if some undefined behaviour has a particular outcome as a canary to help guard against other bugs in comment-handling creeping back in. But looking at your suggested patch, given that python-apt now throws an error on this undefined behaviour, I think we've got a better result than checking for one particular mis-parse. This feels a lot safer for consumers of the API, so maybe it is best to test for the failure as you have done here. Thanks. BTW There's a lot of detritus in the diff from python- debian-0.1.27/lib/python_debian.egg-info -- I suspect that this comes from building it twice in a row in the same tree rather than it being build by sbuild or pbuilder. (This is clearly a bug in the build system; perhaps we should be caring more for these files anyway?) cheers Stuart -- Stuart Prescott http://www.nanonanonano.net/ stu...@nanonanonano.net Debian Developer http://www.debian.org/ stu...@debian.org GPG fingerprint 90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7
signature.asc
Description: This is a digitally signed message part.
