tags 822031 + patch
thanks
On Wed, 20 Apr 2016, ni...@thykier.net wrote:
> Package: tcm
> Severity: normal
> Usertags: arch-all-and-any-missing-targets
>
> Hi,
>
> The package tcm builds an architecture independent *and* an
> architecture dependent package, but does not have the (now mandatory)
> "build-arch" and "build-indep" targets in debian/rules.
It's funny but this package is unique in that it has a build-indep
target but not a build-arch target.
The build-indep target is actually empty but binary-indep depends on
the build target. As a result, "dpkg-buildpackage -A" will probably
invoke build-indep as a normal user, then binary-indep as root, which
makes most of the build to be done by root.
This is generally not desirable (see Bug #806654 for an example).
Splitting the build into build-arch and build-indep would be nice, but
this may be done after switching to dh. In the meantime, I would recommend
doing things in the traditional way (i.e. having a build target which
builds everything), as in the attached patch.
Thanks.
--- a/debian/rules
+++ b/debian/rules
@@ -22,15 +22,9 @@ configure-stamp:
cp debian/Config.tmpl src/
touch configure-stamp
-build-indep:
-# $(MAKE) TCM_INSTALL_DIR=/usr \
-# CONFIG_INSTALL=/etc/tcm/ \
-# TCM_INSTALL_DOC=/usr/share/doc/tcm-doc \
-# TCM_INSTALL_SHARE=/usr/share/doc/tcm-doc/ \
-# TCM_INSTALL_MAN=/usr/share/man \
-# docs
-
-build: build-indep build-stamp
+build-arch: build
+build-indep: build
+build: build-stamp
build-stamp: configure-stamp patch-stamp
dh_testdir
@@ -135,4 +129,4 @@ binary-arch: build install
dh_builddeb -a
binary: binary-indep binary-arch
-.PHONY: build build-indep clean binary-indep binary-arch binary install
configure
+.PHONY: build build-arch build-indep clean binary-indep binary-arch binary
install configure
