On 08/24/16 14:35, Aurelien Jarno wrote:
On 2016-08-24 14:20, Sebastiaan Couwenberg wrote:
On Wed, 24 Aug 2016 11:28:23 +0200 Aurelien Jarno wrote:
[I have added a Cc: to the debian-s390 list as it appears we have
multiple copies of this code in the archive, so the patch might be
useful in other packages.]
protobuf has taken the atomicops code from V8, we should fix the
architecture support in V8 upstream to resolve this for all applications
that also take their atomicops code from V8.
I didn't notice this bugreport, so I've also provided a patch for the FTBFS
on s390x in #835302. That patch is based on the v8 port for zSystems, which
is probably preferable over your patch because it's more in line with
upstream.
I think my patch is still important to apply, even if we add your
patch, as it will likely fix the FTBFS on other 64-bit architectures
like alpha or sparc64. That said I haven't tested that.
That sounds reasonable. I'm currently looking into the protobuf build
failures on the various architectures (currently kfreebsd-* &
hurd-i386), when time permits I'll also try your patch on alpha & sparc64.
Kind Regards,
Bas
--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
