Hi,

On 04/11/16 08:51, Radovan Birdic wrote:
> Package drumgizmo_0.9.11-1 FTBFS on mips and mipsel with following error:
> 
>> plugingui-plugingui.o: In function `std::atomic<double>::is_lock_free() 
>> const':
>> /usr/include/c++/6/atomic:212: undefined reference to `__atomic_is_lock_free'
[...]
> The problem is in configure.ac file. Code used for checking is libatomic 
> needed to link 
> always returns the same result. For mips and mipsel test passes but the build 
> fails because of missing libatomic.
> I have changed that test to provide linking with libatomic as needed.

The patch:
> --- drumgizmo-0.9.11.orig/configure.ac
> +++ drumgizmo-0.9.11/configure.ac
> @@ -473,11 +473,12 @@ dnl ======================
>  AC_MSG_CHECKING([for the need for linkage with libatomic])
>  AC_LANG_PUSH([C++])
>  AC_LINK_IFELSE([AC_LANG_SOURCE[
> +      #include <cstdinti>

Typo? You want <cstdint>

>        #include <atomic>
> +      std::atomic<uintptr_t> x;
> +      std::atomic<uintmax_t> y;      

I don't think you should rely on these types being in the global namespace.

>        int main() {
> -        struct Test { int val; };
> -        std::atomic<Test> s;
> -        return s.is_lock_free()?1:0;
> +     return x + y;
>        }
>      ]],
>      [AC_MSG_RESULT([no])],

Thanks,
James

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to