Your message dated Thu, 10 Nov 2016 07:48:39 +0000
with message-id <e1c4k6b-0002qw...@fasolo.debian.org>
and subject line Bug#842326: fixed in ncmpc 0.25-0.1
has caused the Debian Bug report #842326,
regarding [PATCH] [RC] Fix FTBS for when building against upcoming lirc-0.9.4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
842326: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=842326
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: ncmpc
Version:0.24-1

Lirc is undergoing a major update, and ncmpc fails to build against the new version. The problem is two-fold: the configure file needs an update, but the autoreconf setup in 0.24 is broken. The enclosed patch for the complete debian/directories are based on an update to latest upstream 0.25 - this fixes the autoreconf issues. The new patch introduced updates configure.ac and Makefile.am to use the new pkgconfig name. It also adds an autoreconf invocation to the build, building successfully against the new lirc.

Note that this patch requires lirc 0.9.4+, it is not backwards-compatible.


Cheers!

--alec


diff -rNU2 ncmpc-0.24/debian/changelog ncmpc-0.25/debian/changelog
--- ncmpc-0.24/debian/changelog	2014-07-15 20:50:26.000000000 +0200
+++ ncmpc-0.25/debian/changelog	2016-10-28 07:07:22.284504344 +0200
@@ -1,2 +1,8 @@
+ncmpc (0.25-1) unstable; urgency=medium
+
+  * New upstream release
+
+ -- Alec Leamas <lea...@nowhere.net>  Fri, 28 Oct 2016 07:05:23 +0200
+
 ncmpc (0.24-1) unstable; urgency=medium
 
diff -rNU2 ncmpc-0.24/debian/control ncmpc-0.25/debian/control
--- ncmpc-0.24/debian/control	2014-04-27 13:38:06.000000000 +0200
+++ ncmpc-0.25/debian/control	2016-10-28 07:09:01.705005546 +0200
@@ -3,5 +3,5 @@
 Priority: optional
 Maintainer: Sebastian Harl <tok...@debian.org>
-Build-Depends: debhelper (>= 7), dpkg-dev (>= 1.14.6), autotools-dev, libncursesw5-dev, libglib2.0-dev, liblircclient-dev, libmpdclient-dev (>= 2.5~), doxygen
+Build-Depends: debhelper (>= 7), dpkg-dev (>= 1.14.6), autotools-dev, libncursesw5-dev, libglib2.0-dev, liblircclient-dev, libmpdclient-dev (>= 2.5~), doxygen, dh-autoreconf
 Standards-Version: 3.9.5
 Homepage: http://mpd.wikia.com/wiki/Client:Ncmpc
diff -rNU2 ncmpc-0.24/debian/patches/series ncmpc-0.25/debian/patches/series
--- ncmpc-0.24/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ ncmpc-0.25/debian/patches/series	2016-10-28 07:27:45.233858444 +0200
@@ -0,0 +1 @@
+Use-correct-lirc-pkgconfig-name.patch
diff -rNU2 ncmpc-0.24/debian/patches/Use-correct-lirc-pkgconfig-name.patch ncmpc-0.25/debian/patches/Use-correct-lirc-pkgconfig-name.patch
--- ncmpc-0.24/debian/patches/Use-correct-lirc-pkgconfig-name.patch	1970-01-01 01:00:00.000000000 +0100
+++ ncmpc-0.25/debian/patches/Use-correct-lirc-pkgconfig-name.patch	2016-10-28 07:29:07.622541987 +0200
@@ -0,0 +1,40 @@
+Description: Use lirc instead of liblircclient0 pkg-config name
+
+Upcoming lirc-0.9-4 drops support for the old liblircclient0
+pkg-config name, leading to FTBS errors.
+
+Author: Alec Leamas <lea...@nowhere.net>
+
+--- ncmpc-0.25.orig/Makefile.am
++++ ncmpc-0.25/Makefile.am
+@@ -7,7 +7,7 @@ AUTOMAKE_OPTIONS = foreign 1.11 dist-xz
+ AM_CPPFLAGS = \
+ 	$(LIBMPDCLIENT_CFLAGS) \
+ 	$(GLIB_CFLAGS) \
+-	$(LIBLIRCCLIENT_CFLAGS) \
++	$(LIRC_CFLAGS) \
+ 	-DLOCALE_DIR=\""$(datadir)/locale"\"\
+ 	-DSYSCONFDIR=\""$(sysconfdir)"\"
+ 
+@@ -69,7 +69,7 @@ src_ncmpc_LDADD = \
+ 	$(CURSES_LIB) \
+ 	$(LIBMPDCLIENT_LIBS) \
+ 	$(GLIB_LIBS) \
+-	$(LIBLIRCCLIENT_LIBS)
++	$(LIRC_LIBS)
+ 
+ src_ncmpc_SOURCES = \
+ 	src/Compiler.h \
+--- ncmpc-0.25.orig/configure.ac
++++ ncmpc-0.25/configure.ac
+@@ -184,8 +184,8 @@ AC_ARG_ENABLE([lirc],
+ 		[Enable LIRC support]),,
+ 	[enable_lirc=no])
+ if test x$enable_lirc = xyes; then
+-	PKG_CHECK_MODULES([LIBLIRCCLIENT], [liblircclient0],,
+-		[AC_MSG_ERROR([liblircclient0 not found])])
++	PKG_CHECK_MODULES([LIRC], [lirc],,
++		[AC_MSG_ERROR([lirc not found])])
+ 	AC_DEFINE([ENABLE_LIRC], [1], [Enable LIRC support])
+ fi
+ 
diff -rNU2 ncmpc-0.24/debian/rules ncmpc-0.25/debian/rules
--- ncmpc-0.24/debian/rules	2014-07-12 19:08:06.000000000 +0200
+++ ncmpc-0.25/debian/rules	2016-10-28 07:08:45.188675100 +0200
@@ -25,4 +25,5 @@
 config.status: configure
 	dh_testdir
+	dh_autoreconf
 	./configure --host=$(DEB_HOST_GNU_TYPE) \
 			--build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr \

--- End Message ---
--- Begin Message ---
Source: ncmpc
Source-Version: 0.25-0.1

We believe that the bug you reported is fixed in the latest version of
ncmpc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 842...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alec Leamas <lea...@nowhere.net> (supplier of updated ncmpc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 28 Oct 2016 07:05:23 +0200
Source: ncmpc
Binary: ncmpc ncmpc-lyrics
Architecture: source
Version: 0.25-0.1
Distribution: unstable
Urgency: medium
Maintainer: Sebastian Harl <tok...@debian.org>
Changed-By: Alec Leamas <lea...@nowhere.net>
Description:
 ncmpc      - ncurses-based audio player
 ncmpc-lyrics - ncurses-based audio player (lyrics plugins)
Closes: 842326
Changes:
 ncmpc (0.25-0.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * New upstream release
     - this release includes the autoreconf fixes
   * debian/patches/lirc.patch:
     - Adapt the configure script to detect the new lirc (Closes: #842326).
       (patch has been accepted upstream)
Checksums-Sha1:
 62990f332a2aca17200428a867d63088b3b7acfa 1970 ncmpc_0.25-0.1.dsc
 9a77145612898224be807f17402f61a50ed90fe4 451950 ncmpc_0.25.orig.tar.gz
 d2cec744618d78e0ca8638a21fabfb7831631f75 9220 ncmpc_0.25-0.1.debian.tar.xz
Checksums-Sha256:
 fbdfab8a1e5b2f7d830d4a1da62bc5de4bb4b47c7cd112d16f4b59edd72712c4 1970 
ncmpc_0.25-0.1.dsc
 5b00237be90367aff98b2b70df88b6d6d4b566291d870053be106b137dcc0fd9 451950 
ncmpc_0.25.orig.tar.gz
 1a1cf41da270bbce505891c388f5ae27bd0668ed98831c87681cfc3410989ecc 9220 
ncmpc_0.25-0.1.debian.tar.xz
Files:
 9e2fd820ca9e95271bdf4705825f58ba 1970 sound optional ncmpc_0.25-0.1.dsc
 b6b9a42126de26b50fa3970867a889c5 451950 sound optional ncmpc_0.25.orig.tar.gz
 154a4c7842a076d1d1549ee5a85b8646 9220 sound optional 
ncmpc_0.25-0.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJYJCKwAAoJEPNPCXROn13Z/78QAMW9MOqIcLgUVVkvYUdoCojN
SE7vzPzskjcBBbxprADmS+CKo8/vlJI0riRUs2OLudXTsFRA+DCHY7kxhYMi3IWf
yoEtrdiL45i4vGYn2rCamWo+HJaNOXOkq2PgzegnrBs/3xGgxfv0eDMR9jxPlQRO
HqlZi79QFM5DRNerZHdceIKyqXJH6++L96R6Gl1XujjkpnMcsV3dYB7QF6BY/knV
2l84cI6TP1G9CEmzMDUXU4bVVDmfKi0PnP+fJwlR7oLow0LRG0bjwcK9Sh/Q8UHN
pq628CAscrBV6tpOg/iIVeo9PohCOUrhrB47zrHOY0431CftBHWZF9bLXa9DceKa
nHJpUKXkwlL7lhXm7TQrp4TT540zFbarHBCJ18NwpXYjZVKMFgWeTV+Xl9AvA4My
xBwftxV/K0/xh1E6ZVe+k34xzOTDtL1Qp+6cm+Xf1JaSIeKEIRDId4IChW5+WjYs
2kQ4WkGZj2T30ayIiUSi/3e5KvLS9syiWk9ybqBw038syqrf+Ht7WK9NkJ2Pd3Ds
KPFUNSxkZgi3tFRhGJZHhVKe46mlDHRp1c9A0o9AWDngoTNOr9qbs1Qt9i/fmO12
gRW4E0jEsLIdaAq5rFI0Itzh85gJnWs1yfOGf5Wr8a0I0pvrz4H7N/2IKjkIb/bY
7FfhdnnDQytqgwKANvRv
=aQGP
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to