Your message dated Wed, 30 Nov 2016 19:55:13 +0000
with message-id <e1ccayh-000b3b...@fasolo.debian.org>
and subject line Bug#845388: fixed in wordpress 4.6.1+dfsg-2
has caused the Debian Bug report #845388,
regarding wordpress: FTBFS randomly (does not follow Policy 4.6)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
845388: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=845388
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: src:wordpress
Version: 4.6.1+dfsg-1
Severity: serious
Tags: patch

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
(which is what the "Arch: all" autobuilder would do to build it)
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --with linktree
   dh_testdir -i
   dh_update_autotools_config -i
   dh_auto_configure -i
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<BUILDDIR>>/wordpress-4.6.1+dfsg'
for i in $(find debian/languages/ -name *.po); do \
        msgfmt $i -o ${i%%.po}.mo; \
        done
debian/languages/gl_ES.po:50: 'msgid' and 'msgstr' entries do not both end with 
'\n'
debian/languages/gl_ES.po:689: 'msgid' and 'msgstr' entries do not both begin 
with '\n'
msgfmt: found 3 fatal errors
debian/languages/pt_BR.po:4774: 'msgid' and 'msgstr' entries do not both begin 
with '\n'
msgfmt: found 2 fatal errors
debian/languages/admin-de_DE.po:3105: 'msgid' and 'msgstr' entries do not both 
end with '\n'
debian/languages/admin-de_DE.po:3421: 'msgid' and 'msgstr' entries do not both 
end with '\n'
msgfmt: found 2 fatal errors
debian/languages/ar.po:258: 'msgid' and 'msgstr' entries do not both end with 
'\n'
debian/languages/ar.po:990: 'msgid' and 'msgstr[3]' entries do not both end 
with '\n'
debian/languages/ar.po:4091: 'msgid' and 'msgstr' entries do not both begin 
with '\n'
msgfmt: found 4 fatal errors
debian/languages/de_DE.po:628: 'msgid' and 'msgstr' entries do not both end 
with '\n'
debian/languages/de_DE.po:3812: 'msgid' and 'msgstr' entries do not both begin 
with '\n'
msgfmt: found 2 fatal errors
debian/languages/he_IL.po:3791: 'msgid' and 'msgstr' entries do not both begin 
with '\n'
msgfmt: found 2 fatal errors
debian/languages/admin-gl_ES.po:375: 'msgid' and 'msgstr' entries do not both 
begin with '\n'
msgfmt: found 2 fatal errors
debian/languages/twentyfourteen/sq.po:231: end-of-line within string
debian/languages/twentyfourteen/sq.po:230: missing 'msgstr' section
debian/languages/twentyfourteen/sq.po:231:5: syntax error
debian/languages/twentyfourteen/sq.po:232: end-of-line within string
msgfmt: found 4 fatal errors
debian/languages/sk_SK.po:507: 'msgid' and 'msgstr' entries do not both begin 
with '\n'
msgfmt: found 2 fatal errors
debian/rules:16: recipe for target 'override_dh_auto_build' failed
make[1]: *** [override_dh_auto_build] Error 1
make[1]: Leaving directory '/<<BUILDDIR>>/wordpress-4.6.1+dfsg'
debian/rules:13: recipe for target 'build-indep' failed
make: *** [build-indep] Error 2
dpkg-buildpackage: error: debian/rules build-indep gave error exit status 2
--------------------------------------------------------------------------------

The "override_dh_auto_build" target has a "find" command which creates
a list of po files to be processed.

There is not a canonical order for the output of "find", it depends on
filesystem ordering and it may be anything.

As a result, sometimes the last po file to be processed will be ok,
and the build as a whole will be successful, and sometimes the last
po file to be processed will have an error, and the build as a whole
will fail.

This is really a violation of Policy 4.6, "Error trapping in makefiles".

Quote:

  Every time you put more than one shell command (this includes using a
  loop) in a makefile command you must make sure that errors are
  trapped. For simple compound commands, such as changing directory and
  then running a program, using && rather than semicolon as a command
  separator is sufficient. For more complex commands including most
  loops and conditionals you should include a separate set -e command at
  the start of every makefile command that's actually one of these
  miniature shell scripts. 

The (trivial) patch below will probably fix the Policy violation, but
you will also need to fix the broken po files, otherwise we will just
switch from a package which FTBFS randomly to a package which always
FTBFS.

While we are at it: Even if this package is Arch:all, please consider
uploading it in source-only form so that we get official build logs
here:

https://buildd.debian.org/status/package.php?p=wordpress

Thanks.

--- a/debian/rules
+++ b/debian/rules
@@ -13,7 +13,7 @@ WP_CONTENT = debian/wordpress/var/lib/wordpress/wp-content
        dh $@ --with linktree
 
 override_dh_auto_build:
-       for i in $$(find debian/languages/ -name *.po); do \
+       set -e; for i in $$(find debian/languages/ -name *.po); do \
                msgfmt $$i -o $${i%%.po}.mo; \
         done
        pod2man --utf8 --center wp-setup debian/wp-setup debian/wp-setup.1

--- End Message ---
--- Begin Message ---
Source: wordpress
Source-Version: 4.6.1+dfsg-2

We believe that the bug you reported is fixed in the latest version of
wordpress, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 845...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Craig Small <csm...@debian.org> (supplier of updated wordpress package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 30 Nov 2016 22:40:08 +1100
Source: wordpress
Binary: wordpress wordpress-l10n wordpress-theme-twentysixteen 
wordpress-theme-twentyfifteen wordpress-theme-twentyfourteen
Architecture: source all
Version: 4.6.1+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Craig Small <csm...@debian.org>
Changed-By: Craig Small <csm...@debian.org>
Description:
 wordpress  - weblog manager
 wordpress-l10n - weblog manager - language files
 wordpress-theme-twentyfifteen - weblog manager - twentytfifteen theme files
 wordpress-theme-twentyfourteen - weblog manager - twentyfourteen theme files
 wordpress-theme-twentysixteen - weblog manager - twentysixteen theme files
Closes: 845388
Changes:
 wordpress (4.6.1+dfsg-2) unstable; urgency=medium
 .
   * Remove -e from for loop Closes: #845388
   * Thanks to Santiago Vila for above patch
   * Update and fix the language files
Checksums-Sha1:
 21776938561b4c4ac62189da095ddd2e09230bbd 2505 wordpress_4.6.1+dfsg-2.dsc
 716a87aa8c75d755b444425debc2a263c88031ef 6950756 
wordpress_4.6.1+dfsg-2.debian.tar.xz
 af704f427b2e498e0f078b714e3a5f4690ba6469 4242280 
wordpress-l10n_4.6.1+dfsg-2_all.deb
 010323a1d910f42e0344319d4b04b8e5c586f56f 698908 
wordpress-theme-twentyfifteen_4.6.1+dfsg-2_all.deb
 8fe53064c7b72e16110a15fc9b033a0fde0d4fff 1122194 
wordpress-theme-twentyfourteen_4.6.1+dfsg-2_all.deb
 07ded021b9628ccb16a947316c5ab05fdacd5cf1 587832 
wordpress-theme-twentysixteen_4.6.1+dfsg-2_all.deb
 a3a81a30daf9bc73a4b5cd28661a791ab6a4d343 3830800 wordpress_4.6.1+dfsg-2_all.deb
Checksums-Sha256:
 e10b8f350a5b003f422469f360e54a462d1c0d36d605d5e2594c1b3e5050d8a8 2505 
wordpress_4.6.1+dfsg-2.dsc
 01cf218d79919c83ef915452e79f917766be8d0c3e6da5ddee9ec5c9e4bcbc34 6950756 
wordpress_4.6.1+dfsg-2.debian.tar.xz
 e3fac4ad9500a2250eab1e5310a9ecaa09295430163b75324552f9c22e50663a 4242280 
wordpress-l10n_4.6.1+dfsg-2_all.deb
 6cad6754b39433ecaa58994531be4753c73197ffd77bac7a5402472d68396c67 698908 
wordpress-theme-twentyfifteen_4.6.1+dfsg-2_all.deb
 2f5b313cc08e423b39c4d3aa61fe1069dea8e34695a0f42359c8c74141f54c33 1122194 
wordpress-theme-twentyfourteen_4.6.1+dfsg-2_all.deb
 cdb1465a6a1b242687ddb120971b0d1c0ed25b3fae43655f9ae58acf70143a63 587832 
wordpress-theme-twentysixteen_4.6.1+dfsg-2_all.deb
 ad8ba70d7cd4c7e2e442fed4b7ed86e2ad5a1f6fdb2d877146b87e69daf2f05e 3830800 
wordpress_4.6.1+dfsg-2_all.deb
Files:
 b687eac1cfe1f9cb5d26f8602289bf5e 2505 web optional wordpress_4.6.1+dfsg-2.dsc
 454db9532897f30e5e7fbff141c0cf27 6950756 web optional 
wordpress_4.6.1+dfsg-2.debian.tar.xz
 04d0f8ca844378594530cfc843d25441 4242280 localization optional 
wordpress-l10n_4.6.1+dfsg-2_all.deb
 470bed42fcaa16ac43cf1f19e93b7841 698908 web optional 
wordpress-theme-twentyfifteen_4.6.1+dfsg-2_all.deb
 5cc89c9275db80d0be702b4186d9dc7a 1122194 web optional 
wordpress-theme-twentyfourteen_4.6.1+dfsg-2_all.deb
 497aa2c2aefdedd6a57313f6f07ba579 587832 web optional 
wordpress-theme-twentysixteen_4.6.1+dfsg-2_all.deb
 c4deaebef34fa83db35ebf573d136160 3830800 web optional 
wordpress_4.6.1+dfsg-2_all.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJYPryRAAoJEAIhZsD/PITjACcQAICaf5hMroW+ND88/s4jShlC
bi6EGnDWtawrT/VRW9/M9Q92jPCu9qQ85ytPGQwRhA+9FbrJrTvrKdsBheJQrpKG
0cnglBX+zPxVWVomxB+nAV+fZCSQxHapnzPMaAhbLj3mkUxroyOqIwBUsfQhLqkF
e4KSXmdAO+S3Jzi1PeOLqScliqK9CIAVvabSgmMINw/ie4Cn9P7ACqUK2wdk9zcZ
sHiTELuHf1T2M8QMnZIj5MktrTKp/K4ubEdHD87UeyPFW7ZRHmBMP/wYJlQX7YzI
Hf5PlRyIW59jEYFUKYhxwMRvjMhKMfhNqg05d4vplswPGMiF+bi8Mp/kKr+CMm0r
S3xDC21E2X3Jvxfi5NUbfEaWxuClqaPIPLkOqEF0U4z8KNjowdJNQ6+3Rqjfw0/D
1Uh9lWKphzKzWgxsvSD4vvrGQJrjU3jxYpB1Ly5Fmye07xu3NZznjZzx2M6XnZ1+
zxkxJPcWG9acwPi91qLtgVR3uqGGFSdepgmETpqirIfUyDYvA3crXoP8J93qIp4q
kol6n6Kp0Thcjtwv3+bCBlSdWWp7wlDwGMfmGdV3vfF6lF/YxYzWRoI8ykT0HDAC
vOfqs52ylqd6T8QiLHzQ51tLA3pGbzLinUQb8YCfINiP6cRKInaYmdIJswD5QcVI
gpUXoghb7Ka4S9Hv8Z20
=KAyG
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to