On Wed, 03 May 2017 at 16:13:25 -0400, Ryan Kavanagh wrote:
> nodm fails to install/upgrade.
What version did you upgrade from, and how long had you had that version
installed before upgrading?
If you try to downgrade to 0.13-1 (in testing), do you still get this?
If you do, please mark this bug as found in 0.13-1 so the fix for #860463
can migrate - at the moment this bug report is preventing another RC bug
from being fixed in testing.
I suspect this regressed in 0.12-1.1 with the addition of the native
systemd unit.
> I marked the severity as grave because the package fails
> to install/upgrade, thus rendering it unusable to (all?) users.
I think this bug makes it unusable to users who boot with systemd and
have configured nodm to not be started on boot (which does prompt the
question of why it's installed at all), so not all users.
A systemd unit identical to the one in 0.13-1 works fine for me on
a system where nodm is enabled.
I think the attached patch should hopefully fix this bug (thanks to
Ansgar Burchardt for suggesting this approach) but I haven't had a
chance to test it on a system with NODM_ENABLED=false yet.
S
From: Simon McVittie <s...@debian.org>
Date: Mon, 8 May 2017 17:01:40 +0100
Subject: nodm.service: Don't respawn or fail if disabled in
/etc/default
Bug-Debian: https://bugs.debian.org/861771
---
nodm.service.in | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/nodm.service.in b/nodm.service.in
index 0b7e95b..b6c77fa 100644
--- a/nodm.service.in
+++ b/nodm.service.in
@@ -5,7 +5,11 @@ After=plymouth-quit.service systemd-user-sessions.service
[Service]
EnvironmentFile=-/etc/default/nodm
-ExecStartPre=/usr/bin/test ${NODM_ENABLED} != no -a ${NODM_ENABLED} != false
+# 77 is EX_NOPERM, and doesn't seem to be used by nodm itself
+ExecStartPre=/bin/sh -c 'if test ${NODM_ENABLED} = no || test ${NODM_ENABLED} = false; then exit 77; fi'
+# Don't respawn or mark as failed if disabled via /etc/default/nodm
+RestartPreventExitStatus=77
+SuccessExitStatus=77
ExecStart=@sbindir@/nodm $NODM_OPTIONS
Restart=always
KillMode=mixed
