On Thu, 22 Jun 2017 22:01:26 +0300, Niko Tyni wrote: > > Some recent change in unstable makes this package FTBFS: > > Probably libmodule-build-perl_0.422400-1 though I don't really know why, > given the changelog says > - Remove 0003-Make-Module-Build-set-PERL_UNSAFE_INC.patch (fixed > upstream)
It's entirely possible that I did something wrong here when solving a
merge conflict (this is one of the git-debcherry packages).
Or, looking at the diff again, it might be that upstream not only
solved this differently but also left out a part we had in our patch
(and I ignored this difference):
Basically the diff between 0.422000-1 (with our changes) and 0.422400-1
(with a different fix and without our patch) is:
@@ -1824,6 +1824,11 @@ sub print_build_script {
my $shebang = $self->_startperl;
my $magic_number = $self->magic_number;
+my $dot_in_inc_code = $INC[-1] eq '.' ? <<'END' : '';
+ if ($INC[-1] ne '.') {
+ push @INC, '.';
+ }
+END
print $fh <<EOF;
$shebang
@@ -1860,8 +1865,7 @@ BEGIN {
(
$quoted_INC
);
- push \@INC, "." unless grep { \$_ eq "." } \@INC; # Force my process to
include . in \@INC.
- \$ENV{"PERL_USE_UNSAFE_INC"} = 1; # Force all child processes to include .
in \@INC.
+$dot_in_inc_code
}
close(*DATA) unless eof(*DATA); # ensure no open handles to this script
So what is not there anymore is PERL_USE_UNSAFE_INC=1.
And the relevant upstream issue is
https://github.com/Perl-Toolchain-Gang/Module-Build/issues/69
which ends with "For the time being, I'm cancelling this issue."
If the missing environment variable is the root of the problem, we
probably should add it back rather sooner than later :/
Cheers,
gregor
--
.''`. https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Alanis Morisette: Surrendering
signature.asc
Description: Digital Signature
