On 06/10/2017 02:02 PM, Andreas Beckmann wrote:
> Package: sympa
> Version: 6.2.16~dfsg-3
> Severity: serious
> User: debian...@lists.debian.org
> Usertags: piuparts
> 
> Hi,
> 
> during a test with piuparts I noticed your package modifies conffiles.
> This is forbidden by the policy, see
> https://www.debian.org/doc/debian-policy/ch-files.html#s-config-files
> 
> 10.7.3: "[...] The easy way to achieve this behavior is to make the
> configuration file a conffile. [...] This implies that the default
> version will be part of the package distribution, and must not be
> modified by the maintainer scripts during installation (or at any
> other time)."
> 
> Note that once a package ships a modified version of that conffile,
> dpkg will prompt the user for an action how to handle the upgrade of
> this modified conffile (that was not modified by the user).
> 
> Further in 10.7.3: "[...] must not ask unnecessary questions
> (particularly during upgrades) [...]"
> 
> If a configuration file is customized by a maintainer script after
> having asked some debconf questions, it may not be marked as a
> conffile. Instead a template could be installed in /usr/share and used
> by the postinst script to fill in the custom values and create (or
> update) the configuration file (preserving any user modifications!).
> This file must be removed during postrm purge.
> ucf(1) may help with these tasks.
> See also https://wiki.debian.org/DpkgConffileHandling
> 
> In https://lists.debian.org/debian-devel/2012/09/msg00412.html and
> followups it has been agreed that these bugs are to be filed with
> severity serious.
> 
> debsums reports modification of the following files,
> from the attached log (scroll to the bottom...):
> 
> 3m56.7s ERROR: FAIL: debsums reports modifications inside the chroot:
>   debsums: missing file /etc/sympa/sympa.conf-smime.in (from sympa package)
> 
> 
> If the conffile is actually obsolete, please use
>   dpkg-maintscript-helper rm_conffile
> to remove it properly (also from dpkg's database).
> 
> 
> cheers,
> 
> Andreas
> 

Patch attached.

Regards
        Racke

-- 
Ecommerce and Linux consulting + Perl and web application programming.
Debian and Sympa administration.
commit eede19d78fe07fcf0b0b888efd0bcf40ade9f2f4
Author: Stefan Hornburg (Racke) <ra...@linuxia.de>
Date:   Sat Jun 24 19:56:37 2017 +0200

    Add call for removing sympa.conf-smime.in by maintainer scripts.

diff --git a/debian/sympa.maintscript b/debian/sympa.maintscript
index 05f3dc1..62e713d 100644
--- a/debian/sympa.maintscript
+++ b/debian/sympa.maintscript
@@ -1 +1,2 @@
 rm_conffile /etc/sympa/sympa/sympa.conf "6.2.16~dfsg-2~"
+rm_conffile /etc/sympa/sympa.conf-smime.in "6.2.16~dfsg-4~"

commit 21830c49e4f545bf1b8f6e2118a68859350d834f
Author: Stefan Hornburg (Racke) <ra...@linuxia.de>
Date:   Sun Jun 18 15:53:42 2017 +0200

    Remove /etc/sympa/sympa.conf-smime.in from conffiles (#864546).

diff --git a/debian/sympa.install b/debian/sympa.install
index 22ce80c..3f16eea 100644
--- a/debian/sympa.install
+++ b/debian/sympa.install
@@ -3,7 +3,6 @@ debian/conf/rsyslog/facility        etc/sympa
 debian/conf/apache2/sympa.conf      etc/apache2/conf-available
 debian/conf/apache2/sympa-soap.conf etc/apache2/conf-available
 debian/conf/auth.conf               etc/sympa
-debian/conf/sympa.conf-smime.in     etc/sympa
 debian/conf/topics.conf             etc/sympa
 #debian/dbconfig-common/*            usr/share/dbconfig-common/data/sympa
 src/bin/sympa_soap_client.pl        usr/share/doc/sympa/examples/script

Reply via email to