Your message dated Mon, 10 Jul 2017 15:17:18 +0000
with message-id <e1duar4-0005h2...@fasolo.debian.org>
and subject line Bug#866388: fixed in uim 1:1.8.6+gh20161003.0.d63dadd-2.1
has caused the Debian Bug report #866388,
regarding uim: FTBFS with gnome-panel 3.24, needs switch to in-process applet
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
866388: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=866388
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: uim
Version: 1:1.8.6+gh20161003.0.d63dadd-2
Severity: important
Tags: patch
Forwarded: https://github.com/uim/uim/pull/99
Uim FTBFS with gnome-panel 3.22 / 3.24, because support for out-of-process
applets has been dropped there [1].
The attached patch is based on upstream commits [2] and [3] and ports
the code to be an in-process applet. Please apply it to make your package
build with the new gnome-panel versions (it should work with 3.20 too).
With this patch, you also need to update your uim-applet-gnome.install:
--- a/debian/uim-applet-gnome.install
+++ b/debian/uim-applet-gnome.install
@@ -1,4 +1,3 @@
-usr/lib/*/uim/uim-toolbar-applet-gnome3
-usr/share/dbus-1/services/org.gnome.panel.applet.UimAppletFactory.service
-usr/share/gnome-panel/5.0/applets/UimApplet.panel-applet
+usr/lib/*/uim/libuim-toolbar-applet-gnome3.so
+usr/share/gnome-panel/applets/UimApplet.panel-applet
usr/share/uim/ui/uim-applet-menu.xml
While I am at it, you may also want to consider backporting
https://github.com/uim/uim/pull/108 which will be useful for upcoming
Qt 5.9 transition.
[1]:
https://mail.gnome.org/archives/gnome-flashback-list/2016-July/msg00000.html
[2]: https://github.com/uim/uim/commit/77253cd439b9ef3c
[3]: https://github.com/uim/uim/commit/f883892ef6cb8375
--
Dmitry Shachnev
Description: make the GNOME Panel applet compatible with libpanel-applet2
* Port from out-of-process applet to in-process applet.
* Get the applets directory from pkg-config instead of using the
hard-coded path.
Origin: upstream, commits:
https://github.com/uim/uim/commit/77253cd439b9ef3c
https://github.com/uim/uim/commit/f883892ef6cb8375
Last-Update: 2017-06-29
--- a/configure.ac
+++ b/configure.ac
@@ -861,6 +861,14 @@
AM_CONDITIONAL(GNOME3_APPLET, test "x$enable_gnome3_applet" = xyes)
+if test "x$enable_gnome3_applet" = xyes; then
+ AC_ARG_WITH([libpanel-applet-dir], [], [LIBPANEL_APPLET_DIR=$withval], [LIBPANEL_APPLET_DIR=""])
+ if test "$LIBPANEL_APPLET_DIR" == ""; then
+ LIBPANEL_APPLET_DIR=`$PKG_CONFIG --variable=libpanel_applet_dir libpanel-applet`
+ fi
+ AC_SUBST(LIBPANEL_APPLET_DIR)
+fi
+
AC_ARG_ENABLE(debug,
AC_HELP_STRING([--enable-debug],
[enable debugging]),
--- a/gtk3/toolbar/Makefile.am
+++ b/gtk3/toolbar/Makefile.am
@@ -1,51 +1,47 @@
EXTRA_DIST = UimApplet.panel-applet.in.in \
- uim-applet-menu.xml \
- org.gnome.panel.applet.UimAppletFactory.service.in
+ uim-applet-menu.xml
if GNOME3_APPLET
helper_defs = -DUIM_DATADIR=\""$(datadir)/@PACKAGE@"\"
-libexec_PROGRAMS = uim-toolbar-applet-gnome3
+uim_toolbar_applet_gnome3_libdir = $(pkglibdir)
+uim_toolbar_applet_gnome3_lib_LTLIBRARIES = libuim-toolbar-applet-gnome3.la
xmluidir = $(pkgdatadir)/ui
xmlui_DATA = uim-applet-menu.xml
-uim_toolbar_applet_gnome3_LDADD = @GTK3_LIBS@ @GNOME3_APPLET_LIBS@ \
+libuim_toolbar_applet_gnome3_la_LIBADD = @GTK3_LIBS@ @GNOME3_APPLET_LIBS@ \
$(top_builddir)/uim/libuim-scm.la \
$(top_builddir)/uim/libuim.la \
$(top_builddir)/uim/libuim-custom.la
-uim_toolbar_applet_gnome3_CPPFLAGS = \
+libuim_toolbar_applet_gnome3_la_CPPFLAGS = \
-DUIM_UIDATADIR="\"${xmluidir}\"" \
$(helper_defs) -I$(top_srcdir) -I$(top_builddir)
-
-uim_toolbar_applet_gnome3_CFLAGS = @GTK3_CFLAGS@ @GNOME3_APPLET_CFLAGS@
+libuim_toolbar_applet_gnome3_la_LDFLAGS = \
+ -module -avoid-version
-uim_toolbar_applet_gnome3_SOURCES = applet-gnome3.c \
+libuim_toolbar_applet_gnome3_la_CFLAGS = @GTK3_CFLAGS@ @GNOME3_APPLET_CFLAGS@
+
+libuim_toolbar_applet_gnome3_la_SOURCES = applet-gnome3.c \
../../gtk2/toolbar/common-gtk.c
-appletdir = $(datadir)/gnome-panel/5.0/applets
+APPLET_LOCATION = $(pkglibdir)/libuim-toolbar-applet-gnome3.so
+
+appletdir = $(LIBPANEL_APPLET_DIR)
applet_DATA = UimApplet.panel-applet
applet_in_files = $(applet_DATA:=.in)
applet_in_in_files = $(applet_in_files:=.in)
$(applet_in_files): $(applet_in_in_files) Makefile
- $(SED) s,@LIBEXECDIR@,$(libexecdir),g <$< >$@.tmp
+ $(SED) s,@APPLET_LOCATION@,$(APPLET_LOCATION),g <$< >$@.tmp
$(SED) s,@UIM_PIXMAPSDIR@,$(uim_pixmapsdir),g <$@.tmp >$@
po_files = $(wildcard $(top_srcdir)/po/*.po)
$(applet_DATA): $(applet_in_files) $(INTLTOOL_MERGE) $(po_files)
LC_ALL=C $(INTLTOOL_MERGE) -d -u -c $(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@
-servicedir = $(datadir)/dbus-1/services
-service_DATA = org.gnome.panel.applet.UimAppletFactory.service
-service_in_files = $(service_DATA:=.in)
-
-$(service_DATA): $(service_in_files) Makefile
- sed s,@LIBEXECDIR@,$(libexecdir),g <$< >$@
-
DISTCLEANFILES = UimApplet.panel-applet.in UimApplet.panel-applet \
- UimApplet.panel-applet.in.tmp \
- org.gnome.panel.applet.UimAppletFactory.service
+ UimApplet.panel-applet.in.tmp
endif
if GTK3
--- a/gtk3/toolbar/UimApplet.panel-applet.in.in
+++ b/gtk3/toolbar/UimApplet.panel-applet.in.in
@@ -1,6 +1,7 @@
[Applet Factory]
Id=UimAppletFactory
-Location=@LIBEXECDIR@/uim-toolbar-applet-gnome3
+InProcess=true
+Location=@APPLET_LOCATION@
_Name=uim Applet Factory
_Description=uim applet factory
--- a/gtk3/toolbar/applet-gnome3.c
+++ b/gtk3/toolbar/applet-gnome3.c
@@ -168,7 +168,7 @@
-PANEL_APPLET_OUT_PROCESS_FACTORY("UimAppletFactory",
+PANEL_APPLET_IN_PROCESS_FACTORY("UimAppletFactory",
PANEL_TYPE_APPLET,
(PanelAppletFactoryCallback)uim_applet_new,
NULL)
--- a/gtk3/toolbar/org.gnome.panel.applet.UimAppletFactory.service.in
+++ /dev/null
@@ -1,3 +0,0 @@
-[D-BUS Service]
-Name=org.gnome.panel.applet.UimAppletFactory
-Exec=@LIBEXECDIR@/uim-toolbar-applet-gnome3
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: uim
Source-Version: 1:1.8.6+gh20161003.0.d63dadd-2.1
We believe that the bug you reported is fixed in the latest version of
uim, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 866...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dmitry Shachnev <mity...@debian.org> (supplier of updated uim package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 09 Jul 2017 16:42:53 +0300
Source: uim
Binary: uim-common uim libuim8 libuim-scm0 libuim-custom2 libuim-data
libuim-plugins libuim-dev uim-gtk2.0 uim-gtk3 uim-qt uim-qt5 uim-xim
uim-applet-gnome plasma-widget-uim uim-dict-gtk uim-dict-gtk3 uim-fep uim-utils
uim-anthy uim-skk uim-m17nlib uim-el uim-byeoru uim-latin uim-pinyin uim-tcode
uim-viqr uim-ipa-x-sampa uim-look
Architecture: source
Version: 1:1.8.6+gh20161003.0.d63dadd-2.1
Distribution: unstable
Urgency: medium
Maintainer: HIGUCHI Daisuke (VDR dai) <d...@debian.org>
Changed-By: Dmitry Shachnev <mity...@debian.org>
Description:
libuim-custom2 - Universal Input Method - uim-custom API library
libuim-data - Universal Input Method - data files
libuim-dev - Universal Input Method - development files
libuim-plugins - Universal Input Method - plugin files
libuim-scm0 - Universal Input Method - uim-scm API library
libuim8 - Universal Input Method - uim library
plasma-widget-uim - Universal Input Method - KDE Plasma widget
uim - Universal Input Method - metapackage
uim-anthy - Universal Input Method - Anthy plugin
uim-applet-gnome - Universal Input Method - GNOME applet
uim-byeoru - Universal Input Method - byeoru hangul input support
uim-common - Universal Input Method - common files
uim-dict-gtk - Universal Input Method - GTK+2.x Japanese dictionary tool
uim-dict-gtk3 - Universal Input Method - GTK+3.x Japanese dictionary tool
uim-el - Universal Input Method - Emacs front end
uim-fep - Universal Input Method - front end processor
uim-gtk2.0 - Universal Input Method - GTK+2.x front end
uim-gtk3 - Universal Input Method - GTK+3.x front end
uim-ipa-x-sampa - Universal Input Method - X-SAMPA IPA input support
uim-latin - Universal Input Method - Latin script input support
uim-look - Universal Input Method - Dictionary-based completion input suppor
uim-m17nlib - Universal Input Method - m17nlib plugin
uim-pinyin - Universal Input Method - pinyin input support
uim-qt - Universal Input Method - Qt 4.x front end
uim-qt5 - Universal Input Method - Qt 5.x front end
uim-skk - Universal Input Method - SKK plugin
uim-tcode - Universal Input Method - T-Code input support
uim-utils - Universal Input Method - utilities
uim-viqr - Universal Input Method - Vietnamese Quoted-Readable support
uim-xim - Universal Input Method - XIM compatibility interface
Closes: 866388
Changes:
uim (1:1.8.6+gh20161003.0.d63dadd-2.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Fix build with gnome-panel 3.24 (closes: #866388).
- Backport two upstream commits to use the in-process panel applet
(panel_applet_inprocess.patch).
- Update debian/uim-applet-gnome.install.
- Bump libpanel-applet-dev build-dependency to 3.22.
Checksums-Sha1:
7747cf0db93732aef1bdeb888abaa6197ed27874 4035
uim_1.8.6+gh20161003.0.d63dadd-2.1.dsc
b9f8f963220ad151becb8bda0958350f454a3960 37864
uim_1.8.6+gh20161003.0.d63dadd-2.1.debian.tar.xz
f7935cee92b56045c03836470e9c96b0762eaa90 15086
uim_1.8.6+gh20161003.0.d63dadd-2.1_source.buildinfo
Checksums-Sha256:
7ad5aa8277cc022c0339f80310a56353f8994dc8c4a1832da1a6f878ac4029ef 4035
uim_1.8.6+gh20161003.0.d63dadd-2.1.dsc
dcb22e33d1891932da6a3d8a35fee758535d080fda78312afd79d201ad5fb31d 37864
uim_1.8.6+gh20161003.0.d63dadd-2.1.debian.tar.xz
97a4121e51ad4934ca8ee2c3d94a8a985c5f98ca2e1855afef8ecc5d33fe2833 15086
uim_1.8.6+gh20161003.0.d63dadd-2.1_source.buildinfo
Files:
5ae446010b21ad3aff0b5ff7a13ad1c5 4035 libs optional
uim_1.8.6+gh20161003.0.d63dadd-2.1.dsc
abc55b202cc62c91a408dac6e746062b 37864 libs optional
uim_1.8.6+gh20161003.0.d63dadd-2.1.debian.tar.xz
2b2b18eae0131d2b7b401b6b23848273 15086 libs optional
uim_1.8.6+gh20161003.0.d63dadd-2.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEbEPcK+5mZmLK5jNU1v5xA2P4XdMFAlliM2IACgkQ1v5xA2P4
XdMCQRAAjAmmdcXwvyr0cPDlIYmNtbpRFJgA5eOCirwTITcKo9PWQmno03thW4be
c4dSfYfVDZXph+ax2/1voEzHeaMVbR/ETXvqu3zkhrIefPy1otqP+Ke1H4nfuKBC
6qGyUk+Kkjk6E94gQr77vmwyA5VblRrXY7sW/65vIFF+wiyPU6EPWmds7VPO5muH
wZ6V9ojK3S4urgB7H+js1gvJ+ZcpjL1mWtTr1TnCBNBLl5la+EzLzkMSqtQ5oO+v
HUXidCZssxgJ4xf+fHWKpl5Wy952oACRFFIiV+KoTPZCm7E743D6uB8Awob9eybx
zIHltRQ4N+N87Rc53Gt5fWZjGycgCAjy4YMQDjiJ9sO93hzMEW9iNXxtEiKEbnsV
Rfmog8zK5zK73O9qPhgOPUHsrdN+wuajYOMaNi9UzAAvJ8uBShEbJVYns69xuJ8w
2r5ErdSdB2IBEvM66hPjqsSTmm90yQA2jc42dWqAQA477PzFw/zDNvtAYffVVvd+
fYiqsJQCBAn3isu7ULuFbxXrCiVVEcZatNvgQUPtGmXGFrpvHila6+w1j/QvwlQl
80n8wZgGnmn2zMZa8BfcZWhWvbIEMgZ6s6A+YIjKmu3ytH8+wj8ljiBy9qAw8GXV
S9VmlIple2KQfmq6pfYgNlVh0HNAk81c0Yyf6K0xHAaj17vnMAs=
=VYb8
-----END PGP SIGNATURE-----
--- End Message ---
