On 07/11/17 14:48, Adrian Bunk wrote: > On Tue, Nov 07, 2017 at 02:46:59PM +0100, Christian Blum wrote: >> Package: ppp >> Version: 2.4.7-1+4 >> Severity: serious >> Tags: patch >> Justification: fails to build from source (but built successfully in the >> past) >> >> Dear Maintainer, >> >> the rules file contains a problem that keeps ppp from compiling. This patch >> fixes the problem. >> >> >> --- debian/rules.ORIG 2017-11-07 14:43:08.026945955 +0100 >> +++ debian/rules 2017-11-07 14:43:20.174879455 +0100 >> @@ -156,7 +156,7 @@ >> # the build fails if there are any discrepancies in the symbols file in >> order >> # to catch ABI changes. >> override_dh_makeshlibs: >> - dh_makeshlibs --package=ppp -- -c2 -edebian/ppp/usr/sbin/pppd -V >> + dh_makeshlibs --package=ppp -- -c2 -edebian/ppp/usr/sbin/pppd --version >> dh_makeshlibs --no-package=ppp >> ... > > -V looks correct, and it works everywhere else: > https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ppp.html > > What is the exact error message you get?
Hi Christian, Adrian, The -V comes after the '--' separator and thus should be an argument to dpkg-gensymbols. Its meaning there is, according to the man page: "Enable verbose mode. The generated symbols file contains deprecated symbols as comments. Furthermore in template mode, pattern symbols are followed by comments listing real symbols that have matched the pattern." This is probably unnecessary for pppd in the general case but I don't think it should do any harm. Replacing this with --version is definitely not correct, however: that should make dpkg-gensymbols show its version number and exit without producing any output. That would cause the build to ignore changes in the symbols, which is exactly what this is there to protect against. Please let me know if this is causing unexpected build failures and I'll try to help. Best regards, Chris -- Chris Boot bo...@boo.tc
