> It so happens that I was having a brief look already :)

Great, thanks!

> The hang occurs inside the above while loop. Notice that the value
> loaded into "label" inside the loop never changes and this is the only
> variable the loop condition depends on. Therefore, if the initial loop
> condition is true, the program will loop forever.

So I see.  Perhaps the intent was to update mpls after bumping ip_offset.

> Firstly, the order of fields in a bitfield is ABI dependent so any
> architecture could legitimately rearrange all the fields giving wrong
> results. I also don't really understand what the programmer intended to
> happen when invoking ntohl on a bitfield.

Excellent question, though it's ironic that these failures are occurring
on architectures for which ntohl is a no-op. ;-) Please note that the
autobuilders for m68k and powerpcspe, the (non-release) big-endian
architectures on which this ndpi version nominally built fine, both run
with nocheck in DEB_BUILD_OPTIONS, so we shouldn't read too much into
those successes.

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu

Reply via email to