Your message dated Sun, 07 Jan 2018 20:57:42 +0000
with message-id <e1eyi0k-000e6m...@fasolo.debian.org>
and subject line Bug#883466: fixed in singularity-container 2.4.2-2
has caused the Debian Bug report #883466,
regarding singularity-container: FTBFS on mips*
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
883466: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883466
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: singularity-container
Version: 2.4-1
Severity: serious
Tags: sid buster patch

Hi,

singularity-container FTBFS on mips* with the error:
> In file included from mnt.c:41:0:
> ../../../../../src/util/setns.h:46:4: error: #error Please determine the 
> syscall number for setns on your architecture
>  #  error Please determine the syscall number for setns on your architecture
>     ^~~~~

This error happens because the setns.h header requires a __NR_setns
define for each architecture. However, this define is never used in the
case where glibc provides a setns function (as is the case for all
architectures in buster).

The attached "setns-syscall-nr.patch" patch fixes this by moving the
__NR_setns ifdefs into setns.c so it is only used in the case where
setns is not provided by libc.

After doing this, the package FTBFS again in a different way:
> util/signal.c:39:5: error: 'SIGSTKFLT' undeclared here (not in a function); 
> did you mean 'SIGSTKSZ'?
>      SIGSTKFLT,
>      ^~~~~~~~~
>      SIGSTKSZ

The SIGSTKFLT signal is not defined on mips (and a few other
architectures). This is fixed by the "maybe-sigstkflt.patch" patch which
only adds this signal to the all_signals list if it is defined.

Thanks,
James
--- a/src/util/signal.c
+++ b/src/util/signal.c
@@ -36,7 +36,9 @@ static const int all_signals[] = {
     SIGPIPE,
     SIGALRM,
     SIGTERM,
+#ifdef SIGSTKFLT
     SIGSTKFLT,
+#endif
     SIGCHLD,
     SIGCONT,
     SIGTSTP,
--- a/src/util/setns.c
+++ b/src/util/setns.c
@@ -21,7 +21,29 @@
 
 #if defined (NO_SETNS) && defined (SETNS_SYSCALL)
 
-#include "util/setns.h"
+#ifndef __NR_setns
+#  if defined (__x86_64__)
+#    define __NR_setns 308
+#  elif defined (__i386__)
+#    define __NR_setns 346
+#  elif defined (__alpha__)
+#    define __NR_setns 501
+#  elif defined (__arm__)
+#    define __NR_setns 375
+#  elif defined (__aarch64__)
+#    define __NR_setns 375
+#  elif defined (__ia64__)
+#    define __NR_setns 1330
+#  elif defined (__sparc__)
+#    define __NR_setns 337
+#  elif defined (__powerpc__)
+#    define __NR_setns 350
+#  elif defined (__s390__)
+#    define __NR_setns 339
+#  else
+#    error Please determine the syscall number for setns on your architecture
+#  endif
+#endif
 
 int setns(int fd, int nstype) {
     return syscall(__NR_setns, fd, nstype);
--- a/src/util/setns.h
+++ b/src/util/setns.h
@@ -16,34 +16,6 @@
 #ifndef __SETNS_H_
 #define __SETNS_H_
 
-#ifndef __NR_setns
-#  if defined (__x86_64__)
-#    define __NR_setns 308
-#  elif defined (__i386__)
-#    define __NR_setns 346
-#  elif defined (__alpha__)
-#    define __NR_setns 501
-#  elif defined (__arm__)
-#    define __NR_setns 375
-#  elif defined (__aarch64__)
-#    define __NR_setns 375
-#  elif defined (__ia64__)
-#    define __NR_setns 1330
-#  elif defined (__sparc__)
-#    define __NR_setns 337
-#  elif defined (__powerpc__)
-#    define __NR_setns 350
-#  elif defined (__s390__)
-#    define __NR_setns 339
-#  endif
-#endif
-
-#ifdef __NR_setns
-
 extern int setns(int fd, int nstype);
 
-#else /* !__NR_setns */
-#  error Please determine the syscall number for setns on your architecture
-#endif
-
 #endif /* __SETNS_H_ */

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message ---
Source: singularity-container
Source-Version: 2.4.2-2

We believe that the bug you reported is fixed in the latest version of
singularity-container, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 883...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mehdi Dogguy <me...@debian.org> (supplier of updated singularity-container 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 07 Jan 2018 20:56:09 +0100
Source: singularity-container
Binary: singularity-container
Architecture: source amd64
Version: 2.4.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian HPC Team <debian-...@lists.debian.org>
Changed-By: Mehdi Dogguy <me...@debian.org>
Description:
 singularity-container - container platform focused on supporting "Mobility of 
Compute"
Closes: 883466
Changes:
 singularity-container (2.4.2-2) unstable; urgency=medium
 .
   * Make package build reproducible again by making sure content of
     $HOME doesn't end up in manpages.
   * Fix FTBFS on mips* architectures (Closes: #883466). Thanks to
     James Cowgill for the patch!
   * Set "Debian HPC team" in the maintainer field.
   * Migrate Git repo on Salsa and update Vcs-* fields accordingly
   * Run wrap-and-sort
Checksums-Sha1:
 181cb55bb56c80e8fdb0b3cdd214a876005491f1 2131 singularity-container_2.4.2-2.dsc
 7814634a4963083da15b41be0603452f6007dd03 7640 
singularity-container_2.4.2-2.debian.tar.xz
 2b9aa6830323d300842d595684614c5a30ddd53a 756864 
singularity-container-dbgsym_2.4.2-2_amd64.deb
 fc6ea395566393a98a9400cf09ca6a73a8c5908b 6366 
singularity-container_2.4.2-2_amd64.buildinfo
 f1916f7de576e20c1a3258004078bab72b7cb77d 311900 
singularity-container_2.4.2-2_amd64.deb
Checksums-Sha256:
 a418b609d64084a7b036a0d7dde7489407d7c46ef9aa569c28bd639d2f75259a 2131 
singularity-container_2.4.2-2.dsc
 61ef218d3c6233854b39db04e2f7a4e4fd07ad609e81b06b99514189844d4ae5 7640 
singularity-container_2.4.2-2.debian.tar.xz
 0e0f0dfaa39d230ac4b251b0f0bd90faa503dd0b25f90921037991728a822680 756864 
singularity-container-dbgsym_2.4.2-2_amd64.deb
 e18a3269d295f1683cabfc036691014679db0f78424a6fac9eb35c87322ff58f 6366 
singularity-container_2.4.2-2_amd64.buildinfo
 b912a8a79d9a0ff5ae61b91277a1f3e74a715c424c4116ffa61b7d733775c81f 311900 
singularity-container_2.4.2-2_amd64.deb
Files:
 4de9bed5927afa6b9aa8611b0cd6d44f 2131 admin optional 
singularity-container_2.4.2-2.dsc
 a58b0ab9e42379e20a233b1578de4231 7640 admin optional 
singularity-container_2.4.2-2.debian.tar.xz
 410ee2fd04224299625bb1cbad06887a 756864 debug optional 
singularity-container-dbgsym_2.4.2-2_amd64.deb
 f2ed580960e5560257df0d7fc0125a09 6366 admin optional 
singularity-container_2.4.2-2_amd64.buildinfo
 0a950e46895975d0e6da742ea4d6db39 311900 admin optional 
singularity-container_2.4.2-2_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEEvYOKK6r540CL2WRoM74aCowu2P8FAlpSfKcRHG1laGRpQGRl
Ymlhbi5vcmcACgkQM74aCowu2P8/qhAA2/OcDMkE1swFUTsKCwPi88xTO2gfENN5
Uvjjuty9FKGkFiXJif3I6QqSSFGboDhHyEiAXK8qX9/AAm9wkMWJipgnIVki+ZzU
a+9cjaaQgALDnpvSmzRf16mI/jEr5sZ7J4OqaZ8NmMxaMyuVeROHQAT0WU1wn1fb
joXl2x+55mb6Tgs9hEgyIgXqh9xQa6G531nPZ12jbCj+ktzWa8NNn2SG+srHjSLL
cnRHFpuBqOftZ7cq0PqNeJluYGYl9R/ThLhUHfYoLypETf2nkrwU5nmzhFdIIB8d
ubbia5zCy8qSYX+g4jKs4DaeoFnsUuRLniRQEoqyLtWupGI5GNIUZ8/fe9V5UwOT
523egXfHMBbZ+l62dHbAGg0Zu/nTwTzEQn/9P5DUGSUR2OQjb/u5ZjmV0B7jq4+7
fP54UUl9UQ8kTlS7Gr4Xyl5gONsOl5sbsDeqLGFP7vyTMDSuJnRqCh6uiRAY31x6
ERPKQcgxlcyL81CE6B8LwNJRLruQn7ywqkuj98oZ+Rc2FdaJodistDkQrlVmzY+B
TrMifSFFxTI6jGW/rtVs+Bx1/GcR7DdO+Efyf6qtwx0rpWb5pn5SZqRdviebJ/te
e8vSgZtl5Xb9T7TgEpzMf7AdRw61rwQce1WX1ISFoNOsz/RIW+JIsGO8ZLeAoz6o
rQERS2mUTz4=
=4yxK
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to