Source: cpputest
Version: 3.8-5
Severity: serious
Tags: patch

Hi,

The cpputest package FTBFS with debhelper/11.1 as it has an
empty build target.  This is caused by debhelper had a bug in its
handling of "explicitly defined rules targets" that has now been
fixed.

Previously, this happened to work because dpkg-buildpackage would
invoke "debian/rules build" (which would be a no-op) followed by
"fakeroot debian/rules binary".  During the binary target, dh's
suboptimal handling would run the build commands.


The solution is trivial but less pretty; explicitly define "build"
with the same content as the "%:" target (or rename the "build" folder
and drop the ".PHONY" target).  I have attached a patch for this.

(There is also a bonus patch for a missing "set -e")


More details can be found in:
 * #886901 comment #35
 * #887688 comment #37
 * #880840

Apologies for the inconvenience.

Thanks,
~Niels
>From 7a82e9dd46d8ca621f2b76636497b82cc19cc8df Mon Sep 17 00:00:00 2001
From: Niels Thykier <ni...@thykier.net>
Date: Sat, 27 Jan 2018 15:31:16 +0000
Subject: [PATCH] Avoid empty build target

The dh sequencer as of debhelper/11.1 is stricter with this in order
to solve #880840 (where debhelper would fail to handle such targets
correctly).

Signed-off-by: Niels Thykier <ni...@thykier.net>
---
 debian/rules | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/debian/rules b/debian/rules
index e62f756..ee8ed94 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,6 +3,12 @@
 %:
        dh $@ --with autoreconf
 
+# The build target must not be empty.  Sadly because of how make
+# works, we have do duplicate the target in this case.
+build:
+       dh $@ --with autoreconf
+
+
 override_dh_auto_configure:
        dh_auto_configure -- --disable-silent-rules
 
-- 
2.15.1

Reply via email to