Daniel Schepler wrote:
> Package: greasemonkey
> Version: 0.6.4-3
> Severity: serious
>
> From my pbuilder build log:
>
> ...
>  debian/rules build
> dh_testdir
> dh_testroot
> dh_testroot: You must run this as root (or use fakeroot).
> make: *** [clean] Error 1
>
> You are not allowed to do anything in the build target which might require 
> root access (or even fakeroot access).
Perhaps it's just my interpretation, but policy seems to conflict with
itself regarding this problem.

(1) The build target must not do anything that might require root privilege.
(2) The build target may need to run the clean target first - see below
(3) The clean target may need to be invoked as root if binary has been
invoked since the last clean, or if build has been invoked as root
(since build may create directories, for example).

The package reflects (2) and (3). I suppose removing dh_testroot from
the clean rule would solve this, but it is quite handy to make sure the
build fails as soon as possible and to notify the builder that root
access is probably required.

The solution is of course quite trivial for this particular package. The
build target depends on the clean target only because it ensures that
making the binary target will build correctly without any stale files
from a previous build. Moving the dependency to the binary target
preserves this behavior without requiring root access during the build.
I have prepared an updated package to fix this bug and will send it to
my sponsor soon.

I am interested in a clarification of what is intended by policy in this
case.

Thanks!
Michael Spang


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to