Your message dated Mon, 2 Apr 2018 23:32:05 +0200
with message-id <5ec559d8-1b79-52f4-421e-f60eca6cd...@debian.org>
and subject line Looks like it's "only" a bad behavior
has caused the Debian Bug report #890515,
regarding Crashes when used with Python 3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
890515: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890515
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: blockdiag
Version: 1.5.3+dfsg-5.1
Severity: grave
Tags: patch

Hi,

Trying to build nova 17.0.0~rc1's sphinx doc with python3-blockdiag, I get:

  File "/usr/lib/python3/dist-packages/blockdiag/utils/compat.py", line 39, in 
<lambda>
    return lambda stream, *args: getreader(encoding)(stream.buffer, *args)
AttributeError: '_io.BufferedRandom' object has no attribute 'buffer'

Indeed, the upstream code fix for Python 3 for blockdiag is simply wrong.
There's no such thing as _io.BufferedRandom.buffer. The patch should go like
this:

--- /usr/lib/python3/dist-packages/blockdiag/utils/compat.py.orig       
2018-02-15 13:39:46.846727862 +0000
+++ /usr/lib/python3/dist-packages/blockdiag/utils/compat.py    2018-02-15 
13:11:21.125447664 +0000
@@ -36,7 +36,7 @@
     getreader = codecs.getreader
 
     def py3_getreader(encoding):
-        return lambda stream, *args: getreader(encoding)(stream.buffer, *args)
+        return lambda stream, *args: getreader(encoding)(stream, *args)
 
     codecs.getreader = py3_getreader
 

--- End Message ---
--- Begin Message ---
Hi,

Looks like blockdaig is monkey patching codecs.getreader, which is the
cause of the failure. See the patch written for Nova:

https://git.openstack.org/cgit/openstack/nova/commit/?id=b862f6ff35d1611d0d63623a6254fc889012bfb9

I would suggest contacting upstream and make this stop if possible,
because that will be the cause of other surprises.

In the mean time, this bug can be closed.

Cheers,

Thomas Goirand (zigo)

--- End Message ---

Reply via email to