B0;115;0cOn Fri, May 04, 2018 at 02:21:41PM +0200, Moritz Muehlenhoff wrote: > On Wed, May 02, 2018 at 12:02:03PM +0200, Moritz Muehlenhoff wrote: > > Hi Jörg, > > > > On Mon, Apr 30, 2018 at 09:59:11PM +0200, Jörg Frings-Fürst wrote: > > > > > > for the liboinig transition I testing the build of hhvm again libonig > > > 6.8.1-1. > > > > > > The build fails with > > > > > > [quote] > > > In file included from /build/hhvm-3.21.0+dfsg/hphp/runtime/base/program- > > > functions.cpp:117:0: > > > /usr/include/oniguruma.h:347:1: error: 'UChar' does not name a type; did > > > you > > > mean 'char'? > > > UChar* onigenc_strdup P_((OnigEncoding enc, const UChar* s, const UChar* > > > end)); > > > ^~~~~ > > > char > > > > But that's a problem in the lobonig headers? > > hphp/runtime/base/program-functions.cpp:117 simply does a > > > > #include <oniguruma.h> > > Actually this needs some changes on the HHVM end, found a fix.
The patch for HHVM is still needed to fix that the regex struc was moved to a private header. It also adds a workaround to address a bug in Oniguruma, though: HHVM uses ONIG_ESCAPE_UCHAR_COLLISION and that is broken in 6.8.0/6.8.1 (see the comment in https://github.com/facebook/hhvm/commit/0bbbf67adc2643d04353cf2bdda2e1aa7c92d36f) Cheers, Moritz
