Santiago, On 27/08/18 16:00, Santiago Vila wrote:
>> This is a known problem when running the autopkgtests, becasue the >> installed package starts the daemon and then the tests fail when trying >> to use the same port; but this is not a FTBFS: the build daemons do not >> fail to build from source. I think you should lower the severity. > > Tincho, if we go that route we would be applying a definition for FTBFS > which would be different from everybody else. > A FTBFS could be defined as a non-zero exit status from > dpkg-buildpackage. If you include the test suite as part of the build, > then a failure in the test suite will naturally mean a FTBFS bug, for > all purposes. Yes, but this is not what is happening: the build only fails if prometheus is already running in the machine, which is the case for autopkgtest, but not for a normal build. I plan to fix this, but I need to find a general fix for all go packages that include a daemon. Look at the buildd logs, there are no failures (except i386, which is known not to work): https://buildd.debian.org/status/package.php?p=prometheus > If, as you explain, the tests are not suitable to be run after > dh_auto_build, then it follows that they should be disabled from the > package build, because we don't want dpkg-buildpackage to exit with > error. In such case, just an empty debian/rules target like this: If you run dpkg-buildpackage in a clean chroot, it does not fail: I have just checked again; so this bug is not RC. There are a few other go packages that fail autopkgtests for the exact same reason, please do not open FTBFS bugs without actually trying to build the package. -- Martín Ferrari (Tincho)