On Thursday, 4 October 2018 1:01:12 AM AEST Bernhard Übelacker wrote:
> Hello Dimitry,
> I saw that a version 3.3-1 got uploaded so I had a look at the build
> logs,

Thank you for checking build logs.


> but found some of them failing with this error:
> 
> /<<PKGBUILDDIR>>/libgnucash/engine/gnc-timezone.cpp:55:22: error:
> operator '!' has no right operand
>  #if ! WORDS_BIGENDIAN
>                       ^
> 
> I fear this happens because just the part of my patch in debian/rules
> made it into this release.
> 
> Unfortunately for this to work the tiny second change in the upstream
> file common/config.h.cmake.in is also important:
> 
> -#cmakedefine WORDS_BIGENDIAN
> +#cmakedefine WORDS_BIGENDIAN 1

I know, I know - I've noticed it too and committed the patch already:

  https://salsa.debian.org/debian/gnucash/commit/e0c54914

It was entirely my fault to miss that but I'm not uploading the fix yet due 
to unrelated FTBFS on i386 that I hope to address when upstream fixes it:

  https://bugs.gnucash.org/show_bug.cgi?id=796878

-- 
Regards,
 Dmitry Smirnov.

---

If liberty means anything at all, it means the right to tell people what
they do not want to hear.
        -- George Orwell

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to