Your message dated Fri, 11 Jan 2019 10:20:52 +0000
with message-id <[email protected]>
and subject line Bug#918936: fixed in fasm 1.73.06-2
has caused the Debian Bug report #918936,
regarding fasm: Does not trap for errors in debian/rules
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
918936: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918936
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:fasm
Version: 1.73.06-1
Severity: serious
Tags: patch
Dear maintainer:
Commands in a Makefile should be chained with "&&" so that the first
thing which fails makes the whole process to stop.
This is Policy 4.6, "error trapping in makefiles", and it's usually considered
a serious issue:
https://www.debian.org/doc/debian-policy/ch-source.html#error-trapping-in-makefiles
Proposed patch below.
Unfortunately, the patch will not make the package to build again and
it needs to be "bootstrapped" again (my theory is that the package was misbuilt
the last time because of this, but I'm not completely sure).
Would not be possible to build the program using the standard assembler?
I would do that if possible, that way we could eliminate the
build-dependency on itself.
Thanks.
--- a/debian/rules
+++ b/debian/rules
@@ -8,7 +8,7 @@ include /usr/share/dpkg/default.mk
override_dh_install:
mkdir -p debian/tmp
- (cd source/libc; fasm fasm.asm; gcc $(CFLAGS) $(CPPFLAGS) $(LDFLAGS)
-m32 fasm.o -o fasm)
+ cd source/libc && fasm fasm.asm && gcc $(CFLAGS) $(CPPFLAGS) $(LDFLAGS)
-m32 fasm.o -o fasm
override_dh_clean:
dh_clean
--- End Message ---
--- Begin Message ---
Source: fasm
Source-Version: 1.73.06-2
We believe that the bug you reported is fixed in the latest version of
fasm, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Tomasz Buchert <[email protected]> (supplier of updated fasm package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 11 Jan 2019 10:27:58 +0100
Source: fasm
Binary: fasm
Architecture: source
Version: 1.73.06-2
Distribution: unstable
Urgency: medium
Maintainer: Tomasz Buchert <[email protected]>
Changed-By: Tomasz Buchert <[email protected]>
Description:
fasm - fast assembler for the x86 and x86-64 architectures
Closes: 918931 918936
Changes:
fasm (1.73.06-2) unstable; urgency=medium
.
* reboostrap the whole package (Closes: #918931)
* join commands in debian/rules with && (Closes: #918936)
Checksums-Sha1:
8691c1bbf6dcbe384625e7d69c26157b690ff51b 1894 fasm_1.73.06-2.dsc
6e23571d4068b736eab8e8ed177c65ca2feea953 3752 fasm_1.73.06-2.debian.tar.xz
5b6b8f34f7b1652f902335a3d60944ce4a634881 6452 fasm_1.73.06-2_amd64.buildinfo
Checksums-Sha256:
cf841fd2cd271db3aee8e69ba39876f005c6202cd692133c4f210e3a227b4491 1894
fasm_1.73.06-2.dsc
23228a8da43a6261f06c69c587dd36d0c279a3942ea16a36b714f3a58c24be2a 3752
fasm_1.73.06-2.debian.tar.xz
f074a6ec330b0c54f917001a270208cc66bc9ca15f9bae3a59c54a7dbc138927 6452
fasm_1.73.06-2_amd64.buildinfo
Files:
fd320d5abdc53a9af8d78637bf1e2ad1 1894 devel optional fasm_1.73.06-2.dsc
e728b5eb814fd9705e3d73f5328b53cd 3752 devel optional
fasm_1.73.06-2.debian.tar.xz
a46711b8a20db69b3ba861b66d0ab8e4 6452 devel optional
fasm_1.73.06-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCgAwFiEEzmRl4OZ9N8ZVV+eKAK40x+rZ6zgFAlw4YisSHHRvbWFzekBk
ZWJpYW4ub3JnAAoJEACuNMfq2es4+oAP/jPGN+tIP23KaG0RDnUA98BMOv8oG6Dt
6EMM7CjHK8WcFCDbpni7+rsFQgFTi7PC6+vRsZ9CJZGooGUxcDdSCGHOsxZ2hLzy
n7v+umKMkiSyHEO9bCV9Kh90n0QXhnjO/epBAPFrQr7ArJ7vokH+XRYDBQbjNrAz
XHs8Yc72TZZA2ZtCWEyVRvvmXyiGLiTqMj+MWsTkQGBe7Sr/9uNUEKSPZhIPUIo7
PAuv1CRXL5jztUD48knQEuSxMjfkULGWrOAWV74xqIQNbydkVLFHueo6to44G8uL
qJmwslc9yw5tsRdqJgmXPVAxaZTAnK1zSqR9Y3HInyA1paqIfM2AyyhGsc8XUVYT
q1mR4brS51iZusmmqDrkJC8TRDQQsmc4+HuGsMKUKWIxqlyLugqHRFWA22Q65H9O
3mK9inBpDeHiGiNS2XJ900XN6sglXQ8gBcibjs+Er7ywvM060JLyHax+HguArezx
/dqOljPfR4P28Ds3m7Md4q61rQQf5rDYeY+9BU9KdkVTtCS6EGIZhB0Yw/lPGv7r
zknJIaQn5ktdiybUTMnhtjziQj3eL347v5XrhqEdNBW7DuDr6wflzlN/PW8KwKW3
rfRGy4DloJpDtga0l8ebiUi9wml2mugvT8ddO9GC3o92/Rj3g2eyd3a0sQgl7myt
3Mj+2+D/3Ifo
=+vpy
-----END PGP SIGNATURE-----
--- End Message ---
