Le mardi 22 janvier 2019 à 01:57:22+0100, Pierre-Elliott Bécue a écrit :
> Le lundi 21 janvier 2019 à 14:37:36+0100, Thomas Goirand a écrit :
> > Hi,
> > 
> > Would you have any idea how to resolve this Debian bug?
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919196
> > 
> > I'm not sure, but to me, it looks like the unit tests are running in
> > loop in the ::handshake() method.
> 
> The handshake fails, because gnutls doesn't accept the security level
> offered by the handshake.
> 
> It seems to me the issue is in the next test: t->send is called, and
> send is defined as a looping function until the decrypted content is
> received. As the handshake previously failed, t->send waits forever.
> 
> I guess the tests should have a timeout method.
> 
> Anyway, increasing the security of the handshake would make it work and
> hence the current issue should be gone.

I found out that a new upstream release includes fixes the security
issue I mentioned before. Attempting to build this release works fine
and the tests are passing without hanging.

I'm not certain whether the fix is due to the addition of
'gnutls_certificate_set_x509_system_trust( m_credentials );' to
tlsgnutlsclient.cpp or to the changes made to
'gnutls_priority_set_direct' in tlsgnutls{server,client}anon.cpp.

This looks good to me.

Vincent, I made a NMU branch which is just a fast-forward of master on
the salsa repo[0]. The branch name is 1.0.22-0.1

If you agree, I shall do an upload. Otherwise I'll let you taking care
of it.

Best regards,

[0] https://salsa.debian.org/debian/gloox/commits/1.0.22-0.1

-- 
Pierre-Elliott Bécue
GPG: 9AE0 4D98 6400 E3B6 7528  F493 0D44 2664 1949 74E2
It's far easier to fight for one's principles than to live up to them.

Attachment: signature.asc
Description: PGP signature

Reply via email to