found 919296 git/1:2.20.1-1
tags 919296 + patch pending
quit
Hi Dmitry,
Dmitry Bogatov wrote:
> [2019-01-16 14:49] Dmitry Bogatov <kact...@debian.org>
>> So, should I propose you patch (in 7 days), that merges
>> bin:git-daemon-run into bin:git-daemon, would you be able to review
>> and apply/upload it before hard freeze?
>
> Probably, even better would be to merge `git-daemon-run' and
> `git-daemon-sysvinit'. What do you think?
For "buster", I prefer a minimal fix within the framework of the
current packages, along the lines you suggested upthread:
diff --git i/debian/changelog w/debian/changelog
index ef513b2e1d..fb996c91f4 100644
--- i/debian/changelog
+++ w/debian/changelog
@@ -3,6 +3,9 @@ git (1:2.20.1-1.1) unstable; urgency=low
* package git-gui: actually Suggests: meld for mergetool support;
describe what meld is used for in package description (thx Jens
Reyer; closes: #707790).
+ * git-daemon-run: pre-create supervise directory so that postinst
+ can start the service (thx Celejar and Dmitry Bogatov; closes:
+ #919296).
-- Jonathan Nieder <jrnie...@gmail.com> Mon, 21 Jan 2019 19:36:25 -0800
diff --git i/debian/git-daemon-run.dirs w/debian/git-daemon-run.dirs
index 7847e85525..0e62ab6ac0 100644
--- i/debian/git-daemon-run.dirs
+++ w/debian/git-daemon-run.dirs
@@ -1 +1,2 @@
etc/sv/git-daemon/log
+var/lib/supervise/git-daemon
By the way, was there a change in runit precipitating this regression?
I'm wondering so that we can set up the right dependencies (e.g. a
versioned Breaks from runit) to ensure upgrades proceed smoothly.
This way, the same behavior as the previous release will persist for
users expecting it (in particular, allowing users to easily decide
which configuration will control their running daemon --- see [1] for
more context). That said, I'm happy to pursue a merge of the packages
into a git-daemon package in experimental in preparation for buster+1,
especially if there's a standard for runit service packaging that we
can follow there.
Thanks again for your help.
[1] http://bugs.debian.org/422139#121
