Source: firefox-esr
Version: 60.5.0esr-1
Severity: grave
Tags: patch
Forwarded: https://bugzilla.mozilla.org/show_bug.cgi?id=1526648
Noticed while trying to prepare the mini fix for https://bugs.debian.org/921381
/usr/bin/g++ -o Unified_cpp_certverifier0.o -c -Ibuster/stl_wrappers
-Ibuster/system_wrappers -include
/build/firefox-esr-60.5.0esr/config/gcc_hidden.h -DNDEBUG=1
-DTRIMMED=1 '-DDLL_PREFIX="lib"' '-DDLL_SUFFIX=".so"'
-DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API
-DIMPL_LIBXUL -I/build/firefox-esr-60.5.0esr/security/certverifier
-I/build/firefox-esr-60.5.0esr/build-browser/security/certverifier
-I/build/firefox-esr-60.5.0esr/security/manager/ssl
-I/build/firefox-esr-60.5.0esr/security/pkix/include
-I/build/firefox-esr-60.5.0esr/security/pkix/lib
-I/build/firefox-esr-60.5.0esr/build-browser/dist/include
-I/usr/include/nspr -I/usr/include/nss -fPIC -DMOZILLA_CLIENT -include
/build/firefox-esr-60.5.0esr/build-browser/mozilla-config.h
-Wdate-time -D_FORTIFY_SOURCE=2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2
-Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual
-Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code
-Wwrite-strings -Wno-invalid-offsetof -Wc++1z-compat -Wduplicated-cond
-Wimplicit-fallthrough -Wno-error=maybe-uninitialized
-Wno-error=deprecated-declarations -Wno-error=array-bounds
-Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2
-fno-sized-deallocation -fstack-protector-strong -Wformat
-Werror=format-security -fno-schedule-insns2 -fno-lifetime-dse
-fno-delete-null-pointer-checks -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2
-fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections
-fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g
-freorder-blocks -O2 -fomit-frame-pointer -Wall -Wextra
-Wunreachable-code -Wno-unused-parameter -MD -MP -MF
.deps/Unified_cpp_certverifier0.o.pp
/build/firefox-esr-60.5.0esr/build-browser/security/certverifier/Unified_cpp_certverifier0.cpp
In file included from
/build/firefox-esr-60.5.0esr/build-browser/security/certverifier/Unified_cpp_certverifier0.cpp:20:
/build/firefox-esr-60.5.0esr/security/certverifier/Buffer.cpp: In
function 'bool mozilla::operator==(const Buffer&, const Buffer&)':
/build/firefox-esr-60.5.0esr/security/certverifier/Buffer.cpp:14:11:
error: 'memcmp' was not declared in this scope
memcmp(a.begin(), b.begin(), a.length()) == 0);
^~~~~~
/build/firefox-esr-60.5.0esr/security/certverifier/Buffer.cpp:14:11:
note: 'memcmp' is defined in header '<cstring>'; did you forget to
'#include <cstring>'?
/build/firefox-esr-60.5.0esr/security/certverifier/Buffer.cpp:1:1:
+#include <cstring>
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/build/firefox-esr-60.5.0esr/security/certverifier/Buffer.cpp:14:11:
memcmp(a.begin(), b.begin(), a.length()) == 0);
^~~~~~
make[6]: *** [/build/firefox-esr-60.5.0esr/config/rules.mk:1056:
Unified_cpp_certverifier0.o] Error 1
make[6]: Leaving directory
'/build/firefox-esr-60.5.0esr/build-browser/security/certverifier'
make[5]: *** [/build/firefox-esr-60.5.0esr/config/recurse.mk:73:
security/certverifier/target] Error 2
make[5]: Leaving directory '/build/firefox-esr-60.5.0esr/build-browser'
make[4]: *** [/build/firefox-esr-60.5.0esr/config/recurse.mk:33:
compile] Error 2
make[4]: Leaving directory '/build/firefox-esr-60.5.0esr/build-browser'
make[3]: *** [/build/firefox-esr-60.5.0esr/config/rules.mk:442: default] Error 2
make[3]: Leaving directory '/build/firefox-esr-60.5.0esr/build-browser'
dh_auto_build: cd build-browser && make -j1
LD_LIBS=-Wl,--no-gc-sections _LEAKTEST_FILES=leaktest.py returned exit
code 2
make[2]: *** [debian/rules:227: stamps/build-browser] Error 2
make[2]: Leaving directory '/build/firefox-esr-60.5.0esr'
make[1]: *** [debian/rules:336: build-arch] Error 2
make[1]: Leaving directory '/build/firefox-esr-60.5.0esr'
make: *** [debian/rules:336: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
From: Charlemange Lasse <charlemagnela...@gmail.com>
Date: Sat, 9 Feb 2019 10:08:10 +0100
Subject: [PATCH] Fix FTBFS of security/certverifier/Buffer.cpp
---
debian/changelog | 1 +
.../Bug-1526648-Include-cstring-for-memcmp.patch | 12 ++++++++++++
debian/patches/series | 1 +
3 files changed, 14 insertions(+)
create mode 100644 debian/patches/fixes/Bug-1526648-Include-cstring-for-memcmp.patch
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,7 @@ firefox-esr (60.5.0esr-2) UNRELEASED; urgency=medium
* Fix download of esr compatible Gecko Media Plugins (widevine, openh264) by
switching to "esr" update channel (Closes: #921381, #921121, #921654)
+ * Fix FTBFS of security/certverifier/Buffer.cpp (Closes: #XXXX-TODO)
-- Charlemange Lasse <charlemagnela...@gmail.com> Sat, 09 Feb 2019 08:47:47 +0100
--- /dev/null
+++ b/debian/patches/fixes/Bug-1526648-Include-cstring-for-memcmp.patch
@@ -0,0 +1,12 @@
+diff --git a/security/certverifier/Buffer.cpp b/security/certverifier/Buffer.cpp
+index af5a42985c..386a92eaf1 100644
+--- a/security/certverifier/Buffer.cpp
++++ b/security/certverifier/Buffer.cpp
+@@ -5,6 +5,7 @@
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+ #include "Buffer.h"
++#include <cstring>
+
+ namespace mozilla {
+
diff --git a/debian/patches/series b/debian/patches/series
index 612298abcf4a32be8ca16c584e90c1c43f26f4db..f64b3f8c6a2e62b3f5ad642a3ce8508a973066c0 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -4,6 +4,7 @@ fixes/Bug-1470701-Use-run-time-page-size-when-changing-map.patch
fixes/Bug-1444834-MIPS-Stubout-MacroAssembler-speculationB.patch
fixes/Bug-1144632-fix-big-endian-Skia-builds.-r-rhunt.patch
fixes/Bug-1505608-Try-to-ensure-the-bss-section-of-the-elf.patch
+fixes/Bug-1526648-Include-cstring-for-memcmp.patch
porting/Add-xptcall-support-for-SH4-processors.patch
porting/NSS-Fix-FTBFS-on-Hurd-because-of-MAXPATHLEN.patch
porting/Make-powerpc-not-use-static-page-sizes-in-mozjemallo.patch
