Your message dated Tue, 26 Feb 2019 10:48:59 +0000 with message-id <e1gyaif-0004mg...@fasolo.debian.org> and subject line Bug#920000: fixed in nacl 20110221-6.1 has caused the Debian Bug report #920000, regarding Please build nacl with -fPIC and use CFLAGS from dpkg-buildflags to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 920000: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=920000 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: nacl Version: 20110221-6 Severity: serious Hi, Should't nacl be built with -fPIC? You also might want to follow the *FLAGS set in the environment during the build. On fedora they are doing both: https://src.fedoraproject.org/cgit/rpms/nacl.git/tree/nacl-20110221-dist-flags.patch https://src.fedoraproject.org/cgit/rpms/nacl.git/tree/nacl.spec#n56 The fact that it's missing -fPIC seems to cause troubles in libssh (#919956) See attached patch Kind regards, Laurent Bigonville -- System Information: Debian Release: buster/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), LANGUAGE=fr_BE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: SELinux: enabled - Mode: Permissive - Policy name: refpolicydiff -Nru nacl-20110221/debian/patches/0002-remove-superfluous-compiler-flags.patch nacl-20110221/debian/patches/0002-remove-superfluous-compiler-flags.patch --- nacl-20110221/debian/patches/0002-remove-superfluous-compiler-flags.patch 2018-10-22 08:10:48.000000000 +0200 +++ nacl-20110221/debian/patches/0002-remove-superfluous-compiler-flags.patch 2019-01-21 13:14:00.000000000 +0100 @@ -11,35 +11,32 @@ okcompilers/cpp | 9 +++------ 2 files changed, 6 insertions(+), 12 deletions(-) -diff --git a/okcompilers/c b/okcompilers/c -index 7218da3..2667f82 100644 --- a/okcompilers/c +++ b/okcompilers/c -@@ -1,8 +1,5 @@ +@@ -1,8 +1 @@ -gcc -m64 -O3 -fomit-frame-pointer -funroll-loops -gcc -m64 -O -fomit-frame-pointer -gcc -m64 -fomit-frame-pointer -gcc -m32 -O3 -fomit-frame-pointer -funroll-loops -gcc -m32 -O -fomit-frame-pointer -gcc -m32 -fomit-frame-pointer -+gcc -O3 -fomit-frame-pointer -funroll-loops -+gcc -O -fomit-frame-pointer -+gcc -fomit-frame-pointer - spu-gcc -mstdmain -march=cell -O3 -funroll-loops -fomit-frame-pointer -Drandom=rand -Dsrandom=srand - spu-gcc -mstdmain -march=cell -O -fomit-frame-pointer -Drandom=rand -Dsrandom=srand -diff --git a/okcompilers/cpp b/okcompilers/cpp -index d1b9ae6..35304e4 100644 +-spu-gcc -mstdmain -march=cell -O3 -funroll-loops -fomit-frame-pointer -Drandom=rand -Dsrandom=srand +-spu-gcc -mstdmain -march=cell -O -fomit-frame-pointer -Drandom=rand -Dsrandom=srand ++gcc ${CFLAGS} --- a/okcompilers/cpp +++ b/okcompilers/cpp -@@ -1,8 +1,5 @@ +@@ -1,8 +1 @@ -g++ -m64 -O3 -fomit-frame-pointer -funroll-loops -g++ -m64 -O -fomit-frame-pointer -g++ -m64 -fomit-frame-pointer -g++ -m32 -O3 -fomit-frame-pointer -funroll-loops -g++ -m32 -O -fomit-frame-pointer -g++ -m32 -fomit-frame-pointer -+g++ -O3 -fomit-frame-pointer -funroll-loops -+g++ -O -fomit-frame-pointer -+g++ -fomit-frame-pointer - spu-g++ -mstdmain -march=cell -O3 -funroll-loops -fomit-frame-pointer -Drandom=rand -Dsrandom=srand - spu-g++ -mstdmain -march=cell -O -fomit-frame-pointer -Drandom=rand -Dsrandom=srand +-spu-g++ -mstdmain -march=cell -O3 -funroll-loops -fomit-frame-pointer -Drandom=rand -Dsrandom=srand +-spu-g++ -mstdmain -march=cell -O -fomit-frame-pointer -Drandom=rand -Dsrandom=srand ++g++ ${CFLAGS} +--- a/okcompilers/archivers ++++ b/okcompilers/archivers +@@ -1,2 +1 @@ + ar +-ar -X64 diff -Nru nacl-20110221/debian/rules nacl-20110221/debian/rules --- nacl-20110221/debian/rules 2018-10-22 08:11:09.000000000 +0200 +++ nacl-20110221/debian/rules 2019-01-21 13:14:00.000000000 +0100 @@ -2,6 +2,8 @@ #export DH_VERBOSE=1 +CFLAGS = $(shell dpkg-buildflags --get CFLAGS) + override_dh_auto_build: # some quick tests for the status of /sys to help debug failures -ls /sys @@ -13,5 +15,15 @@ # DJB "makefile"-ish ./do +override_dh_auto_configure: + [ -f okcompilers/c.orig ] || cp okcompilers/c okcompilers/c.orig + [ -f okcompilers/cpp.orig ] || cp okcompilers/cpp okcompilers/cpp.orig + sed -i 's|$${CFLAGS}|$(CFLAGS) -fPIC|g' okcompilers/c okcompilers/cpp + %: dh $@ + +override_dh_auto_clean: + mv -f okcompilers/c.orig okcompilers/c || true + mv -f okcompilers/cpp.orig okcompilers/cpp || true + dh_auto_clean
--- End Message ---
--- Begin Message ---Source: nacl Source-Version: 20110221-6.1 We believe that the bug you reported is fixed in the latest version of nacl, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 920...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Hilko Bengen <ben...@debian.org> (supplier of updated nacl package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sun, 24 Feb 2019 10:54:10 +0100 Source: nacl Binary: nacl-tools libnacl-dev Architecture: source Version: 20110221-6.1 Distribution: unstable Urgency: medium Maintainer: Jan Mojžíš <jan.moj...@gmail.com> Changed-By: Hilko Bengen <ben...@debian.org> Description: libnacl-dev - High-speed software library for network communication nacl-tools - NaCl and CurveCP tools Closes: 920000 Changes: nacl (20110221-6.1) unstable; urgency=medium . * Non-maintainer upload * Update patch to remove superfluous build flags, thanks to Laurent Bigonville (Closes: #920000) Checksums-Sha1: 267586a5f7c4de41186530efa7c25f7bc3efdc66 1913 nacl_20110221-6.1.dsc 998a93d076a933fabe758c50b7c9317f95ce1635 11324 nacl_20110221-6.1.debian.tar.xz 802e477305bda5aac1a096ee19731b1a56526152 6287 nacl_20110221-6.1_source.buildinfo Checksums-Sha256: 19d79861ff5bb6b125e4aca96cbbdc281369f11cc41533d1c4c8a9b332685fdc 1913 nacl_20110221-6.1.dsc 1932ccf52388ab187be2c2f82bcbbfdfe873ef3f8e2e951ba13f601680a16810 11324 nacl_20110221-6.1.debian.tar.xz b0616b343307258a3c6794a486f1479904538e842ba3e43b35a0275b91d543b3 6287 nacl_20110221-6.1_source.buildinfo Files: 1e8b29bea94b8d85b609d805573bc706 1913 libs optional nacl_20110221-6.1.dsc e931b835a85fbcf395ea075698badfc9 11324 libs optional nacl_20110221-6.1.debian.tar.xz 5477d2d0c5d8964172e21c4219cca281 6287 libs optional nacl_20110221-6.1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJGBAEBCAAwFiEErnMQVUQqHZbPTUx4dbcQY1whOn4FAlxybIcSHGJlbmdlbkBk ZWJpYW4ub3JnAAoJEHW3EGNcITp+9wAP/A+41hGPx5NT6To+gCe3yTgACEmu4Dj3 Bb4w0O1+aZbc/v24UD7ODO936GFzWTNF+pYpcOPs3wRmx/80GWwc2imQbVvLi4Hw cMbCcwhifQccgeGzZb2x02TgRCew62AQ/EvBCwpx3k8d3vn4S4/7+J6FcqV1ZNMl BZoZKomTp4ZhVWcsZUhEAEVkSWmgOpZCheoNA2MkSrtosVXK23Hk1dHdQRkev3Dy PnJ1KuXFMsuSApLbomUbGQKhkQ2zWcwzhoIixhnyrJw3AHqk45obXm8JYIhCzkR5 fQQ49QRg4IoM3bmrgTxwFomA3zxdgl1C0SbP+ldi6JYzrAKk2aHmMG09hy+QagqS e2tJ7lqVa3ATJJwluLre1qPv3Oq0LDu70acwvgl8s9Kyp6e0HRcwVJSLFjJ+jv8w jF8sWG1XG/j1BdmBVQHyw6kGUBfJUJ12tw11vLNAFkIb62bpieoLt7VonxgGwNVw OVc70QuCd8cSGcuzpNHfE178OC8R62m/YiDdK9yYKao4adQyNnDWlFE5LoRdq1Ri Wx+71qE9+l1PYOBtwzYu5W9yGzNYl5Gnhj13lX8FGJ9M0i0FHuTs2fbvnFjcxXcT U+R/MkUFyrtyy+85Ab5RYT5bHhzvhz6HV7S7ALUzWWVmTwZU6t7VvxA7Pp3w6Tp2 RIfEPNYmCC+Q =rUtK -----END PGP SIGNATURE-----
--- End Message ---
