Your message dated Tue, 12 Mar 2019 22:51:01 +0000 with message-id <e1h3qef-0007tu...@fasolo.debian.org> and subject line Bug#924330: fixed in mailman-suite 0+20180916-7 has caused the Debian Bug report #924330, regarding postinst function django_config_site() broken to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 924330: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924330 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: mailman3-web Version: 0+20180916-6 Severity: important Hello, the postinst function django_config_site() is broken, we need to rewrite it. At the moment, it tries to read (and update) the default django site domain by using `Site.objects.all()[0]`, which seems to be wrong. If at all, then `Site.objects.last()` seems to be the default django site domain (i.e. first one that got created), but even that one seems error-prone. My impression is, that there is no reliable way for us during upgrade to determine which django site domain got created by our postinst script earlier. Therefore I propose the following: If we do a fresh install (i.e. "$2" is empty) *and* a django site domain is configured via debconf, we override the default django site domain (i.e. 'example.com') with the configured one. If we do an upgrade *and* a django site domain is set via debconf, we check if a django site domain with the same domain name already exists. If that's not the case, then we add a new django site domain. This solution occurs much more robust to me than the current implementation. Only downside is, that if the django site domain gets changed in debconf at a later point, we don't override the old django site domain but append a new one. I don't think it's a major problem though. And given that there is no reliable way to determine *which* of the existing django site domains got created by our postinst script before, I think it's an acceptable tradeoff. Cheers jonas
--- End Message ---
--- Begin Message ---Source: mailman-suite Source-Version: 0+20180916-7 We believe that the bug you reported is fixed in the latest version of mailman-suite, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 924...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Jonas Meurer <jo...@freesources.org> (supplier of updated mailman-suite package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 12 Mar 2019 13:07:32 +0100 Source: mailman-suite Architecture: source Version: 0+20180916-7 Distribution: unstable Urgency: medium Maintainer: Debian Mailman Team <pkg-mailman-hack...@lists.alioth.debian.org> Changed-By: Jonas Meurer <jo...@freesources.org> Closes: 924330 Changes: mailman-suite (0+20180916-7) unstable; urgency=medium . * d/templates, d/po/*.po, d/mailman3-web.{config,postinst}: - Remove the whole logic to configure django site domain and name via debconf. The code was very error-prone and it's better to leave this exercise to the local admin. (Closes: #924330) * d/mailman3-web-postinst: - Fix logic to run init_django at install and update_django at upgrade. Checksums-Sha1: fe94a85b434b2f2ed74344399397289d8ef6eb06 2053 mailman-suite_0+20180916-7.dsc f6dc686bea5cc9695a05c0732c7a917182973cae 25364 mailman-suite_0+20180916-7.debian.tar.xz 5d1ab143035055fa93b439950e247d3a3c55730f 5666 mailman-suite_0+20180916-7_amd64.buildinfo Checksums-Sha256: 047cc3c74cd9e15add6055c977ed416857933fee15488fa5027fb273733d4348 2053 mailman-suite_0+20180916-7.dsc 0aaf99a0ff4c4845d1882bca497788611dce9a050735992da53765dd4e6ff427 25364 mailman-suite_0+20180916-7.debian.tar.xz 6647ace2c3ba42b76c3fc4f0a24f0bc1271ed5b2357094cd9bc0e52745afbec8 5666 mailman-suite_0+20180916-7_amd64.buildinfo Files: 1bac972702ed0d54ef24789b957697d1 2053 web optional mailman-suite_0+20180916-7.dsc 71c6de864519544e7a2b8f0db7a2dd73 25364 web optional mailman-suite_0+20180916-7.debian.tar.xz 8e4d78aea76944d03ce2584d15660417 5666 web optional mailman-suite_0+20180916-7_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEELIzSg9Pv30M4kOeDUmLn/0kQSf4FAlyIM9kACgkQUmLn/0kQ Sf4/9g//RJiubO4VycJh6NzhblCYJIUMSglknaesQkh9rsrOhQ8okXNU0sHKyr04 wkhu/7gbO3kImPXan7aTGj5rOoNq8XVOWef/f6xKiifJ5PDF7W5s+aD/H5lT2wXp K1U6oj48Pwb1WYZQIDR4avj8/0fqCQyWkfqE6fpy7h7D76wbg9qt6ptxQ2BRcu5R fCkj6NKppCkcWjKUKVOquDhrMOw9kUKyrBi8WsRFQiXGEBAn74xmM1dd41N/IA5f +sGYrw0vHIQaCoNEqzeIfuXSGRqIo0F6+oje31ljoMqejWpi+twefleoYjRUBuPd ypX7veuhNpVeb4Tt7Gjqm9pKQnJZVQxze3BDzxhrXtiqij7pwn6Gisg1c9pBNtgw ZupyESXvyFArV6skQq/AKRA4OMdIeDRCMmXhmrnSuSMTBSSYZZK5tN2mzfo7g6Qf bv90hcy/VwW7F1ab+94XL6T9/AtAWrh9t+3NQ1qofqV4lsH34PraXPHpj6wE3GZj 1+V3iCeZak8LzeWkoYtRTkj7j+3UsIq84PeUOct1i7hV4DjXD3TSnTAhLm8A7zDi 6XJCHxvnHgRtGmoRslq+pX40sTOJltrxoG0bPRQREjUlkJPSUFb1Z7bCrANZofNc JPeCpsxzYe2yF5xpOM4GMvaDwOVAj89YsUa+3sERJmDTr0Bi60Q= =3G6h -----END PGP SIGNATURE-----
--- End Message ---
